From patchwork Wed Feb 17 11:56:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 584078 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 896B91402BC for ; Wed, 17 Feb 2016 22:56:34 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=iGUOskCU; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=ser9ZcPzT7AjrcSH G3fd4CfzMtiLw4B7AUvlFLwfkzPi5ZixAAcKdMjcdPdhGxX1+HdY9rE+6Hfl6Nxb 9MQALlvr8JQJHiMcs8bm2QH7CfQXPtDs16TI8NQczXo8h7REpkr+5RYCCfTd0UjA HF49Im/eyA/44Dl3ziQY+/qc2fs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=7PyYY1MVs6Ldm4TArzn5gY 0M1fo=; b=iGUOskCUnlaJkinq3UEppahf2ryXPsk7pDmZrBPUHXT/i4bjsDpOJw Y/caQHitSeB+DJCvUJCKSjtApeJBvrHIy5UnNd1klbnPQA0aN37zYVxYqe3XRiZF 8I1gBgUUhQHW4DukbKfesYhqRyin6cDgd5YFkunlNA06lLQY9uMQE= Received: (qmail 80564 invoked by alias); 17 Feb 2016 11:56:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 80537 invoked by uid 89); 17 Feb 2016 11:56:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1020, H*MI:outlook, H*MI:prod, 2016-02-17 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Feb 2016 11:56:23 +0000 Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3lrp0079.outbound.protection.outlook.com [213.199.154.79]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-29-ItEFC85wQOOr3UAoseMOqA-1; Wed, 17 Feb 2016 11:56:16 +0000 Received: from AM3PR08MB0088.eurprd08.prod.outlook.com (2a01:111:e400:8847::18) by AM3PR08MB0087.eurprd08.prod.outlook.com (2a01:111:e400:8847::17) with Microsoft SMTP Server (TLS) id 15.1.409.15; Wed, 17 Feb 2016 11:56:10 +0000 Received: from AM3PR08MB0088.eurprd08.prod.outlook.com ([fe80::7ddb:7f7c:2b4f:2676]) by AM3PR08MB0088.eurprd08.prod.outlook.com ([fe80::7ddb:7f7c:2b4f:2676%14]) with mapi id 15.01.0409.017; Wed, 17 Feb 2016 11:56:11 +0000 From: Wilco Dijkstra To: "gcc-patches@gcc.gnu.org" CC: nd Subject: [COMMITTED][AArch64] Add missing return in aarch64_internal_mov_immediate Date: Wed, 17 Feb 2016 11:56:10 +0000 Message-ID: x-microsoft-exchange-diagnostics: 1; AM3PR08MB0087; 5:f1Pob3Ch6OtHZfF7kZuCmbSliXYaqhXBL+Tqnk5d7l0hT18V1iAP18k0dczIZMJPA596BU9lNkB8hagBVsfHiUwmMRcNQj6jO3Q3cXxZW53AClNh09PE/TKlzr7b4mMbGkZNTsuZE5nzpruzHrC4Nw==; 24:wDUgIofu1PkAQWbgYLy8RtuEcBTDytR0fozxVY/5jvJ9oTQIXfH3rnHZBA8ED56F7CUu4Ibb+6xHHFxq1rX3dLUkxwq83E5rLWp6rkwzhxQ=; 20:RziWdbQPXUsVPJXh3w6Qmmik/g4WbPcm1htspQesFWdLl1OWyFC91GGJ+BHLKF4X9KzVKezGnzbrFiUzf2hyItVD1x//XJivyWot/wkT2kqdXxeSNN/IXTBaogljBD7BG0TuBSYJqMIqslNHUT7W102Zv/pdhxllpU4UDrgP0bY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0087; x-ms-office365-filtering-correlation-id: b4bab64e-1579-4faf-26de-08d337915422 nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:AM3PR08MB0087; BCL:0; PCL:0; RULEID:; SRVR:AM3PR08MB0087; x-forefront-prvs: 085551F5A8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(377424004)(189998001)(106116001)(5004730100002)(74316001)(76576001)(19580405001)(5008740100001)(86362001)(87936001)(2351001)(229853001)(33656002)(19580395003)(110136002)(5001960100002)(5002640100001)(102836003)(1220700001)(2906002)(1096002)(3846002)(3280700002)(2501003)(2900100001)(450100001)(5250100002)(5003600100002)(92566002)(40100003)(3660700001)(66066001)(586003)(54356999)(50986999)(6116002)(4326007)(14773001)(15760500001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR08MB0087; H:AM3PR08MB0088.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2016 11:56:10.6931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0087 X-MC-Unique: ItEFC85wQOOr3UAoseMOqA-1 As part of the final cleanup of aarch64_internal_mov_immediate a return was accidentally removed. This causes the 2-instruction case to fallthrough into the general case even when it found a match. An example immediate is 0xcccccccccccccccd which was using 2 instructions in GCC5 but now requires 4. Adding the return fixes the regressions. Committed as trivial in revision 233490. 2016-02-17 Wilco Dijkstra gcc/ * config/aarch64/aarch64.c (aarch64_internal_mov_immediate): Add missing return. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index a2fc3d05158e126f91e8274e9d5329f511d09530..9be5fbbd9716d9cf9568acee01996ff97ab5a654 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -1632,6 +1632,7 @@ aarch64_internal_mov_immediate (rtx dest, rtx imm, bool generate, emit_insn (gen_insv_immdi (dest, GEN_INT (i), GEN_INT ((val >> i) & 0xffff))); } + return 2; } }