From patchwork Sun Dec 15 11:25:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 1209904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-515997-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="dLYKmic1"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47bMXt3hGnz9sP6 for ; Sun, 15 Dec 2019 22:26:04 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:content-type:mime-version; q=dns; s= default; b=cfuQxK1Tv4EZdrAY/x5VwRQQ2cGInVwpufoWB9dCOY5JcTp//zFG0 qnZgmwNB8y0dTnNpC6lgPwT8HURXItkGeRhoLWkTfnbPe8gwHUUU81W1k4zq2/4V P2lVEqX763Cbp5IY5aEZB1iap/hBEiJXnm+KzKILTaNvMv/D9Ahx8M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:content-type:mime-version; s= default; bh=mv/klN/QXmR+8Pbfk9kGlZUeo4Y=; b=dLYKmic1xUqy5z4jeDF5 PCvwB4Jq24FQ24qe6C6Fv0R/Dxf/t3mbtPOFHOCfU9KrN5qhBwV9exK4+imF4UuD 7h/+lyYoSv0Pt3NIh6nx4KkrO2yUauSpU14oc8b+BymVkPjrpiOIGTqph+5izz1H BQ1//HIGfCcM5DesZtCV1KE= Received: (qmail 90065 invoked by alias); 15 Dec 2019 11:25:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 90056 invoked by uid 89); 15 Dec 2019 11:25:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=berndedlingerhotmailde, H*MI:sk:AM0PR08, bernd.edlinger@hotmail.de X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-oln040092065104.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.92.65.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2019 11:25:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SMiSPx7YC/SmOSb/SLefvEkynvJp80S2RpQ9Pjo493/B0olJGVw+zf5rR63icFo7NV9N2OhN0onKoll1401oFRb2L7c68KTL3zONkYrgsKtwgXUd4FkRHzSJRPA1cyBGP5qtGprfWOduoqjnCIZrRYFxr7BkBVlne1ealFqmI2VSJjkiOE2oxo6WuKFvTpAZPS+eMjByOM8y4Wj/V8J6PdW+s2a9aWPoJgHoYBctjKVcp03stjnD8/P4QwsfyJZuyoT/A0Q3ITd5748PUvoQgooePsAzNh0wrLOL2lDYXc+2E7IBZprsBJr/g5SWM1I/MIwd6k062pjsg4ksXF/djg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ISgBR07ybhuz2P4d6Qc0gA39rY3D7easgf7psWBaBcQ=; b=S64h1pOsuQ65Q98UpEBmFSeEkMeITRBMRaxO21Vi9a/uj8U6LWLiZznEfpOJ6vdsdVmHldt8FPT/IWrDOM/36OHy3bJlPa7fzbUAtylsEadQ9EVik0x2JN81ZQFzbgFL8LMup5uHsuozVV6K08h2xzCDUqrHJHU7rtEtRu89Y2qpqbI/uIDLonRipoxhwqJ9d0x30DuLRfPcjxB1LXKS5oDwGk4vWvyRUY9XKTDbRhYGAbWvMl2jl4+aSwspfHiXfMHkSHV65yLj9nqhh/uXM+YOxolKdyhbbZcT5dGqKpcLf9ZWo0jC9a+zC/1Q5BWjDKdex8Ou+MWpdCpdMFJ72Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB5EUR01FT063.eop-EUR01.prod.protection.outlook.com (10.152.4.55) by DB5EUR01HT238.eop-EUR01.prod.protection.outlook.com (10.152.5.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Sun, 15 Dec 2019 11:25:52 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com (10.152.4.53) by DB5EUR01FT063.mail.protection.outlook.com (10.152.5.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14 via Frontend Transport; Sun, 15 Dec 2019 11:25:52 +0000 Received: from AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769]) by AM0PR08MB3714.eurprd08.prod.outlook.com ([fe80::8dd1:fb18:6271:f769%7]) with mapi id 15.20.2538.019; Sun, 15 Dec 2019 11:25:52 +0000 From: Bernd Edlinger To: "gcc-patches@gcc.gnu.org" , Simon Marchi Subject: [PATCH] Fix skip.exp test failure observed with gcc-9.2.0 Date: Sun, 15 Dec 2019 11:25:52 +0000 Message-ID: x-microsoft-original-message-id: x-ms-exchange-transport-forked: True MIME-Version: 1.0 Hi, this is the split out patch on skip.exp which fixes a pre-existing compatibilty issue with that test case and gcc-9.2.0 (and gcc-10 from trunk of a few weeks ago at least, likely other versions too). Is it OK for trunk? Thanks Bernd. gdb/testsuite: 2019-12-15 Bernd Edlinger * gdb.base/skip.exp: Fix test failure observed with gcc-9.2.0. From b15964b769373f25f276430914c5efa84d411032 Mon Sep 17 00:00:00 2001 From: Bernd Edlinger Date: Sun, 15 Dec 2019 11:05:47 +0100 Subject: [PATCH] Fix skip.exp test failure observed with gcc-9.2.0 Need to step a second time because with this gcc version the first step jumps back to main before entering foo. --- gdb/testsuite/gdb.base/skip.exp | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.base/skip.exp b/gdb/testsuite/gdb.base/skip.exp index d763194..15dec42 100644 --- a/gdb/testsuite/gdb.base/skip.exp +++ b/gdb/testsuite/gdb.base/skip.exp @@ -21,8 +21,8 @@ load_lib completion-support.exp standard_testfile if { [prepare_for_testing "failed to prepare" "skip" \ - {skip.c skip1.c } \ - {debug nowarnings}] } { + {skip.c skip1.c } \ + {debug nowarnings}] } { return -1 } @@ -142,7 +142,9 @@ with_test_prefix "step after disabling 3" { gdb_test "step" "bar \\(\\) at.*" "step 1" gdb_test "step" ".*" "step 2"; # Return from foo() - gdb_test "step" "foo \\(\\) at.*" "step 3" + # With gcc 9.2.0 we jump once back to main before entering foo here. + # If that happens try to step a second time. + gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at .*" "step" gdb_test "step" ".*" "step 4"; # Return from bar() gdb_test "step" "main \\(\\) at.*" "step 5" } @@ -261,7 +263,9 @@ with_test_prefix "step using -fu for baz" { gdb_test_no_output "skip enable 7" gdb_test "step" "bar \\(\\) at.*" "step 1" gdb_test "step" ".*" "step 2"; # Return from bar() - gdb_test "step" "foo \\(\\) at.*" "step 3" + # With gcc 9.2.0 we jump once back to main before entering foo here. + # If that happens try to step a second time. + gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at.*" "step" gdb_test "step" ".*" "step 4"; # Return from foo() gdb_test "step" "main \\(\\) at.*" "step 5" } @@ -276,7 +280,9 @@ with_test_prefix "step using -rfu for baz" { gdb_test_no_output "skip enable 8" gdb_test "step" "bar \\(\\) at.*" "step 1" gdb_test "step" ".*" "step 2"; # Return from bar() - gdb_test "step" "foo \\(\\) at.*" "step 3" + # With gcc 9.2.0 we jump once back to main before entering foo here. + # If that happens try to step a second time. + gdb_test "step" "foo \\(\\) at.*" "step 3" "main \\(\\) at.*" "step" gdb_test "step" ".*" "step 4"; # Return from foo() gdb_test "step" "main \\(\\) at.*" "step 5" } -- 1.9.1