From patchwork Wed Dec 14 10:52:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Toma Tabacu X-Patchwork-Id: 705640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tdthb6SN6z9sCN for ; Wed, 14 Dec 2016 21:53:02 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="BvJHwb1Z"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=wz1 lIPOkdgoYDbCRp9CIBVar139DHrSr2oVcy/Uuj2SRmk4x5Nmrh1EsCzGr3+toeXY z8qT7np2gPtscaq3MDfcOISzTXuQYvM7erZX7NMDAeVvbP4Mx0itaqH6N5dAQF9e 3Umx12zcYtMJPi8ZRcCybpR0zA5o26lxWJsOTX3M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=fMVLms2Bg jxAvJsXdYBDISv12vk=; b=BvJHwb1ZqZMwu4Re71M5bWrpcNEVj0khkqtHjmCO/ eVLvCpk6lYyMzwsej9xIl68wgvNT/ANT3Wgz8/h1zpCdELw4YqJhEW3bgc796GZr wUM1Gvz9f7w1HcKHUsXwWX25paBxV9iHsBh9Ys7XO7E+jNhEzbY192ggKJbBIRpB ds= Received: (qmail 13144 invoked by alias); 14 Dec 2016 10:52:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13108 invoked by uid 89); 14 Dec 2016 10:52:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1082, letting X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Dec 2016 10:52:52 +0000 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Forcepoint Email with ESMTPS id 5440F2056C2ED; Wed, 14 Dec 2016 10:52:47 +0000 (GMT) Received: from HHMAIL-X.hh.imgtec.org (10.100.10.113) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.294.0; Wed, 14 Dec 2016 10:52:49 +0000 Received: from HHMAIL01.hh.imgtec.org ([fe80::710b:f219:72bc:e0b3]) by HHMAIL-X.hh.imgtec.org ([fe80::3509:b0ce:371:2b%18]) with mapi id 14.03.0294.000; Wed, 14 Dec 2016 10:52:49 +0000 From: Toma Tabacu To: "gcc-patches@gcc.gnu.org" CC: Matthew Fortune , "catherine_moore@mentor.com" Subject: [PATCH, testsuite] MIPS: Remove redundant dg-skip-if from mips16-attributes.c. Date: Wed, 14 Dec 2016 10:52:48 +0000 Message-ID: MIME-Version: 1.0 X-IsSubscribed: yes Hi, In the case of mips16-attributes.c, even though the (-mips16) option ensures that -mmicromips will be overriden, there still is a dg-skip-if for -mmicromips. I think that it is not necessary and it actually decreases test coverage, because it will cause the testsuite to skip this test instead of letting (-mips16) do its job of overriding the global options. This patch removes the dg-skip-if for -mmicromips. Tested with mips-mti-elf. Regards, Toma gcc/testsuite/ChangeLog: * gcc.target/mips/mips16-attributes.c: Remove dg-skip-if for -mmicromips. diff --git a/gcc/testsuite/gcc.target/mips/mips16-attributes.c b/gcc/testsuite/gcc.target/mips/mips16-attributes.c index e1497c0..421aa77 100644 --- a/gcc/testsuite/gcc.target/mips/mips16-attributes.c +++ b/gcc/testsuite/gcc.target/mips/mips16-attributes.c @@ -3,7 +3,6 @@ function. */ /* { dg-do run } */ /* { dg-options "(-mips16) (REQUIRES_STDLIB)" } */ -/* { dg-skip-if "" { *-*-* } { "-mmicromips" } { "" } } */ #include