| Message ID | A614194ED15B4844BC4C9FB7F21FCD92225313C5@HHMAIL01.hh.imgtec.org |
|---|---|
| State | New |
| Headers | show |
> -----Original Message----- > From: Toma Tabacu [mailto:Toma.Tabacu@imgtec.com] > Sent: Monday, November 7, 2016 11:21 AM > gcc/testsuite/ChangeLog: > > 2016-11-07 Toma Tabacu <toma.tabacu@imgtec.com> > > * gcc.target/mips/mips.exp (mips-dg-options): Upgrade to MIPS IV if using > (HAS_MOVN) with MIPS III. > > diff --git a/gcc/testsuite/gcc.target/mips/mips.exp > b/gcc/testsuite/gcc.target/mips/mips.exp > index 39f44ff..e22d782 100644 > --- a/gcc/testsuite/gcc.target/mips/mips.exp > +++ b/gcc/testsuite/gcc.target/mips/mips.exp > @@ -1129,7 +1129,7 @@ proc mips-dg-options { args } { > # We need MIPS IV or higher for: > # > # > - } elseif { $isa < 3 > + } elseif { $isa < 4 > && [mips_have_test_option_p options "HAS_MOVN"] } > { > mips_make_test_option options "-mips4" > # We need MIPS III or higher for: Hi Toma, The patch itself is OK, but the ChangeLog entry line length is greater than 80. Do you have write access to the repository? Please let me know if you would like me to commit this for you? Thanks, Catherine
diff --git a/gcc/testsuite/gcc.target/mips/mips.exp b/gcc/testsuite/gcc.target/mips/mips.exp index 39f44ff..e22d782 100644 --- a/gcc/testsuite/gcc.target/mips/mips.exp +++ b/gcc/testsuite/gcc.target/mips/mips.exp @@ -1129,7 +1129,7 @@ proc mips-dg-options { args } { # We need MIPS IV or higher for: # # - } elseif { $isa < 3 + } elseif { $isa < 4 && [mips_have_test_option_p options "HAS_MOVN"] } { mips_make_test_option options "-mips4" # We need MIPS III or higher for:
Hi, The (HAS_MOVN) option should cause an upgrade to MIPS IV if the target is pre-MIPS IV. However, the upgrade condition checks for "$isa < 3", which means that we won't upgrade if we're targeting MIPS III. This results in failures for the movcc-{1,2,3}.c and branch-cost-2.c tests when the target is MIPS III. This patch fixes the condition to include MIPS III. Tested with mips-mti-elf. Regards, Toma Tabacu gcc/testsuite/ChangeLog: 2016-11-07 Toma Tabacu <toma.tabacu@imgtec.com> * gcc.target/mips/mips.exp (mips-dg-options): Upgrade to MIPS IV if using (HAS_MOVN) with MIPS III.