| Message ID | 9A8578C2-ADF9-49A2-87D9-0ACA4D29E44F@adacore.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add dg-require-effective-target fpic to an aarch64 specific test in gcc.dg | expand |
Olivier Hainque <hainque@adacore.com> writes: > Hello, > > This patch adds dg-require-effective-target fpic > to an aarch64 specific gcc.dg test using -fPIC, > which helps circumvent a failure we observed while > testing the aarch64 port for VxWorks. > > ok to commit ? OK, thanks. Also OK for any other current or future aarch64 test that has -fpic or -fPIC in the options and forgets to do this. Richard
> On 4 Nov 2020, at 20:16, Richard Sandiford <richard.sandiford@arm.com> wrote: > > Olivier Hainque <hainque@adacore.com> writes: >> Hello, >> >> This patch adds dg-require-effective-target fpic >> to an aarch64 specific gcc.dg test using -fPIC, >> which helps circumvent a failure we observed while >> testing the aarch64 port for VxWorks. >> >> ok to commit ? > > OK, thanks. Also OK for any other current or future aarch64 test that > has -fpic or -fPIC in the options and forgets to do this. Great, thanks Richard! This echoes what you had actually already told me some months ago at https://gcc.gnu.org/pipermail/gcc-patches/2019-December/536909.html which I didn't remember before sending this patch. For the avoidance of doubt, that would hold for arm tests as well, right ? (I'll be careful not to introduce obvious redundancy with e.g. os=linux, as pointed out by Jakub earlier this week for another set on i386). Cheers, Olivier
Olivier Hainque <hainque@adacore.com> writes: >> On 4 Nov 2020, at 20:16, Richard Sandiford <richard.sandiford@arm.com> wrote: >> >> Olivier Hainque <hainque@adacore.com> writes: >>> Hello, >>> >>> This patch adds dg-require-effective-target fpic >>> to an aarch64 specific gcc.dg test using -fPIC, >>> which helps circumvent a failure we observed while >>> testing the aarch64 port for VxWorks. >>> >>> ok to commit ? >> >> OK, thanks. Also OK for any other current or future aarch64 test that >> has -fpic or -fPIC in the options and forgets to do this. > > Great, thanks Richard! > > This echoes what you had actually already told me some > months ago at > > https://gcc.gnu.org/pipermail/gcc-patches/2019-December/536909.html > > which I didn't remember before sending this patch. > > For the avoidance of doubt, that would hold for arm > tests as well, right ? Yeah, it does. Thanks, Richard > (I'll be careful not to introduce obvious redundancy with e.g. > os=linux, as pointed out by Jakub earlier this week for another > set on i386). > > Cheers, > > Olivier
> On 6 Nov 2020, at 19:03, Richard Sandiford <richard.sandiford@arm.com> wrote: >>> OK, thanks. Also OK for any other current or future aarch64 test that >>> has -fpic or -fPIC in the options and forgets to do this. >> For the avoidance of doubt, that would hold for arm >> tests as well, right ? > > Yeah, it does. > > Thanks, Sure, thanks for confirming. Cheers, Olivier
diff --git a/gcc/testsuite/gcc.dg/sms-12.c b/gcc/testsuite/gcc.dg/sms-12.c index aef32ee0286b..3ec50f272f19 100644 --- a/gcc/testsuite/gcc.dg/sms-12.c +++ b/gcc/testsuite/gcc.dg/sms-12.c @@ -1,5 +1,6 @@ /* { dg-do run } */ /* { dg-skip-if "" { ! { aarch64*-*-* } } } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fmodulo-sched -funroll-loops -fdump-rtl-sms --param sms-min-sc=1 -fmodulo-sched-allow-regmoves -fPIC" } */ extern void abort (void);
Hello, This patch adds dg-require-effective-target fpic to an aarch64 specific gcc.dg test using -fPIC, which helps circumvent a failure we observed while testing the aarch64 port for VxWorks. ok to commit ? Thanks in advance, Best Regards, Olivier 2020-11-03 Olivier Hainque <hainque@adacore.com> testsuite/ * gcc.dg/sms-12.c: Add dg-require-effective-target fpic.