diff mbox series

[COMMITTED] Ranger: More efficient zero/nonzero check.

Message ID 946fc834-f681-1990-4fcd-7be6a8a357ab@redhat.com
State New
Headers show
Series [COMMITTED] Ranger: More efficient zero/nonzero check. | expand

Commit Message

Andrew MacLeod Oct. 6, 2021, 2:53 p.m. UTC 
This is the first in a set of performance improvements.  Over the summer 
a few things have snuck in that are slowing down EVRP.

A recent change introduced a frequent check for zero and non-zero which 
has caused a lot of extra temporary trees to be created.

This patch makes the check more efficient as the non-null processing is 
always a pointer and thus unsigned.

Over a set of 380 GCC source files, it produces a 13% speedup in EVRP.

Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed.

Andrew
diff mbox series

Patch

From 4b8ca6c6177b2bd948c1cb2a116955b942751559 Mon Sep 17 00:00:00 2001
From: Andrew MacLeod <amacleod@redhat.com>
Date: Mon, 27 Sep 2021 18:53:54 -0400
Subject: [PATCH 1/4] Ranger: More efficient zero/nonzero check.

A recent change introduced a frequent check for zero and non-zero which has
caused a lot of extra temporary trees to be created.  Make the check more
efficent as it is always a pointer and thus unsigned.

	* gimple-range-cache.cc (non_null_ref::adjust_range): Check for
	zero and non-zero more efficently.
---
 gcc/gimple-range-cache.cc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc
index 61043d3f375..91dd5a5c087 100644
--- a/gcc/gimple-range-cache.cc
+++ b/gcc/gimple-range-cache.cc
@@ -98,9 +98,10 @@  non_null_ref::adjust_range (irange &r, tree name, basic_block bb,
     return false;
 
   // We only care about the null / non-null property of pointers.
-  if (!POINTER_TYPE_P (TREE_TYPE (name)) || r.zero_p () || r.nonzero_p ())
+  if (!POINTER_TYPE_P (TREE_TYPE (name)))
+    return false;
+  if (r.undefined_p () || r.lower_bound () != 0 || r.upper_bound () == 0)
     return false;
-
   // Check if pointers have any non-null dereferences.
   if (non_null_deref_p (name, bb, search_dom))
     {
-- 
2.17.2