From patchwork Sun Jan 13 08:56:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 211605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id EBE472C00F8 for ; Sun, 13 Jan 2013 19:56:41 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358672203; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Mail-Followup-To:Subject:Date:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=QJnZ+e1LfMHRg6nz4WlCfF38/jk=; b=gcfOAaHjYAF4fQu M6QZOKY46jynXHeRKOPn44BE1nHr6LXkbs8c5JpDZ9VwBCwguphb/nMqwZFgi0Bk K343Lf9WQIJxtQ3kRAKbHkrHZgvLpPt7BhyZWrFUpmIMNhIDAEc0eGHLmJDLEVaW 8kckDezHZ7noxyfwLdhIqqc5iYGQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Received:Received:From:To:Mail-Followup-To:Subject:Date:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=LYrEUVPFNU18ZoaB2CdzEP24Drsx1F68eC4U2xENdgBXuJLUz9Pd0DStNZVVj/ JgJLA21SkVbky9WvRSrBhtaWkw8ONWbWJLpJT4yY48S231Txb0LimdP010Eg971d LNu2f8LxGJuBebifXXD3UW5ZGPc6IvcvIF5lFhB8EunkI=; Received: (qmail 2416 invoked by alias); 13 Jan 2013 08:56:34 -0000 Received: (qmail 2398 invoked by uid 22791); 13 Jan 2013 08:56:34 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL, BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KHOP_RCVD_TRUST, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f174.google.com (HELO mail-wi0-f174.google.com) (209.85.212.174) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 13 Jan 2013 08:56:28 +0000 Received: by mail-wi0-f174.google.com with SMTP id hq4so654128wib.7 for ; Sun, 13 Jan 2013 00:56:27 -0800 (PST) X-Received: by 10.194.57.206 with SMTP id k14mr128950462wjq.26.1358067387047; Sun, 13 Jan 2013 00:56:27 -0800 (PST) Received: from localhost ([2.26.203.77]) by mx.google.com with ESMTPS id bd7sm7848596wib.8.2013.01.13.00.56.25 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 13 Jan 2013 00:56:26 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: [committed] Add nomips16 attributes to gcc.dg/unroll_5.c Date: Sun, 13 Jan 2013 08:56:24 +0000 Message-ID: <87zk0dxxzb.fsf@talisman.default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org gcc.dg/unroll_5.c fails on MIPS16 because we don't recognise the MIPS16 XOR-based equality comparisons as being equality comparisons. I suppose that might be worth handling in principle, but unrolling isn't something that MIPS16 users are likely to want anyway, so it's not really an interesting use case. Ideally we'd XFAIL this for MIPS16, but that's difficult because of -mflip-mips16, which will cause one function to be compiled normally (and work) and another to be compiled as -mips16 (and fail). In the past I've added nomips16 attributes instead, so I've done the same here. Tested on x86_64-linux-gnu, mipsisa64-elf and mips64-linux-gnu. Applied. Richard gcc/testsuite/ * gcc.dg/unroll_5.c: Add nomips16 attributes. Index: gcc/testsuite/gcc.dg/unroll_5.c =================================================================== --- gcc/testsuite/gcc.dg/unroll_5.c 2012-11-27 18:52:27.000000000 +0000 +++ gcc/testsuite/gcc.dg/unroll_5.c 2013-01-12 12:43:37.086146761 +0000 @@ -4,6 +4,11 @@ void abort (void); int *a; +/* Fails on MIPS16 because equality checks are implemented using XOR. + It's unlikely MIPS16 users would want unrolling anyway. */ +#ifdef __mips +__attribute__((nomips16)) +#endif int t() { int i; @@ -12,6 +17,9 @@ int t() return 1; return 0; } +#ifdef __mips +__attribute__((nomips16)) +#endif int t2() { int i;