From patchwork Fri Jul 25 16:01:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 373746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BDF911400A3 for ; Sat, 26 Jul 2014 02:01:53 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=vuLiwFaiMb0sARFg Twh4OkCCaUOpzCnprmkWhLZMThoihMyn536q2Xor7zF5AwkDt8zO2aSfcCb7pR/y EBaSnX/6P6gbzeYgXmW12Nvc4Hf6F6q7ZlhYXohhlrnTPz7DblMbYcXnfrdUG6pr Xanz6jcOmT8o28oDohwkXVQXnOs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=QRFkfPY3BRK9tsDhm6m5eG jDPoA=; b=h5WpdXMB1AQTzlCJvjARkTuSXP5VnU6g6ESXA+FDnHiZiwU0xCaaIa e4gdhUwPRY54xjy62V/GDi+HMKy6Zi9TN7gJ0p8OOC0cJ9U9rINpbdvoa//R9ydf oZm6+Cq4Lm48rrARcXYXTonq8TA2TFkA7Xbu9k7TNNNvD1Qa+g/lA= Received: (qmail 28187 invoked by alias); 25 Jul 2014 16:01:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28164 invoked by uid 89); 25 Jul 2014 16:01:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Jul 2014 16:01:35 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1XAhw0-0003eF-DX from Thomas_Schwinge@mentor.com ; Fri, 25 Jul 2014 09:01:28 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 25 Jul 2014 09:01:28 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 25 Jul 2014 17:01:26 +0100 From: Thomas Schwinge To: Cesar Philippidis CC: , , Ilmir Usmanov , Ilmir Usmanov , Jakub Jelinek , Tobias Burnus Subject: Re: FWD: Re: OpenACC subarray specifications in the GCC Fortran front end In-Reply-To: <53D18C3D.2000609@codesourcery.com> References: <87ha4p92qj.fsf@schwinge.name> <53763254.1000402@samsung.com> <537DA7CD.4050407@samsung.com> <87fvi8p5mp.fsf@schwinge.name> <20140711102920.GR31640@tucnak.redhat.com> <53D05678.3080501@codesourcery.com> <87a97yrjf7.fsf@schwinge.name> <53D18C3D.2000609@codesourcery.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Fri, 25 Jul 2014 18:01:20 +0200 Message-ID: <87tx65pgvj.fsf@schwinge.name> MIME-Version: 1.0 Hi Cesar! On Thu, 24 Jul 2014 15:44:13 -0700, Cesar Philippidis wrote: > On 07/24/2014 06:11 AM, Thomas Schwinge wrote: > > I'd suggest to continue to handle all the data clauses [...] > > I moved all of the data clause matching back to gfc_match_omp_clauses, > and I guarded the copyin clause with the openacc flag. Thanks! > It looks like the > private clause may also require a special memory mapping, so I left the > openacc flag in place. Where is that? (I don't see it.) > Is this patch OK to commit to gomp-4_0-branch? Yes, though you may directly fold in the following patch to nuke the unused OMP_LIST_COPY (or do that later). Grüße, Thomas --- gcc/fortran/dump-parse-tree.c +++ gcc/fortran/dump-parse-tree.c @@ -1257,7 +1257,6 @@ show_omp_clauses (gfc_omp_clauses *omp_clauses) const char *type = NULL; switch (list_type) { - case OMP_LIST_COPY: type = "COPY"; break; case OMP_LIST_DEVICEPTR: type = "DEVICEPTR"; break; case OMP_LIST_USE_DEVICE: type = "USE_DEVICE"; break; case OMP_LIST_DEVICE_RESIDENT: type = "USE_DEVICE"; break; --- gcc/fortran/gfortran.h +++ gcc/fortran/gfortran.h @@ -1157,9 +1157,8 @@ enum OMP_LIST_TO, OMP_LIST_FROM, OMP_LIST_REDUCTION, - OMP_LIST_COPY, - OMP_LIST_DATA_CLAUSE_FIRST = OMP_LIST_COPY, OMP_LIST_DEVICEPTR, + OMP_LIST_DATA_CLAUSE_FIRST = OMP_LIST_DEVICEPTR, OMP_LIST_DATA_CLAUSE_LAST = OMP_LIST_DEVICEPTR, OMP_LIST_DEVICE_RESIDENT, OMP_LIST_USE_DEVICE,