From patchwork Thu Aug 4 13:52:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 655810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3s4rx72r1Bz9sBr for ; Thu, 4 Aug 2016 23:52:52 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=m6qLD77O; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type; q=dns; s=default; b=mQyuzZaYo9wEjsEWxms0bYeYoneOQ TIV1lowuh78Cj47l1RfhHKUVotkiRZl0uAI2N/Ma0VDVm0NahQ88WxyK51lZj3cf zAb7jsEyB8lxeqQHF4HXyzOvp8T2AtOnJVOtsNMyprM/Fx9Dex3dj6koatZwjryI uGc1ENBasbBBOc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type; s=default; bh=PTou++nbO48o69tdsATIIECyB10=; b=m6q LD77OPYVPbccbqnZbk31OPzmNXbrO9nqUdm0vHvX3+FosHDBP+PaJb/+TOvyiWj8 WUwqs16qhMLnB1ifwi4SLWR0YNOg4qEfYQnS2ZcRUuSvwf+TFhj9KqdvSpXtVaUr M+w2AW20lOBA+sztryl1jgZbSyYx4Eu1OOrp2DcQ= Received: (qmail 11517 invoked by alias); 4 Aug 2016 13:52:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11502 invoked by uid 89); 4 Aug 2016 13:52:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=nonexistent, crash1c, ICEd, worker_matmul X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Aug 2016 13:52:33 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1bVJ4Y-0001Bv-TR from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Thu, 04 Aug 2016 06:52:30 -0700 Received: from tftp-cs (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Thu, 4 Aug 2016 06:52:30 -0700 Received: by tftp-cs (Postfix, from userid 49978) id 15FB8C2320; Thu, 4 Aug 2016 06:52:30 -0700 (PDT) From: Thomas Schwinge To: Nathan Sidwell , GCC Patches Subject: Re: [PTX] fix worker propagation ICE In-Reply-To: <6af195bc-be9b-b71a-f92d-7116bdf3f372@acm.org> References: <6af195bc-be9b-b71a-f92d-7116bdf3f372@acm.org> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Thu, 4 Aug 2016 15:52:17 +0200 Message-ID: <87twf08wvi.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Wed, 3 Aug 2016 13:30:10 -0400, Nathan Sidwell wrote: > --- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c (nonexistent) > +++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c (working copy) > @@ -0,0 +1,28 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O0" } */ Offloading compilation happens at link time not compile time, and in OpenACC libgomp testing, we're doing a limited set of torture testing (-O0, -O2), so no point in hardcoding -O0 here. As obvious, committed to trunk in r239125: commit ec8d61ace153843dcaaba86ad926f384a4affee3 Author: tschwinge Date: Thu Aug 4 13:34:57 2016 +0000 Make libgomp.oacc-c-c++-common/crash-1.c a "link" test, and don't hardcode -O0 libgomp/ * testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link" test, and don't hardcode -O0. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@239125 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 5 +++++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) Grüße Thomas diff --git libgomp/ChangeLog libgomp/ChangeLog index 850188f..cc76b7b 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,3 +1,8 @@ +2016-08-04 Thomas Schwinge + + * testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link" + test, and don't hardcode -O0. + 2016-08-03 Nathan Sidwell * testsuite/libgomp.oacc-c-c++-common/crash-1.c: New. diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c index a75a817..dcf1485 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c @@ -1,7 +1,6 @@ -/* { dg-do compile } */ -/* { dg-options "-O0" } */ +/* { dg-do link } */ -/* ICEd in nvptx backend due to unexpected frame size. */ +/* For -O0, ICEd in nvptx backend due to unexpected frame size. */ #pragma acc routine worker void worker_matmul (int *c, int i) Backported to gomp-4_0-branch in r239129: commit bab445509b917c582a53834599f614ce2c29ff36 Author: tschwinge Date: Thu Aug 4 13:49:15 2016 +0000 Make libgomp.oacc-c-c++-common/crash-1.c a "link" test, and don't hardcode -O0 Backport trunk r239125: libgomp/ * testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link" test, and don't hardcode -O0. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@239129 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 6 ++++++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c | 5 ++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index 7a7d859..4320237 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,3 +1,9 @@ +2016-08-04 Thomas Schwinge + + Backport trunk r239125: + * testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link" + test, and don't hardcode -O0. + 2016-08-03 Nathan Sidwell * testsuite/libgomp.oacc-c-c++-common/crash-1.c: New. diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c index a75a817..dcf1485 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c @@ -1,7 +1,6 @@ -/* { dg-do compile } */ -/* { dg-options "-O0" } */ +/* { dg-do link } */ -/* ICEd in nvptx backend due to unexpected frame size. */ +/* For -O0, ICEd in nvptx backend due to unexpected frame size. */ #pragma acc routine worker void worker_matmul (int *c, int i)