From patchwork Tue Jun 18 22:44:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 1118377 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-503226-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="S6M+bli9"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45T37y1zsSz9s9y for ; Wed, 19 Jun 2019 08:45:30 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=QGF0OA6KKOWhBz2b eDN638Mzld5m8W6lUr1Ru11JWsokCMrMHQjnqiL7oaACAVOE+ITNenva05tUjAsi Jj/kCJlfBYwIFM+Mv20kPQ8YM82Mg8IF04f6vqgqt1af3QUPHKRF00mpzz2VSjxQ tlKuvH2zTijxjbZmYucdlCMOBfg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=jFODZd7V48pddOQ/jn4go5 9vva4=; b=S6M+bli9fjafCK26NBQWWzKKMWZc2NbCb6et0QubpfiGz/FvYoVkVY lcZ/u6aqk+1VbwLPdBOL6fazzonb7QhaYC3utaUZXqZRt2vfv1e10+6EeWfoUTu0 9safkV7tTfnwuCkjU7q3GavUeqOUYp4zVvjj9+rB0XJhBa5oT4d4w= Received: (qmail 31658 invoked by alias); 18 Jun 2019 22:45:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31602 invoked by uid 89); 18 Jun 2019 22:45:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Jun 2019 22:45:01 +0000 Received: from svr-orw-mbx-06.mgc.mentorg.com ([147.34.90.206]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hdMqZ-00040R-Lg from Thomas_Schwinge@mentor.com ; Tue, 18 Jun 2019 15:44:59 -0700 Received: from svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) by SVR-ORW-MBX-06.mgc.mentorg.com (147.34.90.206) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 18 Jun 2019 15:44:57 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) with Microsoft SMTP Server id 15.0.1320.4 via Frontend Transport; Tue, 18 Jun 2019 15:44:57 -0700 Received: by tftp-cs (Postfix, from userid 49978) id B79ACC2212; Tue, 18 Jun 2019 15:44:56 -0700 (PDT) From: Thomas Schwinge To: CC: Jakub Jelinek Subject: [committed] Fix description of 'GOMP_MAP_FIRSTPRIVATE' (was: [OpenACC] declare directive) In-Reply-To: <87vb8sriwv.fsf@kepler.schwinge.homeip.net> References: <5638E164.5010207@codesourcery.com> <87611h1zi7.fsf@kepler.schwinge.homeip.net> <563CD07A.3000404@codesourcery.com> <20151106190352.GG5675@tucnak.redhat.com> <563F6BA5.9020606@codesourcery.com> <5640C35C.9030907@codesourcery.com> <20151109162117.GU5675@tucnak.redhat.com> <56412830.9030100@codesourcery.com> <20151111083233.GE5675@tucnak.redhat.com> <5643E66E.9000202@codesourcery.com> <20151112090959.GX5675@tucnak.redhat.com> <56449572.9050907@codesourcery.com> <87vb8sriwv.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Wed, 19 Jun 2019 00:44:39 +0200 Message-ID: <87sgs6fr8o.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Mon, 23 Nov 2015 13:37:20 +0100, I wrote: > Hi Jim! > > A few things I noticed when working on merging your trunk r230275 into > gomp-4_0-branch. Please fix these (on trunk). > | --- include/gomp-constants.h > | +++ include/gomp-constants.h > | @@ -72,6 +72,11 @@ enum gomp_map_kind > | POINTER_SIZE_UNITS. */ > | GOMP_MAP_FORCE_DEVICEPTR = (GOMP_MAP_FLAG_SPECIAL_1 | 0), > | /* Do not map, copy bits for firstprivate instead. */ > | + /* OpenACC device_resident. */ > | + GOMP_MAP_DEVICE_RESIDENT = (GOMP_MAP_FLAG_SPECIAL_1 | 1), > | + /* OpenACC link. */ > | + GOMP_MAP_LINK = (GOMP_MAP_FLAG_SPECIAL_1 | 2), > | + /* Allocate. */ > | GOMP_MAP_FIRSTPRIVATE = (GOMP_MAP_FLAG_SPECIAL | 0), > | /* Similarly, but store the value in the pointer rather than > | pointed by the pointer. */ > > I suspect the "Do not map, copy bits for firstprivate instead" comment > still applies to GOMP_MAP_FIRSTPRIVATE only, which here (unintended?) got > an "Allocate" comment added? As obvious, now fixed on trunk in r272450 "Fix description of 'GOMP_MAP_FIRSTPRIVATE'", see attached. Grüße Thomas From 2a0899eaf3a9aabe64cb0649fd7a7fa263ebfcaa Mon Sep 17 00:00:00 2001 From: tschwinge Date: Tue, 18 Jun 2019 22:14:52 +0000 Subject: [PATCH] Fix description of 'GOMP_MAP_FIRSTPRIVATE' ..., which got garbled in r230275. include/ * gomp-constants.h (enum gomp_map_kind): Fix description of 'GOMP_MAP_FIRSTPRIVATE'. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@272450 138bc75d-0d04-0410-961f-82ee72b054a4 --- include/ChangeLog | 5 +++++ include/gomp-constants.h | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/ChangeLog b/include/ChangeLog index 28f4664aa557..6d09a8d6e07b 100644 --- a/include/ChangeLog +++ b/include/ChangeLog @@ -1,3 +1,8 @@ +2019-06-18 Thomas Schwinge + + * gomp-constants.h (enum gomp_map_kind): Fix description of + 'GOMP_MAP_FIRSTPRIVATE'. + 2019-06-10 Martin Liska * ansidecl.h (ATTRIBUTE_WARN_UNUSED_RESULT): New macro. diff --git a/include/gomp-constants.h b/include/gomp-constants.h index 8b93634f1b8b..82e9094c9342 100644 --- a/include/gomp-constants.h +++ b/include/gomp-constants.h @@ -71,12 +71,11 @@ enum gomp_map_kind /* Is a device pointer. OMP_CLAUSE_SIZE for these is unused; is implicitly POINTER_SIZE_UNITS. */ GOMP_MAP_FORCE_DEVICEPTR = (GOMP_MAP_FLAG_SPECIAL_1 | 0), - /* Do not map, copy bits for firstprivate instead. */ /* OpenACC device_resident. */ GOMP_MAP_DEVICE_RESIDENT = (GOMP_MAP_FLAG_SPECIAL_1 | 1), /* OpenACC link. */ GOMP_MAP_LINK = (GOMP_MAP_FLAG_SPECIAL_1 | 2), - /* Allocate. */ + /* Do not map, copy bits for firstprivate instead. */ GOMP_MAP_FIRSTPRIVATE = (GOMP_MAP_FLAG_SPECIAL | 0), /* Similarly, but store the value in the pointer rather than pointed by the pointer. */ -- 2.20.1