Message ID | 87r0kx6eez.fsf@oldenburg.str.redhat.com |
---|---|
State | New |
Headers | show |
Series | aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c | expand |
The 11/10/2023 12:22, Florian Weimer wrote: > This test looks like it intends to pass a small struct argument > through both a non-variadic and variadic argument, but due to > the typo, it does not achieve that. > > gcc/testsuite/ > > * gcc.target/aarch64/aapcs64/ice_1.c (foo): Call named. FWIW, this looks good to me. (but i cannot approve patches) > > --- > gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c > index 906ccebf616..edc35db2f6e 100644 > --- a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c > +++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c > @@ -16,6 +16,6 @@ void unnamed (int, ...); > > void foo () > { > - name (0, aaaa); > + named (0, aaaa); > unnamed (0, aaaa); > } > > base-commit: 5f6c5fe078c45bc32c8d21da6b14c27c0ed7be6e >
On 10/11/2023 11:22, Florian Weimer wrote: > This test looks like it intends to pass a small struct argument > through both a non-variadic and variadic argument, but due to > the typo, it does not achieve that. > > gcc/testsuite/ > > * gcc.target/aarch64/aapcs64/ice_1.c (foo): Call named. > > --- > gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c > index 906ccebf616..edc35db2f6e 100644 > --- a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c > +++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c > @@ -16,6 +16,6 @@ void unnamed (int, ...); > > void foo () > { > - name (0, aaaa); > + named (0, aaaa); > unnamed (0, aaaa); > } > > base-commit: 5f6c5fe078c45bc32c8d21da6b14c27c0ed7be6e > OK. R.
diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c index 906ccebf616..edc35db2f6e 100644 --- a/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c +++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/ice_1.c @@ -16,6 +16,6 @@ void unnamed (int, ...); void foo () { - name (0, aaaa); + named (0, aaaa); unnamed (0, aaaa); }