diff mbox series

Address '?:' issues in 'libgomp.oacc-c-c++-common/mode-transitions.c'

Message ID 87pmud7k49.fsf@euler.schwinge.homeip.net
State New
Headers show
Series Address '?:' issues in 'libgomp.oacc-c-c++-common/mode-transitions.c' | expand

Commit Message

Thomas Schwinge Aug. 16, 2021, 10:35 a.m. UTC 
Hi!

Pushed "Address '?:' issues in
'libgomp.oacc-c-c++-common/mode-transitions.c'" to master branch in
commit a2ab2f0dfba0fa69ebf6c82e34750911b2e5a639, see attached.


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
diff mbox series

Patch

From a2ab2f0dfba0fa69ebf6c82e34750911b2e5a639 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Wed, 11 Aug 2021 11:59:19 +0200
Subject: [PATCH] Address '?:' issues in
 'libgomp.oacc-c-c++-common/mode-transitions.c'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

    [...]/libgomp.oacc-c-c++-common/mode-transitions.c: In function ‘t3’:
    [...]/libgomp.oacc-c-c++-common/mode-transitions.c:127:43: warning: ‘?:’ using integer constants in boolean context, the expression will always evaluate to ‘true’ [-Wint-in-bool-context]
      127 |     assert (arr[i] == ((i % 64) < 32) ? 1 : -1);
          |                                           ^

    [...]/libgomp.oacc-c-c++-common/mode-transitions.c: In function ‘t9’:
    [...]/libgomp.oacc-c-c++-common/mode-transitions.c:359:46: warning: ‘?:’ using integer constants in boolean context, the expression will always evaluate to ‘true’ [-Wint-in-bool-context]
      359 |         assert (arr[i] == ((i % 3) == 0) ? 1 : 2);
          |                                              ^

..., and PR101862 "[C, C++] Potential '?:' diagnostic for always-true
expressions in boolean context".

	libgomp/
	* testsuite/libgomp.oacc-c-c++-common/mode-transitions.c: Address
	'?:' issues.
---
 .../testsuite/libgomp.oacc-c-c++-common/mode-transitions.c  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c
index 6c989abedf5..94dc9d05293 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/mode-transitions.c
@@ -124,7 +124,7 @@  void t3()
     assert (n[i] == 2);
 
   for (i = 0; i < 1024; i++)
-    assert (arr[i] == ((i % 64) < 32) ? 1 : -1);
+    assert (arr[i] == (((i % 64) < 32) ? 1 : -1));
 }
 
 
@@ -356,7 +356,7 @@  void t9()
       }
 
       for (i = 0; i < 1024; i++)
-	assert (arr[i] == ((i % 3) == 0) ? 1 : 2);
+	assert (arr[i] == ((i % 3) == 0 ? 1 : 2));
     }
 }
 
@@ -960,7 +960,7 @@  void t23()
   }
 
   for (i = 0; i < 32; i++)
-    assert (arr[i] == ((i % 2) != 0) ? i + 1 : i + 2);
+    assert (arr[i] == (((i % 2) != 0) ? i + 1 : i + 2));
 }
 
 
-- 
2.30.2