diff mbox

[gomp4] Initial support of OpenACC loop directive in C front-end.

Message ID 87mwglf9vq.fsf@schwinge.name
State New
Headers show

Commit Message

Thomas Schwinge March 20, 2014, 10:21 a.m. UTC 
Hi Ilmir!

On Tue, 18 Mar 2014 16:37:24 +0400, Ilmir Usmanov <i.usmanov@samsung.com> wrote:
> This patch introduces support of OpenACC loop directive (and combined 
> directives) in C front-end up to GENERIC. Currently no clause is allowed.

> --- /dev/null
> +++ b/gcc/testsuite/c-c++-common/goacc/loop-1.c
> @@ -0,0 +1,89 @@
> +/* { dg-do compile } */
> +
> +int test1()
> +{

> +  /* combined directives may be used*/
> +  #pragma acc parallel loop
> +  for(i = 1; i < 10; i++)
> +    {
> +    }
> +  #pragma acc kernels loop
> +  for(i = 1; i < 10; i++)
> +    {
> +    }
> +  return 0;
> +}
> +/* { dg-excess-errors "directive not yet implemented" } */
> \ No newline at end of file

I just realized that this is wrong usage of the dg-excess-errors
directive, for this one will absorb *all* remaining errors, whereas you
just wanted to mask out any »sorry, unimplemented: directive not yet
implemented« ones.

OK to fix as follows?

commit f83fdbfbc52e360b89b31a822a645b7f0dcabc96
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Thu Mar 20 11:04:12 2014 +0100

    Replace dg-excess-errors usage with dg-prune-output.
    
    	gcc/testsuite/
    	* c-c++-common/goacc/loop-1.c: Replace dg-excess-errors usage with
    	dg-prune-output.



Grüße,
 Thomas

Comments

Ilmir Usmanov March 20, 2014, 12:34 p.m. UTC | #1 
Hi Thomas!

On 20.03.2014 14:21, Thomas Schwinge wrote:
>
> I just realized that this is wrong usage of the dg-excess-errors
> directive, for this one will absorb *all* remaining errors, whereas you
> just wanted to mask out any »sorry, unimplemented: directive not yet
> implemented« ones.
Sorry for that. Next time I will more precise.
>
> OK to fix as follows?
Sure. Thanks!
diff mbox

Patch

diff --git gcc/testsuite/c-c++-common/goacc/loop-1.c gcc/testsuite/c-c++-common/goacc/loop-1.c
index 4546520..b890f38 100644
--- gcc/testsuite/c-c++-common/goacc/loop-1.c
+++ gcc/testsuite/c-c++-common/goacc/loop-1.c
@@ -69,4 +69,4 @@  int test1()
     }
   return 0;
 }
-/* { dg-excess-errors "directive not yet implemented" } */
\ No newline at end of file
+/* { dg-prune-output "sorry, unimplemented: directive not yet implemented" } */