From patchwork Wed Oct 24 17:57:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 193892 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 234602C00F3 for ; Thu, 25 Oct 2012 04:58:29 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1351706310; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:From:To:Mail-Followup-To:Subject:User-Agent:Date: Message-ID:MIME-Version:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=FuvnQ1ZDTpYI5upq7q1lVjQgEUM=; b=PQVccuoKZNZO8vi K+NRwFiCEMsjlgOBEAoF2TZhUlMFHmzeFX2JVjVqKeyyM0U41GY18C0/DvHyUOfS 8mTHAIYugdKd6NZjTzUGhGUckRdYm2afOeKv4rIpAfk6NDKnS4/EdaBAELNp4zI8 ihDHir1GlTIquHRRPRvqNhNwMl1U= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:From:To:Mail-Followup-To:Subject:User-Agent:Date:Message-ID:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=dRYouTI9Zv9r84cGlNIOpt1tldKMB5P4gvrr66vXcbYNIMTj5UOhYNZYn8Vbsb ulH+lg584bA+y+Sdc0e4BK7y14yySJsqh4xh0yv09XbZB6ePj2o09semcXS8+7hk ugP+hGr5xlWgOsOa4IctqxrMM4HISorVFU9jdNK3CYQ3E=; Received: (qmail 17412 invoked by alias); 24 Oct 2012 17:58:22 -0000 Received: (qmail 17400 invoked by uid 22791); 24 Oct 2012 17:58:21 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL, BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KHOP_RCVD_TRUST, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wg0-f51.google.com (HELO mail-wg0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Oct 2012 17:58:14 +0000 Received: by mail-wg0-f51.google.com with SMTP id ed3so464770wgb.8 for ; Wed, 24 Oct 2012 10:58:13 -0700 (PDT) Received: by 10.180.8.134 with SMTP id r6mr4186461wia.18.1351101493176; Wed, 24 Oct 2012 10:58:13 -0700 (PDT) Received: from sandifor-thinkpad.stglab.manchester.uk.ibm.com (gbibp9ph1--blueice2n1.emea.ibm.com. [195.212.29.75]) by mx.google.com with ESMTPS id v3sm6199784wiy.5.2012.10.24.10.57.39 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Oct 2012 10:58:09 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Subject: [committed] Unbreak powerpc bootstrap User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) Date: Wed, 24 Oct 2012 18:57:35 +0100 Message-ID: <87k3ufda7k.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org In the process of factoring out the "lowpart bit field" check from an earlier patch, I somehow managed to drop an "== 0" condition. It seems I then compounded that by screwing up the powerpc64 testing (still not sure how :-(). Anyway, fixed with the patch below, tested on powerpc64-linux-gnu. Sorry for the breakage, and thanks to Segher for the heads-up. Richard gcc/ * expmed.c (lowpart_bit_field_p): Add missing == 0 check. Index: gcc/expmed.c =================================================================== --- gcc/expmed.c 2012-10-24 11:32:33.000000000 +0100 +++ gcc/expmed.c 2012-10-24 18:52:58.303570945 +0100 @@ -402,7 +402,7 @@ lowpart_bit_field_p (unsigned HOST_WIDE_ enum machine_mode struct_mode) { if (BYTES_BIG_ENDIAN) - return (bitnum % BITS_PER_UNIT + return (bitnum % BITS_PER_UNIT == 0 && (bitnum + bitsize == GET_MODE_BITSIZE (struct_mode) || (bitnum + bitsize) % BITS_PER_WORD == 0)); else