From patchwork Tue May 23 16:02:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 766072 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wXKzt1jgTz9sPD for ; Wed, 24 May 2017 02:02:34 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="AOyR+Zdi"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=default; b=SSW 3u/S2o6Tlt+KdUgln9lhyhNTGORT1RImeTgoKOg1P8DrHRkmxCBstlijfjsJ9V44 rWt+IAUZrpcwEuPlqeoU5ew2i8ZoGd9bDsz+dUbkid5orrAuADR0VqfF8u8VVWu+ DshTJdhd10ULwQpn33DKlCqYekyg7mrbdi3AtIWo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=default; bh=/c6bmyWil 1xBuQsOhai68O08ElI=; b=AOyR+Zdi9oB4cOXWhOwR9TYuGS4zO450ueFRgikcx 1EiBJZJ3/eRlSLNnVMhn5ZcrTsvQ7etXqQYdXiXhJAXkIC+z3bvlPNG0M/cz56Kt FvQDuMvrzv14/KtCdxB9odKvB/K8zniG5n1QQpoZwpKfhIbRUlgNYGBn0tYDlfPh 4g= Received: (qmail 83924 invoked by alias); 23 May 2017 16:02:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 82668 invoked by uid 89); 23 May 2017 16:02:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=reserved X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 May 2017 16:02:19 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1dDCGK-00032C-18 from Thomas_Schwinge@mentor.com ; Tue, 23 May 2017 09:02:20 -0700 Received: from hertz.schwinge.homeip.net (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 23 May 2017 17:02:17 +0100 From: Thomas Schwinge To: Jakub Jelinek , Subject: Re: Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context" In-Reply-To: <20170523103618.GN8499@tucnak> References: <87d1cxfpvq.fsf@euler.schwinge.homeip.net> <20170523103618.GN8499@tucnak> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 23 May 2017 18:02:11 +0200 Message-ID: <87inkry324.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Hi! On Tue, 23 May 2017 12:36:18 +0200, Jakub Jelinek wrote: > On Fri, Mar 31, 2017 at 05:05:29PM +0200, Thomas Schwinge wrote: > > Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context" > Ok for trunk. Thanks. As posted, committed to trunk in r248372: commit 093c94dd910ff55efb5e1bb38cc8020ee488c1e9 Author: tschwinge Date: Tue May 23 16:00:56 2017 +0000 Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context" gcc/ * omp-low.c (struct omp_context): Remove "default_kind" member. Adjust all users. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@248372 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 3 +++ gcc/omp-low.c | 12 +----------- 2 files changed, 4 insertions(+), 11 deletions(-) Grüße Thomas diff --git gcc/ChangeLog gcc/ChangeLog index b38a31d..b626515 100644 --- gcc/ChangeLog +++ gcc/ChangeLog @@ -1,5 +1,8 @@ 2017-05-23 Thomas Schwinge + * omp-low.c (struct omp_context): Remove "default_kind" member. + Adjust all users. + * omp-offload.c (execute_oacc_device_lower): Remove the parallelism dimensions function attributes for unparallelized OpenACC kernels constructs. diff --git gcc/omp-low.c gcc/omp-low.c index 968075c..9a16248 100644 --- gcc/omp-low.c +++ gcc/omp-low.c @@ -112,10 +112,6 @@ struct omp_context otherwise. */ gimple *simt_stmt; - /* What to do with variables with implicitly determined sharing - attributes. */ - enum omp_clause_default_kind default_kind; - /* Nesting depth of this context. Used to beautify error messages re invalid gotos. The outermost ctx is depth 1, with depth 0 being reserved for the main body of the function. */ @@ -1162,10 +1158,6 @@ scan_sharing_clauses (tree clauses, omp_context *ctx, install_var_field (decl, by_ref, 3, ctx); break; - case OMP_CLAUSE_DEFAULT: - ctx->default_kind = OMP_CLAUSE_DEFAULT_KIND (c); - break; - case OMP_CLAUSE_FINAL: case OMP_CLAUSE_IF: case OMP_CLAUSE_NUM_THREADS: @@ -1332,6 +1324,7 @@ scan_sharing_clauses (tree clauses, omp_context *ctx, case OMP_CLAUSE_SEQ: case OMP_CLAUSE_TILE: case OMP_CLAUSE__SIMT_: + case OMP_CLAUSE_DEFAULT: break; case OMP_CLAUSE_ALIGNED: @@ -1826,7 +1819,6 @@ scan_omp_parallel (gimple_stmt_iterator *gsi, omp_context *outer_ctx) if (taskreg_nesting_level > 1) ctx->is_nested = true; ctx->field_map = splay_tree_new (splay_tree_compare_pointers, 0, 0); - ctx->default_kind = OMP_CLAUSE_DEFAULT_SHARED; ctx->record_type = lang_hooks.types.make_type (RECORD_TYPE); name = create_tmp_var_name (".omp_data_s"); name = build_decl (gimple_location (stmt), @@ -1875,7 +1867,6 @@ scan_omp_task (gimple_stmt_iterator *gsi, omp_context *outer_ctx) if (taskreg_nesting_level > 1) ctx->is_nested = true; ctx->field_map = splay_tree_new (splay_tree_compare_pointers, 0, 0); - ctx->default_kind = OMP_CLAUSE_DEFAULT_SHARED; ctx->record_type = lang_hooks.types.make_type (RECORD_TYPE); name = create_tmp_var_name (".omp_data_s"); name = build_decl (gimple_location (stmt), @@ -2390,7 +2381,6 @@ scan_omp_target (gomp_target *stmt, omp_context *outer_ctx) ctx = new_omp_context (stmt, outer_ctx); ctx->field_map = splay_tree_new (splay_tree_compare_pointers, 0, 0); - ctx->default_kind = OMP_CLAUSE_DEFAULT_SHARED; ctx->record_type = lang_hooks.types.make_type (RECORD_TYPE); name = create_tmp_var_name (".omp_data_t"); name = build_decl (gimple_location (stmt),