From patchwork Tue Jan 18 19:12:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 79342 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8BECFB708B for ; Wed, 19 Jan 2011 06:12:47 +1100 (EST) Received: (qmail 3618 invoked by alias); 18 Jan 2011 19:12:46 -0000 Received: (qmail 3603 invoked by uid 22791); 18 Jan 2011 19:12:45 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL, BAYES_40, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ka.mail.enyo.de (HELO ka.mail.enyo.de) (87.106.162.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Jan 2011 19:12:40 +0000 Received: from [172.17.135.4] (helo=deneb.enyo.de) by ka.mail.enyo.de with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1PfGyq-0004bw-TR; Tue, 18 Jan 2011 20:12:36 +0100 Received: from fw by deneb.enyo.de with local (Exim 4.72) (envelope-from ) id 1PfGyq-0008H7-L3; Tue, 18 Jan 2011 20:12:36 +0100 From: Florian Weimer To: gcc-patches@gcc.gnu.org Cc: bosch@gnat.com, dewar@gnat.com, charlet@act-europe.fr Subject: [Ada] Fix typo in style guide Date: Tue, 18 Jan 2011 20:12:36 +0100 Message-ID: <87hbd6do0r.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This almost qualifies as obvious. The style rule is currently self-contradictory, so it could mean either thing, but I've checked a few package specs, and the patch below seems to reflect the intended meaning. Okay for mainline? 2011-01-18 Florian Weimer * gnat-style.texi (Lexical Elements): Fix typo. Index: gnat-style.texi =================================================================== --- gnat-style.texi (revision 168958) +++ gnat-style.texi (working copy) @@ -299,7 +299,7 @@ Descriptions of what subprograms do go with the specification. @item -Comments describing a subprogram spec should specifically mention the +Comments describing a subprogram spec should not specifically mention the formal argument names. General rule: write a comment that does not depend on the names of things. The names are supplementary, not sufficient, as comments.