Message ID | 87a9sk4tkn.fsf@talisman.default |
---|---|
State | New |
Headers | show |
On Mon, 2013-01-07 at 20:38 +0000, Richard Sandiford wrote: > > Ah, sorry, this reminded me of a patch I'd written a year ago and never > got around to sanity-checking. Does it fix the problem for you? > > Richard It fixes my small test case, I will try it on the full testsuite overnight. Steve
On Mon, 2013-01-07 at 12:54 -0800, Steve Ellcey wrote: > On Mon, 2013-01-07 at 20:38 +0000, Richard Sandiford wrote: > > > > > Ah, sorry, this reminded me of a patch I'd written a year ago and never > > got around to sanity-checking. Does it fix the problem for you? > > > > Richard > > It fixes my small test case, I will try it on the full testsuite > overnight. > > Steve The full testsuite worked fine too, so I think this should be checked in. Given this fix I will probably leave the stab support alone for now, though I would have no objection if someone wanted to remove it for MIPS. Steve Ellcey sellcey@mips.com
Index: gas/config/tc-mips.c =================================================================== --- gas/config/tc-mips.c 2012-01-28 14:47:10.000000000 +0000 +++ gas/config/tc-mips.c 2012-01-28 14:48:14.000000000 +0000 @@ -1476,7 +1476,9 @@ static const pseudo_typeS mips_pseudo_ta {"section", s_change_section, 0}, {"short", s_cons, 1}, {"single", s_float_cons, 'f'}, + {"stabd", s_mips_stab, 'd'}, {"stabn", s_mips_stab, 'n'}, + {"stabs", s_mips_stab, 's'}, {"text", s_change_sec, 't'}, {"word", s_cons, 2}, @@ -16817,9 +16819,7 @@ s_insn (int ignore ATTRIBUTE_UNUSED) static void s_mips_stab (int type) { - if (type == 'n') - mips_mark_labels (); - + mips_mark_labels (); s_stab (type); }