| Message ID | 87CF59D4-EBCE-46CE-A1BE-746E4D5A3814@comcast.net |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite] indicate no "weak" support in pdp11 | expand |
On 11/19/18 3:18 PM, Paul Koning wrote: > This patch changes check_weak_available to report that pdp11 does not support "weak". A number of test case failures are caused by attempts to use weak support which is missing in the pdp11 flavor of a.out. > > I'm not sure if this is covered by target maintainer authority so I figure it's best to ask for approval. > > Ok for trunk? > > paul > > testsuite/ChangeLog: > > 2018-11-19 Paul Koning <ni1d@arrl.net> > > * lib/target-supports.exp (check_weak_available): Return "no" for > pdp11. Yes. And FWIW this kind of change falls into what maintainers can make and self-approve. jeff
> On Nov 19, 2018, at 5:20 PM, Jeff Law <law@redhat.com> wrote: > > On 11/19/18 3:18 PM, Paul Koning wrote: >> This patch changes check_weak_available to report that pdp11 does not support "weak". A number of test case failures are caused by attempts to use weak support which is missing in the pdp11 flavor of a.out. >> >> I'm not sure if this is covered by target maintainer authority so I figure it's best to ask for approval. >> >> Ok for trunk? >> >> paul >> >> testsuite/ChangeLog: >> >> 2018-11-19 Paul Koning <ni1d@arrl.net> >> >> * lib/target-supports.exp (check_weak_available): Return "no" for >> pdp11. > Yes. And FWIW this kind of change falls into what maintainers can make > and self-approve. > > jeff Thanks for the clarification. Committed. paul
Index: lib/target-supports.exp =================================================================== --- lib/target-supports.exp (revision 266288) +++ lib/target-supports.exp (working copy) @@ -314,6 +314,12 @@ proc check_weak_available { } { return 1 } + # pdp11 doesn't support it + + if { [istarget pdp11*-*-*] } { + return 0 + } + # ELF and ECOFF support it. a.out does with gas/gld but may also with # other linkers, so we should try it