From patchwork Fri Mar 13 09:06:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 449869 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8B7BD1400DE for ; Fri, 13 Mar 2015 20:07:21 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=wrDUOJLK; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=yLUhWT016QqDjlXx ZXZsN3yjnYU48VOTi7+RpVFRAWGcZkjehWwVOQrrVHWnNqNrqm9har90Pbou5QC3 goundb0zMqhJQRxFB4wi3ICJE+wU4ppKE+14vghkqCZDvgeH7Oh3fYVTa4hC6231 cDxCzn0+aEyUY/UbmSpGLBk3bFg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=hh6YEZP4Wc2mp0zZxEhNsw oagfY=; b=wrDUOJLKL+bcrawhpqBLuejFu9GFYhpGE5c9AxKWYXiTg9e+NsSNSY FxP8WzYL+Pass4OnkFEf89mKS2jskugLUe4SaS0MLl/R3/mgxKvLE158MGIXrz24 fF5AOS1ntRWbLmfRTzBUNodubggv4MW3APwepBvFlwFM+LRA33JNM= Received: (qmail 80689 invoked by alias); 13 Mar 2015 09:07:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 80669 invoked by uid 89); 13 Mar 2015 09:07:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Mar 2015 09:07:12 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YWLYi-000212-AR from Thomas_Schwinge@mentor.com ; Fri, 13 Mar 2015 02:07:08 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Fri, 13 Mar 2015 09:07:06 +0000 From: Thomas Schwinge To: GCC Patches CC: Bernd Schmidt , Jakub Jelinek Subject: Re: Option overriding in the offloading code path In-Reply-To: <87mw429tfn.fsf@kepler.schwinge.homeip.net> References: <5454CDF1.3070307@codesourcery.com> <87fvacld85.fsf@kepler.schwinge.homeip.net> <87a90klcyb.fsf@kepler.schwinge.homeip.net> <87mw429tfn.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Fri, 13 Mar 2015 10:06:57 +0100 Message-ID: <8761a55kr2.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Wed, 25 Feb 2015 11:28:12 +0100, I wrote: > Using [...] to forcefully disable -fvar-tracking (as done in > nvptx_option_override), should then allow me to drop the following > beautiful specimen of a patch (which I didn't commit anywhere, so far): No progress yet with that, so for now, committed to gomp-4_0-branch in r221411: commit 2b54430cec7ac5b51ee3cbb568bd505d86bf0768 Author: tschwinge Date: Fri Mar 13 09:03:21 2015 +0000 libgomp Fortran testing: for -g torture testing, disable variable tracking. Otherwise, the nvptx-none offloading compiler will run into issues such as: source-gcc/libgomp/testsuite/libgomp.fortran/examples-4/e.50.1.f90: In function '__e_50_1_mod_MOD_vec_mult._omp_fn.1': source-gcc/libgomp/testsuite/libgomp.fortran/examples-4/e.50.1.f90:31:0: internal compiler error: in use_type, at var-tracking.c:5442 p(i) = v1(i) * v2(i) ^ 0xc4dc72 use_type source-gcc/gcc/var-tracking.c:5442 0xc504b3 add_stores source-gcc/gcc/var-tracking.c:5869 0xc4cd28 add_with_sets source-gcc/gcc/var-tracking.c:6553 0x5e9b7d cselib_record_sets source-gcc/gcc/cselib.c:2574 0x5ea8a7 cselib_process_insn(rtx_insn*) source-gcc/gcc/cselib.c:2686 0xc586a3 vt_initialize source-gcc/gcc/var-tracking.c:10126 0xc65a8e variable_tracking_main_1 source-gcc/gcc/var-tracking.c:10322 0xc65a8e variable_tracking_main source-gcc/gcc/var-tracking.c:10375 0xc65a8e execute source-gcc/gcc/var-tracking.c:10412 Please submit a full bug report, with preprocessed source if appropriate. Please include the complete backtrace with any bug report. See for instructions. mkoffload: fatal error: install/offload-nvptx-none/bin//x86_64-unknown-linux-gnu-accel-nvptx-none-gcc returned 1 exit status libgomp/ * testsuite/libgomp.fortran/fortran.exp (DG_TORTURE_OPTIONS): Add -fno-var-tracking next to any -g usage. * testsuite/libgomp.oacc-fortran/fortran.exp (DG_TORTURE_OPTIONS): Likewise. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@221411 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 7 +++++++ libgomp/testsuite/libgomp.fortran/fortran.exp | 4 ++++ libgomp/testsuite/libgomp.oacc-fortran/fortran.exp | 4 ++++ 3 files changed, 15 insertions(+) Grüße, Thomas diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index c2566cf..f052d3e 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,3 +1,10 @@ +2015-03-13 Thomas Schwinge + + * testsuite/libgomp.fortran/fortran.exp (DG_TORTURE_OPTIONS): Add + -fno-var-tracking next to any -g usage. + * testsuite/libgomp.oacc-fortran/fortran.exp (DG_TORTURE_OPTIONS): + Likewise. + 2015-01-12 Thomas Schwinge * plugin/plugin-host.c [HOST_NONSHM_PLUGIN]: Don't include "libgomp.h". diff --git libgomp/testsuite/libgomp.fortran/fortran.exp libgomp/testsuite/libgomp.fortran/fortran.exp index 9e6b643..ead94f3 100644 --- libgomp/testsuite/libgomp.fortran/fortran.exp +++ libgomp/testsuite/libgomp.fortran/fortran.exp @@ -21,6 +21,10 @@ dg-init # Turn on OpenMP. lappend ALWAYS_CFLAGS "additional_flags=-fopenmp" +# TODO: for -g torture testing, disable variable tracking. +# . +regsub -all -- { -g[^ ]*} $DG_TORTURE_OPTIONS {& -fno-var-tracking} DG_TORTURE_OPTIONS + if { $blddir != "" } { set lang_source_re {^.*\.[fF](|90|95|03|08)$} set lang_include_flags "-fintrinsic-modules-path=${blddir}" diff --git libgomp/testsuite/libgomp.oacc-fortran/fortran.exp libgomp/testsuite/libgomp.oacc-fortran/fortran.exp index a68e039..203106e 100644 --- libgomp/testsuite/libgomp.oacc-fortran/fortran.exp +++ libgomp/testsuite/libgomp.oacc-fortran/fortran.exp @@ -23,6 +23,10 @@ dg-init # Turn on OpenACC. lappend ALWAYS_CFLAGS "additional_flags=-fopenacc" +# TODO: for -g torture testing, disable variable tracking. +# . +regsub -all -- { -g[^ ]*} $DG_TORTURE_OPTIONS {& -fno-var-tracking} DG_TORTURE_OPTIONS + if { $blddir != "" } { set lang_source_re {^.*\.[fF](|90|95|03|08)$} set lang_include_flags "-fintrinsic-modules-path=${blddir}"