From patchwork Wed Jul 5 08:16:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 1803480 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qwsv22bnMz20ZC for ; Wed, 5 Jul 2023 18:16:30 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 554443857354 for ; Wed, 5 Jul 2023 08:16:28 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 5BF8E3858CD1 for ; Wed, 5 Jul 2023 08:16:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BF8E3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.01,182,1684828800"; d="scan'208,223";a="10953041" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 05 Jul 2023 00:16:15 -0800 IronPort-SDR: oki5ONRV/yLP2q+3C1FmVrzGL/OEzJEff62xJ6zScSFM4OD3enHGad8pGSBjkXWlwn4agBZBhk mNaU31j3zcBjDKW5XNNHI9wR1+dafxSHqbPF/pqCePzwBWVvWvjpYB/cLNyUTohCVpDANSh2iO J3hwAqNAUdAwoa5etp7sVzBVgmqonH47NGeLMX6/nEMsodtnQoYli6fnpM7vN7XCJ0ULH+AQWR dJ1wrrr4p76KGDtVLGSG51k50/oRylULd+9UiUTpZQPqjp4dw9tUyzym4m1jW0cCSsHIBOlQ7Y AZg= From: Thomas Schwinge To: Subject: GTY: Clean up obsolete parametrized structs remnants (was: [PATCH 3/3] remove gengtype support for param_is use_param, if_marked and splay tree allocators) In-Reply-To: <1416802296-15833-4-git-send-email-tsaunders@mozilla.com> References: <1416802296-15833-1-git-send-email-tsaunders@mozilla.com> <1416802296-15833-4-git-send-email-tsaunders@mozilla.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Wed, 5 Jul 2023 10:16:09 +0200 Message-ID: <873522vkmu.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi! On 2014-11-23T23:11:36-0500, tsaunders@mozilla.com wrote: > gcc/ > > * plugin.c, plugin.def, ggc.h, ggc-common.c, gengtype.h, gengtype.c, > gengtype-state.c, gengtype-parse.c, gentype-lex.l, gcc-plugin.h, > doc/plugins.texi, doc/gty.texi: Remove support for if_marked and > param_is. > --- a/gcc/gengtype.h > +++ b/gcc/gengtype.h > @@ -153,11 +152,6 @@ enum typekind { > TYPE_LANG_STRUCT, /* GCC front-end language specific structs. > Various languages may have homonymous but > different structs. */ > - TYPE_PARAM_STRUCT, /* Type for parametrized structs, e.g. hash_t > - hash-tables, ... See (param_is, use_param, > - param1_is, param2_is,... use_param1, > - use_param_2,... use_params) GTY > - options. */ > TYPE_USER_STRUCT /* User defined type. Walkers and markers for > this type are assumed to be provided by the > user. */ OK to push the attached "GTY: Clean up obsolete parametrized structs remnants"? Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 From 100039989c2bca5d98cb76a1bc3ef5b40bfc27ce Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 4 Jul 2023 22:47:48 +0200 Subject: [PATCH] GTY: Clean up obsolete parametrized structs remnants Support removed in 2014 with commit 63f5d5b818319129217e41bcb23db53f99ff11b0 (Subversion r218558) "remove gengtype support for param_is use_param, if_marked and splay tree allocators". gcc/ * gengtype-parse.cc: Clean up obsolete parametrized structs remnants. * gengtype.cc: Likewise. --- gcc/gengtype-parse.cc | 1 - gcc/gengtype.cc | 6 ++---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/gcc/gengtype-parse.cc b/gcc/gengtype-parse.cc index 2b2156c5f45..efee4171674 100644 --- a/gcc/gengtype-parse.cc +++ b/gcc/gengtype-parse.cc @@ -80,7 +80,6 @@ static const char *const token_names[] = { "...", "ptr_alias", "nested_ptr", - "a param_is option", "a number", "a scalar type", "an identifier", diff --git a/gcc/gengtype.cc b/gcc/gengtype.cc index 54d3c8aaec3..49ddba684af 100644 --- a/gcc/gengtype.cc +++ b/gcc/gengtype.cc @@ -1388,8 +1388,6 @@ adjust_field_rtx_def (type_p t, options_p ARG_UNUSED (opt)) At present: - Converts pointer-to-char, with no length parameter, to TYPE_STRING; - Similarly for arrays of pointer-to-char; - - Converts structures for which a parameter is provided to - TYPE_PARAM_STRUCT; - Handles "special" options. */ @@ -3654,7 +3652,7 @@ write_func_for_structure (type_p orig_s, type_p s, } -/* Write out marker routines for STRUCTURES and PARAM_STRUCTS. */ +/* Write out marker routines for STRUCTURES. */ static void write_types (outf_p output_header, type_p structures, @@ -4002,7 +4000,7 @@ write_local_func_for_structure (const_type_p orig_s, type_p s) } } -/* Write out local marker routines for STRUCTURES and PARAM_STRUCTS. */ +/* Write out local marker routines for STRUCTURES. */ static void write_local (outf_p output_header, type_p structures) -- 2.34.1