From patchwork Fri Jan 2 10:54:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Zaretskii X-Patchwork-Id: 424978 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2C5CC14009B for ; Fri, 2 Jan 2015 21:55:08 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:subject:to:reply-to:message-id; q=dns; s=default; b=Et5Cla ZxixqyD/fFKwJEbXmxtrCdBXf80s5fWjgg+wuiw25mWjtFnbmUdNxnEJAUJ+RBDD RaIIOQ5M1c9N49pUvEna04VybSsatvFS+sXVSC0ZJ5OVuvz6b7kph1IqeRQHUmn8 jqD74dVRV8IxbriWkUea9HoqRByupABw2ZRPw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:subject:to:reply-to:message-id; s=default; bh=4/6+GhtA8Fcn teYOwjXRTgZS+iQ=; b=hiXb+NlcxMVZwXOAabDmgBkdnacRjlLqH58xVnbdWc+h j6SApzjLD1DyCoG4F2zF9Vz3ZD2W1S9ryw72fLFXMYosqi3376GWwpqDsXuqagOq 8NI1mcsnuyhHRd07A9q6fNVsN8GZZoGuG4IM5uzmiFfEX2JXNsw2KhrMjDCsfbQ= Received: (qmail 6081 invoked by alias); 2 Jan 2015 10:54:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6060 invoked by uid 89); 2 Jan 2015 10:54:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, HDRS_LCASE, SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout29.012.net.il Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jan 2015 10:54:52 +0000 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NHJ00000PZHOQ00@mtaout29.012.net.il> for gcc-patches@gcc.gnu.org; Fri, 02 Jan 2015 12:51:55 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHJ0004HQ6JO910@mtaout29.012.net.il>; Fri, 02 Jan 2015 12:51:55 +0200 (IST) Date: Fri, 02 Jan 2015 12:54:47 +0200 From: Eli Zaretskii Subject: Fix a MinGW warning in libiberty/strerror.c To: gdb-patches@sourceware.org, dj@redhat.com, gcc-patches@gcc.gnu.org Reply-to: Eli Zaretskii Message-id: <831tndbgg8.fsf@gnu.org> When compiling GDB 7.8.1, I get this warning in libiberty: gcc -c -DHAVE_CONFIG_H -O0 -g3 -D__USE_MINGW_ACCESS -I. -I./../include -W -Wall -Wwrite-strings -Wc++-compat -Wstrict-prototypes -pedantic ./strerror.c -o strerror.o ./strerror.c:472:12: warning: '_sys_nerr' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] ./strerror.c:473:14: warning: '_sys_errlist' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] This happens because the MinGW system headers have some special magic for these variables, which are imported from a system shared library. The solution I propose is to refrain from declaring variables that are actually macros, because this should be a sign that something tricky is going on: OK to commit this (with a suitable ChangeLog entry)? --- libiberty/strerror.c~0 2014-06-11 18:34:41 +0300 +++ libiberty/strerror.c 2014-12-30 08:12:00 +0200 @@ -469,8 +469,13 @@ #else + +#ifndef sys_nerr extern int sys_nerr; +#endif +#ifndef sys_errlist extern char *sys_errlist[]; +#endif #endif