| Message ID | 8266b5be-256c-4be2-84db-3a880e849d41@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | PR 107189 Remove useless _Alloc_node | expand |
Gentle reminder. Sorry if I should have committed it as trivial but I cannot do it anymore now that I asked :-) On 12/10/22 22:18, François Dumont wrote: > libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189] > > libstdc++-v3/ChangeLog: > > PR libstdc++/107189 > * include/bits/stl_tree.h > (_Rb_tree<>::_M_insert_range_equal): Remove > unused _Alloc_node instance. > > Ok to commit ? > > François
Still no chance to review ? On 14/11/22 18:56, François Dumont wrote: > Gentle reminder. > > Sorry if I should have committed it as trivial but I cannot do it > anymore now that I asked :-) > > > On 12/10/22 22:18, François Dumont wrote: >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189] >> >> libstdc++-v3/ChangeLog: >> >> PR libstdc++/107189 >> * include/bits/stl_tree.h >> (_Rb_tree<>::_M_insert_range_equal): Remove >> unused _Alloc_node instance. >> >> Ok to commit ? >> >> François > >
OK for trunk, sorry for not getting to it sooner. On Wed, 4 Jan 2023 at 21:13, François Dumont via Libstdc++ <libstdc++@gcc.gnu.org> wrote: > > Still no chance to review ? > > On 14/11/22 18:56, François Dumont wrote: > > Gentle reminder. > > > > Sorry if I should have committed it as trivial but I cannot do it > > anymore now that I asked :-) > > > > > > On 12/10/22 22:18, François Dumont wrote: > >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189] > >> > >> libstdc++-v3/ChangeLog: > >> > >> PR libstdc++/107189 > >> * include/bits/stl_tree.h > >> (_Rb_tree<>::_M_insert_range_equal): Remove > >> unused _Alloc_node instance. > >> > >> Ok to commit ? > >> > >> François > > > >
On Thu, 12 Jan 2023 at 12:01, Jonathan Wakely wrote: > > OK for trunk, sorry for not getting to it sooner. P.S. I do think this one would have been OK to commit as obvious, since it's just removing an unused variable and so has no effect on anything. > > On Wed, 4 Jan 2023 at 21:13, François Dumont via Libstdc++ > <libstdc++@gcc.gnu.org> wrote: > > > > Still no chance to review ? > > > > On 14/11/22 18:56, François Dumont wrote: > > > Gentle reminder. > > > > > > Sorry if I should have committed it as trivial but I cannot do it > > > anymore now that I asked :-) > > > > > > > > > On 12/10/22 22:18, François Dumont wrote: > > >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189] > > >> > > >> libstdc++-v3/ChangeLog: > > >> > > >> PR libstdc++/107189 > > >> * include/bits/stl_tree.h > > >> (_Rb_tree<>::_M_insert_range_equal): Remove > > >> unused _Alloc_node instance. > > >> > > >> Ok to commit ? > > >> > > >> François > > > > > >
diff --git a/libstdc++-v3/include/bits/stl_tree.h b/libstdc++-v3/include/bits/stl_tree.h index a4de6141765..33d25089a1d 100644 --- a/libstdc++-v3/include/bits/stl_tree.h +++ b/libstdc++-v3/include/bits/stl_tree.h @@ -1123,7 +1123,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __enable_if_t<!__same_value_type<_InputIterator>::value> _M_insert_range_equal(_InputIterator __first, _InputIterator __last) { - _Alloc_node __an(*this); for (; __first != __last; ++__first) _M_emplace_equal(*__first); }