From patchwork Sat Jun 18 15:11:43 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 100926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 20FA0B6FE0 for ; Sun, 19 Jun 2011 01:12:27 +1000 (EST) Received: (qmail 28634 invoked by alias); 18 Jun 2011 15:12:24 -0000 Received: (qmail 28620 invoked by uid 22791); 18 Jun 2011 15:12:23 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RFC_ABUSE_POST, TW_GC, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta11.westchester.pa.mail.comcast.net (HELO QMTA11.westchester.pa.mail.comcast.net) (76.96.59.211) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Jun 2011 15:12:09 +0000 Received: from omta17.westchester.pa.mail.comcast.net ([76.96.62.89]) by QMTA11.westchester.pa.mail.comcast.net with comcast id xSyl1g0091vXlb85BTC9br; Sat, 18 Jun 2011 15:12:09 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta17.westchester.pa.mail.comcast.net with comcast id xTBk1g01h0BKwT43dTBoN1; Sat, 18 Jun 2011 15:11:58 +0000 Subject: Re: [PATCH][Revised] Pass -no_pie on SYSTEMSPEC for darwin11 Mime-Version: 1.0 (Apple Message framework v1084) From: Mike Stump In-Reply-To: <20110618024913.GA29537@bromo.med.uc.edu> Date: Sat, 18 Jun 2011 08:11:43 -0700 Cc: gcc-patches@gcc.gnu.org, iains@gcc.gnu.org Message-Id: <8035A572-9078-46F4-9172-8CB269E1E854@comcast.net> References: <20110618024913.GA29537@bromo.med.uc.edu> To: Jack Howarth X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Jun 17, 2011, at 7:49 PM, Jack Howarth wrote: > The gcj compiler needs to pass -no_pie for linkage on darwin11 due to the new -pie > default of the linker. The attached patch accomplishes this by passing -no_pie on SYSTEMSPEC > for *-*-darwin[12]*. Since Darwin10 supports -no_pie in its linker, I included it in the > triplet match to simplify the syntax. Bootstrap and tested on x86_64-apple-darwin11. > Okay for gcc trunk with PR added to comment as requested? > Jack > ps This change also works for gcc-4_6-branch in concert with a backport of > r175089 and r175108. > > 2011-06-17 Jack Howarth > > PR target/49461 > * libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11. > * libjava/configure: Regenerate. Checked in r175182, with one additional comment. We still welcome tracking down what exactly doesn't work and a bug report and fix for that, until then, I think life is too short to have java be broken for too long. 2011-06-17 Jack Howarth PR target/49461 * libjava/configure.ac (SYSTEMSPEC): Pass -no_pie for darwin11. * libjava/configure: Regenerate. Index: configure.ac =================================================================== --- configure.ac (revision 175181) +++ configure.ac (revision 175182) @@ -898,9 +898,14 @@ case "${host}" in SYSTEMSPEC="-lunicows $SYSTEMSPEC" fi ;; - *-*-darwin[[912]]*) + *-*-darwin9*) SYSTEMSPEC="%{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" ;; + *-*-darwin[[12]]*) + # Something is incompatible with pie, would be nice to fix it and + # remove -no_pie. PR49461 + SYSTEMSPEC="-no_pie %{!Zdynamiclib:%{!Zbundle:-allow_stack_execute}}" + ;; *) SYSTEMSPEC= ;;