From patchwork Fri Nov 20 22:15:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 547064 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 13D721402D6 for ; Sat, 21 Nov 2015 09:17:26 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=b4tR7xMR; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=jX4C5L21Dmq2/F9iHsSaB2ElZQNfAztBRNwwZ6dv7VcMdzsGhNNMM gS96u3S+Zg5pgyJPPUdA3Vf3pwMaQyn8KXpYVRDD9krUDR+jqeVsWL26ENig8qIt OShpb7/I7FTd8lCJjO8IrRYLETyhHDfUg+A4hhDX9Pd3D/QfRvO5qU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=MhQ1rkg0vkt8GjirGxSIsJ5WKyg=; b=b4tR7xMRe/TYsOe53VGLvFokOEn6 RzVVXL51289yPBReYO5eBi1V9SlZmHIylh0w3GOh5qdKnXlqMYuRkSbCBIBt9DTp S/PMr+tQj+nSaSSax3KlrbvK4yI/S92i2ItCYP9N2YbooeIRjQsxUMTeb9dvvxMe pNlU77l40FYheQE= Received: (qmail 32193 invoked by alias); 20 Nov 2015 22:17:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32168 invoked by uid 89); 20 Nov 2015 22:17:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: resqmta-po-10v.sys.comcast.net Received: from resqmta-po-10v.sys.comcast.net (HELO resqmta-po-10v.sys.comcast.net) (96.114.154.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 20 Nov 2015 22:17:16 +0000 Received: from resomta-po-20v.sys.comcast.net ([96.114.154.244]) by resqmta-po-10v.sys.comcast.net with comcast id jyFx1r0015Geu2801yHEms; Fri, 20 Nov 2015 22:17:14 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-20v.sys.comcast.net with comcast id jyHC1r00X2ztT3H01yHDgA; Fri, 20 Nov 2015 22:17:14 +0000 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] g++.dg/init/vbase1.C and g++.dg/cpp/ucn-1.C From: Mike Stump In-Reply-To: <5649E1E0.60303@arm.com> Date: Fri, 20 Nov 2015 14:15:28 -0800 Cc: David Edelsohn , GCC Patches , Ramana Radhakrishnan Message-Id: <7FDDFA0F-C795-4E4B-9488-B4772097C40B@comcast.net> References: <5649E1E0.60303@arm.com> To: Renlin Li X-IsSubscribed: yes On Nov 16, 2015, at 6:02 AM, Renlin Li wrote: > On 14/11/15 00:33, David Edelsohn wrote: >> No RISC architecture can store directly to MEM, so the expected RTL in >> g++.dg/init/vbase1.C is wrong. I am adding XFAIL for PowerPC. This >> probably should be disabled for ARM and other RISC architectures. > > I observed the same problem in arm. > > This passes for aarch64 and mips as they have zero register to do that. However, other RISC might not have that feature, for example arm and RS6000 in this case. I fixed this with the below patch. Tested on x86_64 linux, x86_64 darwin and my port. If you want to list aarch64/arn and mips, please do. * g++.dg/init/vbase1.C: Only run on x86_64-*-* as this testcase isn't portable. Index: g++.dg/init/vbase1.C =================================================================== --- g++.dg/init/vbase1.C (revision 230675) +++ g++.dg/init/vbase1.C (working copy) @@ -42,4 +42,4 @@ int main(int, char**) // Verify that the SubB() mem-initializer is storing 0 directly into // this->D.whatever rather than into a stack temp that is then copied into the // base field. -// { dg-final { scan-rtl-dump "set \[^\n\]*\n\[^\n\]*this\[^\n\]*\n\[^\n\]*const_int 0" "expand" { xfail { powerpc*-*-* } } } } +// { dg-final { scan-rtl-dump "set \[^\n\]*\n\[^\n\]*this\[^\n\]*\n\[^\n\]*const_int 0" "expand" { target { x86_64-*-* } } } }