From patchwork Tue Mar 26 14:45:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takayuki 'January June' Suwa X-Patchwork-Id: 1916210 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=yahoo.co.jp header.i=@yahoo.co.jp header.a=rsa-sha256 header.s=yj20110701 header.b=anaWDNmr; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V3t150wbtz1yWv for ; Wed, 27 Mar 2024 01:46:49 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F98A385843A for ; Tue, 26 Mar 2024 14:46:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from omggw7006-vm1.mail.djm.yahoo.co.jp (omggw7006-vm1.mail.djm.yahoo.co.jp [183.79.54.120]) by sourceware.org (Postfix) with ESMTPS id B2D533858C36 for ; Tue, 26 Mar 2024 14:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2D533858C36 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=yahoo.co.jp Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.co.jp ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2D533858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=183.79.54.120 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711464384; cv=none; b=rs3lvzqa3DR7/aRpPIJAvjlJxt0GY5102RvHqfqXFDj1NSuFZSHZSNEritKwcaxESGoFIaoPp9D8UuIQfM1ta8I6M7oKjqWalheJSklQlwXjuzF6Lo8/Xmfds0qyrZBvJwTQaGVzjnTDn/oJtB6yW/FHU98Iq80lc+lY2uIvMtM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711464384; c=relaxed/simple; bh=LdaECv6TCCruiMeFKCNZmlYQFAhjjldABrqyk+q9vu4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=uA9fE/5pDLDApIEzNit4XuPvxEIKbpgcqnwAbBotxF3HHcb7kGCQt89VKw+XQbugrmcsKUU2kJnJEb9gdz+r8SZOI4MCQE6J9NOq9vR5pSe+ZalADZq3Oif1nI8oeOYa37YZxQQBvY/Xl39IoalxPbybBsDKH4yMp8VZmP6nMco= ARC-Authentication-Results: i=1; server2.sourceware.org X-YMail-OSG: 98R7hmQVM1kvNZVGq9CXlFIZDJXsRe2hbKEQV31NcvaueanN5aw3P7cD5Yd_32m zx4znRas2DS5pBLAtnIVdvvcFbUvQlhM1iQrWxOW8f3yWrDDALmdH58Xwgz5eZK4fA6sNZlA0fPC 2_Dv.6BeOToVFSr69QJyBrl8vErMBHcOF8Y3Dnt.fJX2_27D_Ak3rcfDKDSYnCO98XOauIRAC_bO .zH8WwWjlhmTqIFOGbRWtB20dKIBrIuoy5h0bThpxGXbDCsQs37xRIKA5d7JGbgPsMdYh9Dia4SX KbLTLTQQsm2RBem1R4XiToUEsgUUpjQPtrtK5EwRI5RkoDYrTfECU2oKCM_xBrork5PXa06eq8Wz r2CtKOF47b.A.ABgUGBo7tAMBH_2YkILI3U1P8lg1WT.B5fgelmAk6FiTzbvXyNB_Tc9UDAWX_hU kdJwc.faFDpR6dHEBX2I9wOw0NBhsESN5h.DdizTDlUbrsMmGry_ZGBTm138XTs62RDzJ.lU0Wxi aATPutuBUvgESRGjovMSkHKfx90tyhmlFzvftAb0mmTF47y1jpdPKsHSSKptyTdQv3Bl9CQiZJPW SVw6bayUbnEkiSkMHO2763pWuIDsIKcF_AT6bwnLuqSL0ZgSN_vunu_h8ZJgy9Ht6QSjwJ1DfCeS ZVxoCvHpRbfgBD_ntkGaZgTKAqvN0CkOsDNSNcAuR6afRNoQLizKZohADorbxwfbTEqK1epcRsKn 8P8Vqr86vOodZEDaoZGMrX1jkmKCaka0JIjOAdpKAnhocXZTSZ3LrWaBkvn4O1cI9vcUaNtkXObh wjy48ikeZvDC_L2qabkDuKcDPNHGF7HdC2m1TRa6_lWb6bSSVMr8Tyd9LGjEcznRVA6mSB0wyrSC FTlTOZdVh.BSHe7JQ9FczG8WplgslZgODHvxnG.4dDzg4l_oEozcKSltpglqm2C0FsKdMJU3yHFJ oKgm2OgSEX_hSq2NXODIsMy1eQ9d33nwtHHmJrBgNTBQ0R4.S_NfuANP_X.pDKfrXCCnqcpxACfL Utm7I7Sglx.un.AoL7oE2k5sSnC6uXqw_kXOaQ1jfj1zYaGZz_Os82.OtLErfCa7Awbcd.l8Wav_ 36ysT7zyn8XNVux_k7Xw- Received: from sonicgw.mail.yahoo.co.jp by sonicconh5002.mail.kks.yahoo.co.jp with HTTP; Tue, 26 Mar 2024 14:46:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1711464335; s=yj20110701; d=yahoo.co.jp; h=References:Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To:MIME-Version:Date:Message-ID; bh=8O3BWi36yRGtLvB0FQHul8VkJYfnLVtWn4AJubhss0U=; b=anaWDNmrzMljwUxP7qi48l8izwdyRvk9y6auWQlXDZ0YOCnrPmMgk7kAI2xk1bku Vi2DkzICDPbG7z1mAOJ8EQMh9uPJksOxobWEPpf0RAow3odVvPQeOtWiQRSm1PSuPla s9WNnUvEY5Jq2sY+2gYB0EnHYyA9xRfk2FU5NNQo= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=yj20110701; d=yahoo.co.jp; h=Message-ID:Date:MIME-Version:Cc:From:Content-Type:Content-Transfer-Encoding:References; b=ZHAT99pT6vHC4yyg5BtXg0aFMo+6RWfdQ6a675SZodtMjkcTaoyVDk0ZGTGMK6EV /zV/52wqWfSNcLYDiyOGPDNzgynG7gIYK/Yfz0H6OGBYAGICIvG8D8MxWIxEre9S5GA oNgvW+hJXRAhYnUF6zadaAphbgSc8cH1QlZ+zBAk=; Received: by smtphe5007.mail.kks.ynwp.yahoo.co.jp (YJ Hermes SMTP Server) with ESMTPA ID 0a0248039892f8f7a2a485836dbd0a45; Tue, 26 Mar 2024 23:46:16 +0900 (JST) Message-ID: <76d21669-e23e-45a4-a5cc-dd08ecd71ad5@yahoo.co.jp> Date: Tue, 26 Mar 2024 23:45:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: GCC Patches Cc: Max Filippov From: Takayuki 'January June' Suwa Subject: [PATCH 2/2] xtensa: Make use of std::swap where appropriate References: <76d21669-e23e-45a4-a5cc-dd08ecd71ad5.ref@yahoo.co.jp> X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org No functional changes. gcc/ChangeLog: * config/xtensa/xtensa.cc (gen_int_relational, gen_float_relational): Replace tempvar-based value-swapping codes with std::swap. * config/xtensa/xtensa.md (movdi_internal, movdf_internal): Ditto. --- gcc/config/xtensa/xtensa.cc | 12 ++---------- gcc/config/xtensa/xtensa.md | 10 ++++------ 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc index df888294556..38c6966cc31 100644 --- a/gcc/config/xtensa/xtensa.cc +++ b/gcc/config/xtensa/xtensa.cc @@ -799,11 +799,7 @@ gen_int_relational (enum rtx_code test_code, /* relational test (EQ, etc) */ } else if (p_info->reverse_regs) - { - rtx temp = cmp0; - cmp0 = cmp1; - cmp1 = temp; - } + std::swap (cmp0, cmp1); return gen_rtx_fmt_ee (invert ? reverse_condition (p_info->test_code) : p_info->test_code, @@ -847,11 +843,7 @@ gen_float_relational (enum rtx_code test_code, /* relational test (EQ, etc) */ } if (reverse_regs) - { - rtx temp = cmp0; - cmp0 = cmp1; - cmp1 = temp; - } + std::swap (cmp0, cmp1); brtmp = gen_rtx_REG (CCmode, FPCC_REGNUM); emit_insn (gen_fn (brtmp, cmp0, cmp1)); diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index fbe40ec671a..93c3ee78a01 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -1253,9 +1253,8 @@ xtensa_split_operand_pair (operands, SImode); if (reg_overlap_mentioned_p (operands[0], operands[3])) { - rtx tmp; - tmp = operands[0], operands[0] = operands[1], operands[1] = tmp; - tmp = operands[2], operands[2] = operands[3], operands[3] = tmp; + std::swap (operands[0], operands[1]); + std::swap (operands[2], operands[3]); } }) @@ -1588,9 +1587,8 @@ xtensa_split_operand_pair (operands, SFmode); if (reg_overlap_mentioned_p (operands[0], operands[3])) { - rtx tmp; - tmp = operands[0], operands[0] = operands[1], operands[1] = tmp; - tmp = operands[2], operands[2] = operands[3], operands[3] = tmp; + std::swap (operands[0], operands[1]); + std::swap (operands[2], operands[3]); } })