From patchwork Thu Aug 11 22:27:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Schmidt X-Patchwork-Id: 658381 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3s9N2T6Y1hz9sR8 for ; Fri, 12 Aug 2016 08:28:16 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=byzCjRoe; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:date:mime-version:content-type :content-transfer-encoding:message-id; q=dns; s=default; b=V9/Fq 1oMxu04HGk3+Khy+RpfCEo1URtoBBkBO3S2+W+5/TfKNdC29kgE+RANZ5fFvYHp2 3MVePFDpHoeAowuQTL44mS0sr/I0+/UxkbkAQUehTK7rQyGbsbOTiIVD3mI/S5Z7 bEmj+kI8HbmM7VMWMuiBFWOi3tgfXkAeFV+T3g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:date:mime-version:content-type :content-transfer-encoding:message-id; s=default; bh=KWf/cCp8ujn 6I1fOn4kpBCUQvaU=; b=byzCjRoekTODTIuJMauvuiKB67EK6TQ2VVaKk9L8CgO J05W/r0HI/gWgnOg5UvSnxJI7UU8jtTs/38hG4FyW43EzLN3nSQNV/f3t+Gvxp9L bqxYKJVB/JnBBCxqT7qObLOFwPQWph4nbp6+KxARu1/5ealvmGTlzXhxQKKh3lVY = Received: (qmail 42453 invoked by alias); 11 Aug 2016 22:28:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 42443 invoked by uid 89); 11 Aug 2016 22:28:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=H*u:Mac, H*UA:Mac, H*UA:Intel, H*u:Intel X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Aug 2016 22:27:58 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7BMQG1p116144 for ; Thu, 11 Aug 2016 18:27:57 -0400 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0a-001b2d01.pphosted.com with ESMTP id 24qm9ux22h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 11 Aug 2016 18:27:56 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Aug 2016 16:27:56 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 11 Aug 2016 16:27:50 -0600 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: wschmidt@linux.vnet.ibm.com Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id D79BE3E40030; Thu, 11 Aug 2016 16:27:49 -0600 (MDT) Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7BMRmtj26935296; Thu, 11 Aug 2016 15:27:49 -0700 Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B800B13603C; Thu, 11 Aug 2016 16:27:49 -0600 (MDT) Received: from BigMac.local (unknown [9.80.219.166]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP id 5772E13603A; Thu, 11 Aug 2016 16:27:49 -0600 (MDT) To: GCC Patches Cc: richard.guenther@gmail.com From: Bill Schmidt Subject: [PATCH, preapproved] Disable DF_VERIFY_SCHEDULED at end of df_verify (PR72855) Date: Thu, 11 Aug 2016 17:27:48 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081122-0028-0000-0000-0000055B172C X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005579; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00743365; UDB=6.00350032; IPR=6.00515913; BA=6.00004658; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012317; XFM=3.00000011; UTC=2016-08-11 22:27:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081122-0029-0000-0000-00002E4C936C Message-Id: <76390506-8382-dc04-aee2-cefb27af44da@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-11_14:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608110286 X-IsSubscribed: yes Hi, PR72855 reports a compile-time problem with df_verify being called once per loop. The compile time drops from about 2 hours to 9 minutes for the reported test case when we disable the DF_VERIFY_SCHEDULED flag after df_verify runs. That's all this patch does. Bin Cheng has a separate patch to factor some code in loop-doloop.c that will also provide benefit. There is a separate issue that this compile-time problem should not occur at all with release checking, and yet it is. That is still under investigation. Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no regressions. Preapproved, committed. Thanks, Bill 2016-08-11 Richard Biener Bill Schmidt PR rtl-optimization/72855 * df-core.c (df_verify): Turn off DF_VERIFY_SCHEDULED at end. Index: gcc/df-core.c =================================================================== --- gcc/df-core.c (revision 239394) +++ gcc/df-core.c (working copy) @@ -1833,6 +1833,7 @@ df_verify (void) if (df_live) df_live_verify_transfer_functions (); #endif + df->changeable_flags &= ~DF_VERIFY_SCHEDULED; } #ifdef DF_DEBUG_CFG