From patchwork Sun Nov 19 00:09:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 839273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-467308-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="cu1R8n30"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yfXL44w95z9s3w for ; Sun, 19 Nov 2017 11:10:10 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:cc:message-id:date:mime-version:content-type; q= dns; s=default; b=RxRHC2epcFFfpl4mZPpGYjFe5cHdQvYQafh7nqQJKC/irb wXQXoX1BunwxkBmAGVqWV5F9nVAdG3VP06fa0+FoA905jsv/nNnozFywSRWYzLKV 4tcTUJpIO0QRSOSzP2h4vy5ZGP7i1FI2kZLFAjmix/5ZMfHm2dsuMzRSpZbDw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:cc:message-id:date:mime-version:content-type; s= default; bh=GN6UAPSIrm1zvJVItlkmAUvAV4I=; b=cu1R8n30g4DMvLax9XRl ygNdI0NW7cGbNoHOwNW1Pj2eGug15OiYSDaOQrZ7QvkpldOhIAluCt7w7oT+7ijQ uCkdKg94fXg9Qk6GOX+eZxLXuMFTcATBPbEoTaaTE35MX+E9bfs+Gdd0ctbQqB6I 9ZbKhDKf5b4zCX39NyE3Zos= Received: (qmail 73746 invoked by alias); 19 Nov 2017 00:10:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 73731 invoked by uid 89); 19 Nov 2017 00:10:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=1777, atm X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Nov 2017 00:10:00 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1eGDBL-0002g4-W1 from Tom_deVries@mentor.com ; Sat, 18 Nov 2017 16:09:56 -0800 Received: from [172.30.72.34] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Sun, 19 Nov 2017 00:09:52 +0000 To: GCC Patches , , From: Tom de Vries Subject: [vms, committed] Add missing vmsdbgout_early_finish CC: Jakub Jelinek , Richard Biener Message-ID: <753850da-5a04-bff4-c434-72414a35c19a@mentor.com> Date: Sun, 19 Nov 2017 01:09:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Hi, atm, any build for vms os will fail early in libgcc. dwarf2_debug_hooks.early_finish needs to be called before dwarf2_debug_hooks.finish. However, while vmsdbgout_finish calls dwarf2_debug_hooks.finish there's no vmsdbgout_early_finish, and dwarf2_debug_hooks.early_finish is not called otherwise. This patch fixes that, by adding vmsdbgout_early_finish calling dwarf2_debug_hooks.early_finish. I don't have a setup to build and test for vms os. I've built this for alpha-dec-vms as far as I can, which is until: ... src/libgcc/config/alpha/vms-gcc_shell_handler.c:32:10: fatal error: vms/chfdef.h: No such file or directory ... Approved at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82961#c8 . Committed to trunk. This is a 6/7 regression, but I'm somewhat reluctant to check this into release branches without proper build and test (though checking it in will probably unbreak the build). Thanks, - Tom [vms] Add missing vmsdbgout_early_finish 2017-11-18 Tom de Vries PR target/82961 * vmsdbgout.c (vmsdbgout_early_finish): New function. (vmsdbg_debug_hooks): Set early_finish field to vmsdbgout_early_finish. --- gcc/vmsdbgout.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gcc/vmsdbgout.c b/gcc/vmsdbgout.c index 580dd28..91dcd2e 100644 --- a/gcc/vmsdbgout.c +++ b/gcc/vmsdbgout.c @@ -147,6 +147,7 @@ static int write_srccorrs (int); static void vmsdbgout_init (const char *); static void vmsdbgout_finish (const char *); +static void vmsdbgout_early_finish (const char *); static void vmsdbgout_assembly_start (void); static void vmsdbgout_define (unsigned int, const char *); static void vmsdbgout_undef (unsigned int, const char *); @@ -176,7 +177,7 @@ static void vmsdbgout_abstract_function (tree); const struct gcc_debug_hooks vmsdbg_debug_hooks = {vmsdbgout_init, vmsdbgout_finish, - debug_nothing_charstar, + vmsdbgout_early_finish, vmsdbgout_assembly_start, vmsdbgout_define, vmsdbgout_undef, @@ -1556,6 +1557,13 @@ vmsdbgout_abstract_function (tree decl) (*dwarf2_debug_hooks.outlining_inline_function) (decl); } +static void +vmsdbgout_early_finish (const char *filename) +{ + if (write_symbols == VMS_AND_DWARF2_DEBUG) + (*dwarf2_debug_hooks.early_finish) (filename); +} + /* Output stuff that Debug requires at the end of every file and generate the VMS Debug debugging info. */