diff mbox

[MIPS] MSA AND.d optimization to generate BCLRI.d

Message ID 72E73D4BBFC6704695754C43662FC584C4F56947@PUMAIL01.pu.imgtec.org
State New
Headers show

Commit Message

Prachi Godbole March 9, 2017, 8:55 a.m. UTC 
Hi,

Here's a patch to disable the test for BCLRI.d optimization for level -O0.

OK for trunk?

Changelog:

2017-03-09  Prachi Godbole  <prachi.godbole@imgtec.com>

gcc/testsuite/
	* gcc.target/mips/msa-bclri.c: Skip the test for -O0.


-----Original Message-----
From: Matthew Fortune 
Sent: Monday, March 6, 2017 2:58 PM
To: Prachi Godbole; gcc-patches@gcc.gnu.org
Cc: Moore, Catherine
Subject: RE: [PATCH][MIPS]MSA AND.d optimization to generate BCLRI.d

Prachi Godbole <Prachi.Godbole@imgtec.com> writes:
> 2017-03-06  Prachi Godbole  <prachi.godbole@imgtec.com>
> 
> gcc/
> 	* config/mips/mips.c (mips_gen_const_int_vector): Change type of last
> 	argument.
> 	* config/mips/mips-protos.h (mips_gen_const_int_vector): Likewise.
> 
> gcc/testsuite/
> 	* gcc.target/mips/msa-bclri.c: New test.

OK, Thanks.

Matthew

Comments

Matthew Fortune March 9, 2017, 9:29 a.m. UTC | #1 
Prachi Godbole <Prachi.Godbole@imgtec.com> writes:
> 2017-03-09  Prachi Godbole  <prachi.godbole@imgtec.com>
> 
> gcc/testsuite/
> 	* gcc.target/mips/msa-bclri.c: Skip the test for -O0.
> 
> 
> Index: testsuite/gcc.target/mips/msa-bclri.c
> ===================================================================
> --- testsuite/gcc.target/mips/msa-bclri.c       (revision 245912)
> +++ testsuite/gcc.target/mips/msa-bclri.c       (working copy)
> @@ -1,5 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-options "-mno-mips16 -mfp64 -mhard-float -mmsa" } */
> +/* { dg-skip-if "" { *-*-* }  { "-O0" } { "" } } */
> 
>  typedef long long v2i64 __attribute__ ((vector_size(16)));

I guess this is effectively a code quality test as well as a
regression test for the bug so can you state "code quality test"
in the dg-skip-if string.

Otherwise OK for trunk,

Matthew
Prachi Godbole March 9, 2017, 9:39 a.m. UTC | #2 
Committed as r245995 with dg-skip-if comment change.

Prachi

-----Original Message-----
From: Matthew Fortune 
Sent: Thursday, March 9, 2017 2:59 PM
To: Prachi Godbole; gcc-patches@gcc.gnu.org
Cc: Moore, Catherine
Subject: RE: [PATCH][MIPS]MSA AND.d optimization to generate BCLRI.d

Prachi Godbole <Prachi.Godbole@imgtec.com> writes:
> 2017-03-09  Prachi Godbole  <prachi.godbole@imgtec.com>
> 
> gcc/testsuite/
> 	* gcc.target/mips/msa-bclri.c: Skip the test for -O0.
> 
> 
> Index: testsuite/gcc.target/mips/msa-bclri.c
> ===================================================================
> --- testsuite/gcc.target/mips/msa-bclri.c       (revision 245912)
> +++ testsuite/gcc.target/mips/msa-bclri.c       (working copy)
> @@ -1,5 +1,6 @@
>  /* { dg-do compile } */
>  /* { dg-options "-mno-mips16 -mfp64 -mhard-float -mmsa" } */
> +/* { dg-skip-if "" { *-*-* }  { "-O0" } { "" } } */
> 
>  typedef long long v2i64 __attribute__ ((vector_size(16)));

I guess this is effectively a code quality test as well as a regression test for the bug so can you state "code quality test"
in the dg-skip-if string.

Otherwise OK for trunk,

Matthew
diff mbox

Patch

Index: testsuite/gcc.target/mips/msa-bclri.c
===================================================================
--- testsuite/gcc.target/mips/msa-bclri.c       (revision 245912)
+++ testsuite/gcc.target/mips/msa-bclri.c       (working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do compile } */
 /* { dg-options "-mno-mips16 -mfp64 -mhard-float -mmsa" } */
+/* { dg-skip-if "" { *-*-* }  { "-O0" } { "" } } */

 typedef long long v2i64 __attribute__ ((vector_size(16)));