diff mbox

[committed] Fix failure of fortran.dg/coarray_40.f90 on hppa*-*-hpux*

Message ID 7015C491-35F3-452E-9EE1-CB37F90691AA@bell.net
State New
Headers show

Commit Message

John David Anglin Dec. 28, 2015, 9:19 p.m. UTC
On hppa*-*-hpux*, we need to link with libatomic to get "atomic" functions.  Fix is same as in
other tests.

Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.

Committed to trunk.

Dave
--
John David Anglin	dave.anglin@bell.net
2015-12-28  John David Anglin  <danglin@gcc.gnu.org>

	* gfortran.dg/coarray_40.f90: Link with libatomic if available.

Comments

Jakub Jelinek Dec. 28, 2015, 9:41 p.m. UTC | #1
On Mon, Dec 28, 2015 at 04:19:47PM -0500, John David Anglin wrote:
> On hppa*-*-hpux*, we need to link with libatomic to get "atomic" functions.  Fix is same as in
> other tests.
> 
> Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
> 
> Committed to trunk.
> 
> Dave
> --
> John David Anglin	dave.anglin@bell.net
> 
> 

> 2015-12-28  John David Anglin  <danglin@gcc.gnu.org>
> 
> 	* gfortran.dg/coarray_40.f90: Link with libatomic if available.
> 
> Index: gfortran.dg/coarray_40.f90
> ===================================================================
> --- gfortran.dg/coarray_40.f90	(revision 231978)
> +++ gfortran.dg/coarray_40.f90	(working copy)
> @@ -1,5 +1,6 @@
>  ! { dg-do run }
> -! { dg-options "-fcoarray=lib -lcaf_single" }
> +! { dg-options "-fcoarray=lib -lcaf_single -latomic" { target libatomic_available } }
> +! { dg-options "-fcoarray=lib -lcaf_single" { target { ! libatomic_available } } }
>  !
>  ! Run-time test for memory consistency
>  !

That is undesirable, please use
! { dg-options "-fcoarray=lib -lcaf_single" }
! { dg-additional-options "-latomic" { target libatomic_available } }
instead.

	Jakub
diff mbox

Patch

Index: gfortran.dg/coarray_40.f90
===================================================================
--- gfortran.dg/coarray_40.f90	(revision 231978)
+++ gfortran.dg/coarray_40.f90	(working copy)
@@ -1,5 +1,6 @@ 
 ! { dg-do run }
-! { dg-options "-fcoarray=lib -lcaf_single" }
+! { dg-options "-fcoarray=lib -lcaf_single -latomic" { target libatomic_available } }
+! { dg-options "-fcoarray=lib -lcaf_single" { target { ! libatomic_available } } }
 !
 ! Run-time test for memory consistency
 !