diff mbox

C++ PATCH for c++/70353 (core issue 1962)

Message ID 6FDC8F36-A3F8-4361-AE44-E4A1B82DE75C@lps.ens.fr
State New
Headers show

Commit Message

Dominique d'Humières March 26, 2016, 8:47 a.m. UTC 
Hi Jason,

The following tests for g++.dg/ext/fnname5.C fail on darwin

FAIL: g++.dg/ext/fnname5.C  -std=c++11  scan-assembler .string\\t"foo"
FAIL: g++.dg/ext/fnname5.C  -std=c++11  scan-assembler .string\\t"void A::foo\\\\(int\\\\)"
FAIL: g++.dg/ext/fnname5.C  -std=c++14  scan-assembler .string\\t"foo"
FAIL: g++.dg/ext/fnname5.C  -std=c++14  scan-assembler .string\\t"void A::foo\\\\(int\\\\)"
FAIL: g++.dg/ext/fnname5.C  -std=c++98  scan-assembler .string\\t"foo"
FAIL: g++.dg/ext/fnname5.C  -std=c++98  scan-assembler .string\\t"void A::foo\\\\(int\\\\) »

AFAICT the corresponding patterns are

	.ascii "foo\0"
	.ascii "void A::foo(int)\0 »

This is fixed by the following patch


TIA

Dominique

Comments

Jason Merrill March 28, 2016, 12:55 p.m. UTC | #1 
OK, thanks.

Jason
Dominique d'Humières March 28, 2016, 1:02 p.m. UTC | #2 
> Le 28 mars 2016 à 14:55, Jason Merrill <jason@redhat.com> a écrit :
> 
> OK, thanks.
> 
> Jason

Does it mean that I should commit the patch?

Dominique
Jason Merrill March 28, 2016, 1:11 p.m. UTC | #3 
On 03/28/2016 09:02 AM, Dominique d'Humières wrote:
>
>> Le 28 mars 2016 à 14:55, Jason Merrill <jason@redhat.com> a écrit :
>>
>> OK, thanks.
>>
>> Jason
>
> Does it mean that I should commit the patch?

Please.

Jason
Dominique d'Humières March 28, 2016, 1:22 p.m. UTC | #4 
> Le 28 mars 2016 à 15:11, Jason Merrill <jason@redhat.com> a écrit :
> 
> On 03/28/2016 09:02 AM, Dominique d'Humières wrote:
>> 
>>> Le 28 mars 2016 à 14:55, Jason Merrill <jason@redhat.com> a écrit :
>>> 
>>> OK, thanks.
>>> 
>>> Jason
>> 
>> Does it mean that I should commit the patch?
> 
> Please.

Revision 234504.

Dominique

> Jason
>
diff mbox

Patch

--- ../_clean/gcc/testsuite/g++.dg/ext/fnname5.C	2016-03-25 22:46:32.000000000 +0100
+++ gcc/testsuite/g++.dg/ext/fnname5.C	2016-03-26 09:04:51.000000000 +0100
@@ -29,5 +29,5 @@  main ()
 /* { dg-final { scan-assembler-not "_ZZN1A3fooEvE12__FUNCTION__" } } */
 /* { dg-final { scan-assembler-not "_ZZN1A3fooEiE12__FUNCTION__" } } */
 /* { dg-final { scan-assembler-not "_ZZN1A3fooEiE19__PRETTY_FUNCTION__" } } */
-/* { dg-final { scan-assembler ".string	\"void A::foo\\(int\\)\"" } } */
-/* { dg-final { scan-assembler ".string	\"foo\"" } } */
+/* { dg-final { scan-assembler ".(string|ascii) \"void A::foo\\(int\\)(.0)?\"" } } */
+/* { dg-final { scan-assembler ".(string|ascii) \"foo(.0)?\"" } } */