diff mbox

[MIPS] Update -mvirt option description

Message ID 6D39441BF12EF246A7ABCE6654B0235380BE22A2@HHMAIL01.hh.imgtec.org
State New
Headers show

Commit Message

Matthew Fortune March 31, 2017, 8 p.m. UTC 
Hi Catherine,

I'm following up on PR target/80057 to update the description of -mvirt.

I agree with Roland that the description is inconsistent and should not
state 'application specific' as none of the other ASE options include
it. Instead I suggest we put the shortened form of (VZ) in like (XPA)
is shown for -mxpa. The short form of virtualization ASE is usually VZ
not VIRT which has always irritated me about this option name but that
is history.

What do you think?

gcc/
	PR target/80057
	* config/mips/mips.opt (-mvirt): Update description.

Thanks,
Matthew

Comments

Moore, Catherine April 6, 2017, 3:23 p.m. UTC | #1 
> -----Original Message-----
> From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com]
> Sent: Friday, March 31, 2017 4:00 PM
> To: Moore, Catherine <Catherine_Moore@mentor.com>
> Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) <gcc-
> patches@gcc.gnu.org>; roland.illig@gmx.de
> Subject: [patch, MIPS] Update -mvirt option description
> 
> Hi Catherine,
> 
> I'm following up on PR target/80057 to update the description of -
> mvirt.
> 
> I agree with Roland that the description is inconsistent and should not
> state 'application specific' as none of the other ASE options include
> it. Instead I suggest we put the shortened form of (VZ) in like (XPA)
> is shown for -mxpa. The short form of virtualization ASE is usually VZ
> not VIRT which has always irritated me about this option name but
> that
> is history.
> 
> What do you think?

This looks good to me.
> 
> gcc/
> 	PR target/80057
> 	* config/mips/mips.opt (-mvirt): Update description.
>
diff mbox

Patch

diff --git a/gcc/config/mips/mips.opt b/gcc/config/mips/mips.opt
index 7c4b607..ced2432 100644
--- a/gcc/config/mips/mips.opt
+++ b/gcc/config/mips/mips.opt
@@ -406,7 +406,7 @@  Put uninitialized constants in ROM (needs -membedded-data).
 
 mvirt
 Target Report Var(TARGET_VIRT)
-Use Virtualization Application Specific instructions.
+Use Virtualization (VZ) instructions.
 
 mxpa
 Target Report Var(TARGET_XPA)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 8d3821e..19a85b6 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -19345,7 +19345,7 @@  Use (do not use) the MIPS Enhanced Virtual Addressing instructions.
 @itemx -mno-virt
 @opindex mvirt
 @opindex mno-virt
-Use (do not use) the MIPS Virtualization Application Specific instructions.
+Use (do not use) the MIPS Virtualization (VZ) instructions.
 
 @item -mxpa
 @itemx -mno-xpa