From patchwork Thu Mar 30 22:00:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Fortune X-Patchwork-Id: 745436 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vvJVX0vNhz9ryv for ; Fri, 31 Mar 2017 09:01:07 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="ke1cihCW"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=QJp Re+4s9qlN36Isnl8hi6dZ/WJpAU+wtDfdzS7QDKovDG+8VcrlKPdilkm31rY5qTa h5iiFqDDhcHBBHCA7d3XyZblfY94yW1oULxz/SUtZDd1sYYEoQHWmrXuNE7kiePm 1KgBw8PoI6tC4t77L71dozkO87FHmJFr8qSfGq4A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; s=default; bh=Ize5SdBT3 q2RvG6UCEoBq8hQM2E=; b=ke1cihCWYkU4vbXNa7S2ccahSimQ0dF4673V0SRse 8Y7pn+TEPutrbbv8ujKWSuuhga0A0YebSLx1/jvIlIhBCZknKTpPDFCvnZqTyd6T ki0DkZpHBVGklXTDGX/ZH4W5Vecg9BhAZKQAq/KQkvzUQgdCQ/sbi93Q5wSvEtsX vU= Received: (qmail 14864 invoked by alias); 30 Mar 2017 22:00:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 14238 invoked by uid 89); 30 Mar 2017 22:00:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=metal X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Mar 2017 22:00:34 +0000 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Forcepoint Email with ESMTPS id 96ABE57D2909E; Thu, 30 Mar 2017 23:00:28 +0100 (IST) Received: from HHMAIL01.hh.imgtec.org ([fe80::710b:f219:72bc:e0b3]) by hhmail02.hh.imgtec.org ([fe80::5400:d33e:81a4:f775%25]) with mapi id 14.03.0294.000; Thu, 30 Mar 2017 23:00:32 +0100 From: Matthew Fortune To: "'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)" CC: "Moore, Catherine (Catherine_Moore@mentor.com)" Subject: [PATCH, MIPS, committed] Fix pr52125.c test when built as -mno-abicalls -mabi=64 Date: Thu, 30 Mar 2017 22:00:31 +0000 Message-ID: <6D39441BF12EF246A7ABCE6654B0235380BE10C7@HHMAIL01.hh.imgtec.org> MIME-Version: 1.0 X-IsSubscribed: yes pr52125.c verifies that orphaned %hi relocs are deleted if they feed an inline asm statement that never emits the %lo part. Orphaned %hi relocs are only strictly a problem for o32 but are eliminated for any ABI as long as 32-bit addressing is in use so force -msym32 as well as require absolute addressing. This is necessary because -msym32 is only applied for n64 as part of downgrading -mabicalls to absolute addressing. I.e. this test was broken for bare metal n64 configs. gcc/testsuite/ * gcc.target/mips/pr52125.c: Add -msym32. diff --git a/gcc/testsuite/gcc.target/mips/pr52125.c b/gcc/testsuite/gcc.target/mips/pr52125.c index 2ac8067..46df940 100644 --- a/gcc/testsuite/gcc.target/mips/pr52125.c +++ b/gcc/testsuite/gcc.target/mips/pr52125.c @@ -1,4 +1,4 @@ -/* { dg-options "-mno-gpopt addressing=absolute" } */ +/* { dg-options "-mno-gpopt -msym32 addressing=absolute" } */ int a, b, c, d;