From patchwork Mon Sep 29 18:26:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Tannenbaum, Barry M" X-Patchwork-Id: 394542 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 10B4014012E for ; Tue, 30 Sep 2014 04:26:49 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=bv9QFpedYuAyOG8cay3sgp1VWB0L60J6BNxYRLmmmiaibExn0Z8cV invyWq40JmwNvWY31/opUmGWFd99KrHl8F0Mq9B6KZIuJv5FB9XycWn1cql0xUOw zIquNN9N57csAN/hFvpu+BUfsN4Vm+8Ig7ubPnJHQf8RQ9eyQ2KIbw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=/8Ijqk2aO8d17Z8a2t6EhJXlPmY=; b=mD2qczpDtotUUb02qzFEHWaMlef2 q1NTvlz8s6JasR6YOB85gEKTOnkK7PmASgAB+S4wpMV/TWn5nl4JwrFGvsaCgCZc /DZqk3aet+LrEwQAh55WNZ+ncHU8eRSiABCxdT06COJci0Gcpd+V3AImgkOUQmVn PPfYo4OeAf4XeBk= Received: (qmail 17636 invoked by alias); 29 Sep 2014 18:26:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17626 invoked by uid 89); 29 Sep 2014 18:26:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, MIME_BASE64_BLANKS, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Sep 2014 18:26:40 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by orsmga102.jf.intel.com with ESMTP; 29 Sep 2014 11:19:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by azsmga001.ch.intel.com with ESMTP; 29 Sep 2014 11:26:10 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 29 Sep 2014 11:26:10 -0700 Received: from fmsmsx107.amr.corp.intel.com ([169.254.9.132]) by FMSMSX157.amr.corp.intel.com ([169.254.14.174]) with mapi id 14.03.0195.001; Mon, 29 Sep 2014 11:26:09 -0700 From: "Tannenbaum, Barry M" To: Thomas Schwinge , "Iyer, Balaji V" , "Zamyatin, Igor" CC: "gcc-patches@gcc.gnu.org" Subject: RE: libcilkrts: Remove unused function __cilkrts_sysdep_is_worker_thread_id (was: Cilk Library) Date: Mon, 29 Sep 2014 18:26:08 +0000 Message-ID: <6B86B7F2A4026246AA81BA1ABF9756905C50D864@fmsmsx107.amr.corp.intel.com> References: <525460A9.2040409@redhat.com> <8738bae1mp.fsf@kepler.schwinge.homeip.net> In-Reply-To: <8738bae1mp.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 It's a remnant from something we were attempting to support (and abandoned) 4 years ago. I'm fine with removing it from the runtime. Igor, I'll make the change and send you a new copy. - Barry -----Original Message----- From: Thomas Schwinge [mailto:thomas@codesourcery.com] Sent: Monday, September 29, 2014 2:13 PM To: Iyer, Balaji V; Tannenbaum, Barry M; Zamyatin, Igor Cc: gcc-patches@gcc.gnu.org Subject: libcilkrts: Remove unused function __cilkrts_sysdep_is_worker_thread_id (was: Cilk Library) Hi! On Wed, 9 Oct 2013 18:32:11 +0000, "Iyer, Balaji V" wrote: > [libcilkrts] I have found a function that is -- as far as I can tell -- unused, and I'm thus proposing to remove it. This increases portability, as this code has dependencies on the operating system. Tested on x86 GNU/Hurd, and x86_64 GNU/Linux is in progress. OK for trunk once testing completed? commit 4f32339be3c95330b7fcd3bc6bb520a7401aa510 Author: Thomas Schwinge Date: Sat Sep 20 19:53:56 2014 +0200 libcilkrts: Remove unused function __cilkrts_sysdep_is_worker_thread_id. libcilkrts/ * runtime/sysdep-unix.c (__cilkrts_sysdep_is_worker_thread_id): Remove function. --- libcilkrts/runtime/sysdep-unix.c | 22 ---------------------- 1 file changed, 22 deletions(-) Grüße, Thomas diff --git libcilkrts/runtime/sysdep-unix.c libcilkrts/runtime/sysdep-unix.c index 1f82b62..b9f1ad0 100644 --- libcilkrts/runtime/sysdep-unix.c +++ libcilkrts/runtime/sysdep-unix.c @@ -571,28 +571,6 @@ void __cilkrts_make_unrunnable_sysdep(__cilkrts_worker *w, } } -/* - * __cilkrts_sysdep_is_worker_thread_id - * - * Returns true if the thread ID specified matches the thread ID we saved - * for a worker. - */ - -int __cilkrts_sysdep_is_worker_thread_id(global_state_t *g, - int i, - void *thread_id) -{ -#if defined( __linux__) || defined(__VXWORKS__) - pthread_t tid = *(pthread_t *)thread_id; - if (i < 0 || i > g->total_workers) - return 0; - return g->sysdep->threads[i] == tid; -#else - // Needs to be implemented - return 0; -#endif -} -