diff mbox

Fix template-params-12f.C on darwin/vxworks (PR debug/77389)

Message ID 6A677CA7-C679-4FE1-9838-8D14227DEF37@lps.ens.fr
State New
Headers show

Commit Message

Dominique d'Humières Sept. 4, 2016, 5:23 p.m. UTC 
The same should apply to g++.dg/debug/dwarf2/template-params-12g.C:


TIA

Dominique

> Le 30 août 2016 à 02:41, Mike Stump <mikestump@comcast.net> a écrit :
> 
> On Aug 29, 2016, at 12:41 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> 
>> This testcase expects to find DWARF extensions, but those are disabled by
>> default on darwin/vxworks because broken tools there don't handle debug info
>> very well.
>> 
>> I think the following patch (regtested on x86_64-linux and i686-linux)
>> should fix it, but I have no access to darwin, so can't verify.
>> 
>> Ok for trunk?
> 
> Ok.  :-)
> 
>> 
>> 2016-08-29  Jakub Jelinek  <jakub@redhat.com>
>> 
>> 	PR debug/77389
>> 	* g++.dg/debug/dwarf2/template-params-12f.C: Pass -gno-strict-dwarf
>> 	in dg-options.

Comments

Mike Stump Sept. 5, 2016, 11:20 p.m. UTC | #1 
On Sep 4, 2016, at 10:23 AM, Dominique d'Humières <dominiq@lps.ens.fr> wrote:
> 
> The same should apply to g++.dg/debug/dwarf2/template-params-12g.C:
> 
> --- ../_clean/gcc/testsuite/g++.dg/debug/dwarf2/template-params-12g.C	2016-08-12 09:59:34.000000000 +0200
> +++ gcc/testsuite/g++.dg/debug/dwarf2/template-params-12g.C	2016-08-30 11:36:48.000000000 +0200
> @@ -1,4 +1,4 @@
> -// { dg-options "-gdwarf-2 -dA" }
> +// { dg-options "-gdwarf-2 -gno-strict-dwarf -dA" }
> // { dg-final { scan-assembler-times "DIE \\(\[^\n\]*\\) DW_TAG_template_value_param" 1 } }
> // { dg-final { scan-assembler-times "DIE \\(\[^\n\]*\\) DW_TAG_template_value_param\[^\n\]*\n\[^\n\]* DW_AT_name\n\[^\n\]* DW_AT_type\n\[^\n\]*\[^\n\]* DW_AT_location\n\[^\n\]* DW_OP_addr\n\[^\n\]*_ZN1B1gEv\[^\n\]*\n\[^\n\]* DW_OP_stack_value\n\[^\n\]* DW_OP_piece\n\[^\n\]*\n\[^\n\]* DW_OP_lit0\n\[^\n\]* DW_OP_stack_value\n\[^\n\]* DW_OP_piece" 1 } }
> #include "template-params-12.H »
> 
> Unless someone objects, I’ll commit the patch in the coming days.

Ok.

> I also noticed that the same should apply to g++.dg/debug/dwarf2/imported-decl-2.C (pr57519). Is it OK to commit the following patch to trunk and the gcc-5 and 6 branches?

Ok.
diff mbox

Patch

--- ../_clean/gcc/testsuite/g++.dg/debug/dwarf2/template-params-12g.C	2016-08-12 09:59:34.000000000 +0200
+++ gcc/testsuite/g++.dg/debug/dwarf2/template-params-12g.C	2016-08-30 11:36:48.000000000 +0200
@@ -1,4 +1,4 @@ 
-// { dg-options "-gdwarf-2 -dA" }
+// { dg-options "-gdwarf-2 -gno-strict-dwarf -dA" }
 // { dg-final { scan-assembler-times "DIE \\(\[^\n\]*\\) DW_TAG_template_value_param" 1 } }
 // { dg-final { scan-assembler-times "DIE \\(\[^\n\]*\\) DW_TAG_template_value_param\[^\n\]*\n\[^\n\]* DW_AT_name\n\[^\n\]* DW_AT_type\n\[^\n\]*\[^\n\]* DW_AT_location\n\[^\n\]* DW_OP_addr\n\[^\n\]*_ZN1B1gEv\[^\n\]*\n\[^\n\]* DW_OP_stack_value\n\[^\n\]* DW_OP_piece\n\[^\n\]*\n\[^\n\]* DW_OP_lit0\n\[^\n\]* DW_OP_stack_value\n\[^\n\]* DW_OP_piece" 1 } }
 #include "template-params-12.H »

Unless someone objects, I’ll commit the patch in the coming days.

I also noticed that the same should apply to g++.dg/debug/dwarf2/imported-decl-2.C (pr57519). Is it OK to commit the following patch to trunk and the gcc-5 and 6 branches?

--- ../_clean/gcc/testsuite/g++.dg/debug/dwarf2/imported-decl-2.C	2015-09-26 23:16:11.000000000 +0200
+++ gcc/testsuite/g++.dg/debug/dwarf2/imported-decl-2.C	2015-09-26 23:16:55.000000000 +0200
@@ -1,5 +1,5 @@ 
 // { dg-do compile }
-// { dg-options "-gdwarf-2 -dA -O0 -fno-merge-debug-strings" }
+// { dg-options "-gdwarf-2 -gno-strict-dwarf -dA -O0 -fno-merge-debug-strings" }
 
 class AAAA
 {