diff mbox series

Add -fcommon to a test-case to re-trigger it.

Message ID 69b78e7f-dd5f-6500-5274-c3ad0c10887f@suse.cz
State New
Headers show
Series Add -fcommon to a test-case to re-trigger it. | expand

Commit Message

Martin Liška March 4, 2020, 11:53 a.m. UTC 
Hi.

I've noticed during working on VEC_COND_EXPR, that code added in
r10-2910-g9151048d854e352a9b83b771c6711b8221c73f7e is not executed.
It's also seen on our LCOV instance:
https://users.suse.com/~mliska/lcov/gcc/optabs.c.gcov.html
line 5889.

It started with the revision where we changed default to -fno-common.

Ready for trunk?
Thanks,
Martin

gcc/testsuite/ChangeLog:

2020-03-04  Martin Liska  <mliska@suse.cz>

	* gcc.target/i386/pr91623.c: Add -fcommon in order
	to re-trigger the needed code for the test-case which
	was added in r10-2910-g9151048d854e352a9b83b771c6711b8221c73f7e.
---
  gcc/testsuite/gcc.target/i386/pr91623.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Jelinek March 4, 2020, 11:57 a.m. UTC | #1 
On Wed, Mar 04, 2020 at 12:53:58PM +0100, Martin Liška wrote:
> Hi.
> 
> I've noticed during working on VEC_COND_EXPR, that code added in
> r10-2910-g9151048d854e352a9b83b771c6711b8221c73f7e is not executed.
> It's also seen on our LCOV instance:
> https://users.suse.com/~mliska/lcov/gcc/optabs.c.gcov.html
> line 5889.
> 
> It started with the revision where we changed default to -fno-common.
> 
> Ready for trunk?

Wouldn't it be better to add pr91623-2.c testcase that would #include
this one and have the additional -fcommon, so that we test both -fcommon and
default behavior?
If you think it is completely unnecessary, just go ahead with your patch.

	Jakub
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/i386/pr91623.c b/gcc/testsuite/gcc.target/i386/pr91623.c
index 94de4f91c6d..e42930d91db 100644
--- a/gcc/testsuite/gcc.target/i386/pr91623.c
+++ b/gcc/testsuite/gcc.target/i386/pr91623.c
@@ -1,6 +1,6 @@ 
 /* PR middle-end/91623 */
 /* { dg-do compile } */
-/* { dg-options "-O3 -msse4.1 -mno-sse4.2" } */
+/* { dg-options "-O3 -msse4.1 -mno-sse4.2 -fcommon" } */
 
 typedef long long V __attribute__((__vector_size__(16)));
 V e, h;