From patchwork Tue Mar 26 03:18:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerry D X-Patchwork-Id: 1915938 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=FOWT452m; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V3ZmD60kjz1yY2 for ; Tue, 26 Mar 2024 14:19:40 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8AAC3858408 for ; Tue, 26 Mar 2024 03:19:38 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 364A33858D33; Tue, 26 Mar 2024 03:19:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 364A33858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 364A33858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1029 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711423142; cv=none; b=w1z7ZE2A4vrFzikENE5DML0SqO20l0JfMxQqNjJPn6iMnHoe/5mcwvn8DIzKxpiyeGsBXxUWu7UXH8HjaUcBMBgNohy3enAHhntxKPNMDdC35p9/4S7SFuWFz85bfUOdTCbcJgJjYdaIreH/sGHB5qpvS9hEJx1rPRNyHvnyugk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711423142; c=relaxed/simple; bh=Bhw8hj8qmqlEBVlQ4ZRlzZ8kdl49VyxR7IEthgk9aLs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=fkUkCcTl+576fizjPN5UGUDBxavh24XkWTZe18i10G0OlkWbuOlylKaZLc0aWub4RDpvosY1YVHEO/0ozTelppFpo5eiP2fWosmg1vDC6CKJmexdv8eiJrwXCTZ6/hSHqReuUmpbhRAgVpw4uA8hz5rpCRppYQO9Lu0GMd4Zjkk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-29df844539bso974182a91.1; Mon, 25 Mar 2024 20:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711423139; x=1712027939; darn=gcc.gnu.org; h=autocrypt:subject:from:cc:to:content-language:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=rbknAd//D0IzfMqsa8D2zMDPmEnZk5ROrtkS0kJivc4=; b=FOWT452m2qCpsevH1JkpJE1Fcql4KPHpC7PRZ3NcxEwszuo5ypACQKmWo9in4+qp0n dgDl3O/M6KrIpYDL5cED0Fjcox5/OKIXR/4TGb5MVmXU/Xq/ah8WCAXXN/HYDEUZnAuy 0vUPpWKJlAY3Q4ESuam/FqSYXqdm/Qie2BJE3zxtheB54mxxkuVWNnRc3NgjenbTTx6b Hr29Gwsl3pNDlRcrsSK/CbtiJP+/cF901DR/uNjfh/cpfvVoHYYlTlxY6qzQBykGj3h6 nn3eKzLbmMKCwFtHGJBNFwUPTgkgGVNC+3fLGymDatAzkMnQp8u3/BwyFdX3oZyKGJa7 DZ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711423139; x=1712027939; h=autocrypt:subject:from:cc:to:content-language:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rbknAd//D0IzfMqsa8D2zMDPmEnZk5ROrtkS0kJivc4=; b=AY8x3pULWPmc48stZFh//DAEtOoDMnmg0Sxr7wrwvwhATTGF/+9dGKNdFh04ugrPX/ Qe91bYJkZy+yFGS4jmZ9oVCKMNL5fnfDBa2FwfQY6H2efamwpiQ/vh71OARjD52S0Odz +N5eJrsBiFYGgnIHn1nQrl2hVAy+qmY/puSPDPVIXu7GDhQaZ58uu5EPZ43INBwFsGZc IwTwgP6LZaMR0q4Df+7QfMr3yAgykyYwHgX8yXds0GFUhqH3yuGfN9835yH8eXHSnqa6 SQxCp+vsV8b4mf84PMurEtloG/olOjq2oXOzKn5TiH0q/M8SSgpOUPXOZcuPzkB8hUAi IkSQ== X-Gm-Message-State: AOJu0YzwhF3Xwa4sllgJjLF7xcbXkl2gt4Um/eAJDoSOPsU3KeQ78x/Z ycH6JIJ4hyNrvip6zZYivS97LcIU6jwjyGsidVzotjhMqVLhCroxyNKtA3P2 X-Google-Smtp-Source: AGHT+IFZL4k2J87yTquCbRgErZ9cXDVPv/qHvtJBCOjeRZ1V19mdDMhI0cC/C6B3JSYvQGbXNhgg6g== X-Received: by 2002:a05:6a00:2d20:b0:6e7:7bd3:f69a with SMTP id fa32-20020a056a002d2000b006e77bd3f69amr11384832pfb.2.1711423138504; Mon, 25 Mar 2024 20:18:58 -0700 (PDT) Received: from [192.168.1.20] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id p12-20020a62ab0c000000b006e6a684a6ddsm4940166pff.220.2024.03.25.20.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 20:18:58 -0700 (PDT) Message-ID: <67280203-8877-4be7-b988-a87fb9ff6967@gmail.com> Date: Mon, 25 Mar 2024 20:18:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: gfortran Cc: gcc-patches From: Jerry D Subject: [patch, libgfortran] PR107031 - endfile truncates file at wrong position Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi all, There has been a bit of discussio on which way to go on this. I took a look today and this trivial patch gives the behavior concluded on Fortran Discourse. See the bugzilla for all the relevant information. Regresion tested on x86-64. I will do the appropriate changelog. OK for trunk? Attached is a new test case and the patch here: diff --git a/libgfortran/io/file_pos.c b/libgfortran/io/file_pos.c index 2bc05b293f8..d169961f997 100644 --- a/libgfortran/io/file_pos.c +++ b/libgfortran/io/file_pos.c @@ -352,7 +352,6 @@ st_endfile (st_parameter_filepos *fpp) dtp.common = fpp->common; memset (&dtp.u.p, 0, sizeof (dtp.u.p)); dtp.u.p.current_unit = u; - next_record (&dtp, 1); } unit_truncate (u, stell (u->s), &fpp->common);