| Message ID | 5bd99166-a553-30d2-70c8-95ac3d62231e@foss.arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [gas] Implement .cfi_negate_ra_state directive | expand |
Sorry, wrong list address from my side, please ignore. Kyrill On 12/5/19 10:59 AM, Kyrill Tkachov wrote: > Hi all, > > This patch implements the .cfi_negate_ra_state to be consistent with > LLVM (https://reviews.llvm.org/D50136). The relevant DWARF code > DW_CFA_AARCH64_negate_ra_state > is multiplexed on top of DW_CFA_GNU_window_save, as per > https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00753.html > > I believe this is the simplest patch implementing this and is needed to > allow users to build, for example, the Linux kernel with Armv8.3-A > pointer authentication support with Clang while using gas as the > assembler, which is a common usecase. > > Tested gas aarch64-none-elf. > Ok for master and the release branches? > > Thanks, > Kyrill > > gas/ > 2019-12-05 Kyrylo Tkachov <kyrylo.tkachov@arm.com> > > * dw2gencfi.c (cfi_pseudo_table): Add cfi_negate_ra_state. > * testsuite/gas/aarch64/pac_negate_ra_state.s: New file. > * testsuite/gas/aarch64/pac_negate_ra_state.d: Likewise. >
diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c index 6c0478a72063801f1f91441a11350daa94605843..707830cbe82f860d21c3b9b8f7cbe1999568398b 100644 --- a/gas/dw2gencfi.c +++ b/gas/dw2gencfi.c @@ -726,6 +726,7 @@ const pseudo_typeS cfi_pseudo_table[] = { "cfi_remember_state", dot_cfi, DW_CFA_remember_state }, { "cfi_restore_state", dot_cfi, DW_CFA_restore_state }, { "cfi_window_save", dot_cfi, DW_CFA_GNU_window_save }, + { "cfi_negate_ra_state", dot_cfi, DW_CFA_AARCH64_negate_ra_state }, { "cfi_escape", dot_cfi_escape, 0 }, { "cfi_signal_frame", dot_cfi, CFI_signal_frame }, { "cfi_personality", dot_cfi_personality, 0 }, diff --git a/gas/testsuite/gas/aarch64/pac_negate_ra_state.d b/gas/testsuite/gas/aarch64/pac_negate_ra_state.d new file mode 100644 index 0000000000000000000000000000000000000000..7ab0f2369dece1a71fc064ae38f6e273128bf074 --- /dev/null +++ b/gas/testsuite/gas/aarch64/pac_negate_ra_state.d @@ -0,0 +1,26 @@ +#objdump: --dwarf=frames + +.+: file .+ + +Contents of the .eh_frame section: + +00000000 0000000000000010 00000000 CIE + Version: 1 + Augmentation: "zR" + Code alignment factor: 4 + Data alignment factor: -8 + Return address column: 30 + Augmentation data: 1b + DW_CFA_def_cfa: r31 \(sp\) ofs 0 + +00000014 0000000000000018 00000018 FDE cie=00000000 pc=0000000000000000..0000000000000008 + DW_CFA_advance_loc: 4 to 0000000000000004 + DW_CFA_GNU_window_save + DW_CFA_advance_loc: 4 to 0000000000000008 + DW_CFA_def_cfa_offset: 16 + DW_CFA_offset: r29 \(x29\) at cfa-16 + DW_CFA_offset: r30 \(x30\) at cfa-8 + DW_CFA_nop + DW_CFA_nop + + diff --git a/gas/testsuite/gas/aarch64/pac_negate_ra_state.s b/gas/testsuite/gas/aarch64/pac_negate_ra_state.s new file mode 100644 index 0000000000000000000000000000000000000000..36ddbeb43b7002a68eb6787a21599eb20d2b965e --- /dev/null +++ b/gas/testsuite/gas/aarch64/pac_negate_ra_state.s @@ -0,0 +1,20 @@ + .arch armv8-a + .text + .align 2 + .global _Z5foo_av + .type _Z5foo_av, %function +_Z5foo_av: +.LFB0: + .cfi_startproc + hint 25 // paciasp + .cfi_negate_ra_state + stp x29, x30, [sp, -16]! + .cfi_def_cfa_offset 16 + .cfi_offset 29, -16 + .cfi_offset 30, -8 + .cfi_endproc +.LFE0: + .size _Z5foo_av, .-_Z5foo_av + .align 2 + .global _Z5foo_bv + .type _Z5foo_bv, %function