From patchwork Thu Mar 10 15:42:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrill Tkachov X-Patchwork-Id: 595826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C0D5A1402A1 for ; Fri, 11 Mar 2016 02:42:53 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=S/sLSN2P; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=O0ZKauHOkUa6ZBeDmXzRwnxiD1o3s1txiyma/9sjrgB nEBUjWERI5aDE5JRGR1t6oTEC6s32FL0jwEC3LRQkMgcanby7MUaH2X0R+B+uLmq J0cBUktEq6AU9zMQHS9ym4S2HezuaKVmi2GjbQyT96jJtCftK1VU+q4AIRQLx4EA = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=sTu5gAjbo58aPgRUgqG3k4hV04I=; b=S/sLSN2PSi6YNyhal BPkB2/cNNERC4HU27EcbjymWX8jhq6UsUZc0hQVSUZeWWsHgRwwIQ2qc2YPQBXIZ NVBbHC2VrsRjM5F5c/EWGdNMlqXtzIXMP9HpsjoaWbcRsrwGuOtx7u4VFlGUdgCI 90N08P4S+5ok6hYkJlJiI+3ByU= Received: (qmail 104499 invoked by alias); 10 Mar 2016 15:42:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 104485 invoked by uid 89); 10 Mar 2016 15:42:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*u:31.2.0, H*UA:31.2.0 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Mar 2016 15:42:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E5ADA4A7; Thu, 10 Mar 2016 07:41:41 -0800 (PST) Received: from [10.2.206.200] (e100706-lin.cambridge.arm.com [10.2.206.200]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12D9B3F211; Thu, 10 Mar 2016 07:42:39 -0800 (PST) Message-ID: <56E195EE.4070903@foss.arm.com> Date: Thu, 10 Mar 2016 15:42:38 +0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: GCC Patches CC: Marcus Shawcroft , Richard Earnshaw , James Greenhalgh Subject: [PATCH][AArch64] Fix thinko in handling of -momit-leaf-frame-pointer option Hi all, When extending the aarch64_handle_option function for GCC 6 I introduced a thinko when handling the -momit-leaf-frame-pointer option and had it set the variable for -fomit-frame-pointer instead. This hasn't been particularly impactful because -momit-leaf-frame-pointer is on by default and will set -fomit-frame-pointer to true anyway in aarch64_override_options_after_change_1, but it would be exposed by the fix for PR 70044. This patch fixes that thinko. Bootstrapped and tested on aarch64-none-linux-gnu. Ok for trunk? Thanks, Kyrill 2016-03-10 Kyrylo Tkachov * common/config/aarch64/aarch64-common.c (aarch64_handle_option): Set x_flag_omit_leaf_frame_pointer when handling -momit-leaf-frame-pointer. diff --git a/gcc/common/config/aarch64/aarch64-common.c b/gcc/common/config/aarch64/aarch64-common.c index 69f5da70e3d796752040de80ab1594a260e613d1..4969f07fef4c1c7d3bd7e5fa03149a4945e30b23 100644 --- a/gcc/common/config/aarch64/aarch64-common.c +++ b/gcc/common/config/aarch64/aarch64-common.c @@ -98,7 +98,7 @@ aarch64_handle_option (struct gcc_options *opts, return true; case OPT_momit_leaf_frame_pointer: - opts->x_flag_omit_frame_pointer = val; + opts->x_flag_omit_leaf_frame_pointer = val; return true; default: