diff mbox

Remove redundant unshare_expr from ipa-prop

Message ID 56A1CDDE.7040100@linaro.org
State New
Headers show

Commit Message

Kugan Vivekanandarajah Jan. 22, 2016, 6:36 a.m. UTC
Hi,

There is a redundant unshare_expr in ipa-prop. Attached patch removes
it. Bootstrapped and regression tested on x86_64-pc-linux-gnu with no
new regressions.

Is this OK for trunk?

Thanks,
Kugan

gcc/ChangeLog:

2016-01-22  Kugan Vivekanandarajah  <kuganv@linaro.org>

	* ipa-prop.c (ipa_set_jf_constant): Remove redundant unshare_expr.

Comments

Jakub Jelinek Jan. 22, 2016, 8:32 a.m. UTC | #1
On Fri, Jan 22, 2016 at 05:36:14PM +1100, Kugan wrote:
> There is a redundant unshare_expr in ipa-prop. Attached patch removes
> it. Bootstrapped and regression tested on x86_64-pc-linux-gnu with no
> new regressions.
> 
> Is this OK for trunk?
> 
> Thanks,
> Kugan
> 
> gcc/ChangeLog:
> 
> 2016-01-22  Kugan Vivekanandarajah  <kuganv@linaro.org>
> 
> 	* ipa-prop.c (ipa_set_jf_constant): Remove redundant unshare_expr.

Ok, thanks.

> diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c
> index 06a9aa2..d62c704 100644
> --- a/gcc/ipa-prop.c
> +++ b/gcc/ipa-prop.c
> @@ -402,9 +402,6 @@ static void
>  ipa_set_jf_constant (struct ipa_jump_func *jfunc, tree constant,
>  		     struct cgraph_edge *cs)
>  {
> -  constant = unshare_expr (constant);
> -  if (constant && EXPR_P (constant))
> -    SET_EXPR_LOCATION (constant, UNKNOWN_LOCATION);
>    jfunc->type = IPA_JF_CONST;
>    jfunc->value.constant.value = unshare_expr_without_location (constant);

	Jakub
diff mbox

Patch

diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c
index 06a9aa2..d62c704 100644
--- a/gcc/ipa-prop.c
+++ b/gcc/ipa-prop.c
@@ -402,9 +402,6 @@  static void
 ipa_set_jf_constant (struct ipa_jump_func *jfunc, tree constant,
 		     struct cgraph_edge *cs)
 {
-  constant = unshare_expr (constant);
-  if (constant && EXPR_P (constant))
-    SET_EXPR_LOCATION (constant, UNKNOWN_LOCATION);
   jfunc->type = IPA_JF_CONST;
   jfunc->value.constant.value = unshare_expr_without_location (constant);