From patchwork Thu Oct 20 16:50:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Eager X-Patchwork-Id: 1692651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=eagercon.com header.i=@eagercon.com header.a=rsa-sha256 header.s=dreamhost header.b=n1lEkPa9; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MtYX51cyFz23jk for ; Fri, 21 Oct 2022 03:51:17 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9BC3384D14E for ; Thu, 20 Oct 2022 16:51:14 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from cross.elm.relay.mailchannels.net (cross.elm.relay.mailchannels.net [23.83.212.46]) by sourceware.org (Postfix) with ESMTPS id 6B593384F021 for ; Thu, 20 Oct 2022 16:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B593384F021 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CFD0A202635; Thu, 20 Oct 2022 16:50:46 +0000 (UTC) Received: from pdx1-sub0-mail-a309 (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 541F520224C; Thu, 20 Oct 2022 16:50:46 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1666284646; a=rsa-sha256; cv=none; b=RB+2ucjVwXQQc7T20Ls3ggKvhx7NWMwZ/SJe6WmDRdgMpL4HUYKY5ELILUJUJi8MwipFkt 7B/4WTn8ucDk6md468kd6l57MubRool5tymKLR+2S1Ur6Kn+1xEKjezmC9p7Ooem6Ry/ER BCXF0g8j0RVF3vvnwrw+7SHnP1G4FnWVI1g/2L1jp/NG6bKV1s0DlrlZWLqr9uqOAYA76n 51mDPeEecWzad0+ilYXbSGMS9G837cUCYGwyNHAls8J3EIl1bP3ZRUu3rSEBf1ZbMNak6w u5TxySqFvSiPgP6jwyVK5J4tlpQ7rqZxT1CiQQr76Et+Gs70pvJZDB6DVbXzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1666284646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: dkim-signature; bh=Zcnr8wFWk0Z7SLugMPyRle5YU0k46RCloT1PtI8Jonk=; b=LTvY1KAXPXXkNkhRNls4P+GQXbr9/7sZdNQceSjDLPsgJf/JCd8g+3qI7n96iIFQEh3mW0 t4uJTNQPFozeipzZyCABS7NXjPPDJRlivLLj+Im3WU2CMMLT0pm9Jo0DFhpp3+ssw5wzfN up1TA34CFJJqaZdC1cxN+RaSAteHF1frNzasPEBPvWbnIwXNkftJ/me38+uWqOa96pF0I2 xfTfWvse3cpqGgykVUR+/FydJpiNMq2MfbwDBhnxfrM3vVwjNehd0lJh6O6O7n4Z1FpIzS /y0puXNHUHmOxt5EwNrwPZHNahp+6zmn5DZ/LPsjZAsRiC73Jj1BpmAq6fgCCw== ARC-Authentication-Results: i=1; rspamd-6955c7cd5b-g5mr8; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Fumbling-Lettuce: 76d2b68d15ca3830_1666284646583_1455342961 X-MC-Loop-Signature: 1666284646582:2739759390 X-MC-Ingress-Time: 1666284646582 Received: from pdx1-sub0-mail-a309 (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.63.149 (trex/6.7.1); Thu, 20 Oct 2022 16:50:46 +0000 Received: from [192.168.20.12] (c-73-241-148-180.hsd1.ca.comcast.net [73.241.148.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a309 (Postfix) with ESMTPSA id 4MtYWT6Rf4z38; Thu, 20 Oct 2022 09:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1666284646; bh=Zcnr8wFWk0Z7SLugMPyRle5YU0k46RCloT1PtI8Jonk=; h=Content-Type:Date:To:Cc:From:Subject; b=n1lEkPa9UxuJ0nKmbxfe7B2tlFMSLr1srWU4vIKQ6rNQJiEOUsY5A2oIdWYC1qW16 y74ZRYsepnOnxNOaohs1fpvr1Vo2OSJozCeiurehChu5F44JKXaM4xUM3JyH5i4tB9 C1v/wp6Aio6eF2zLUB+jnvXFPdoH6Ix4OaHqjy1Wp7p58FRlGGT9D6xE/B/CRm9b1p /CzTKkUxMuY1jLRLKG1JKwWSnJkz4kxcZgC0eWFOtdd/WNDl64rvhrnhEguywiecgQ iBo7fTJ1kyI4wstiv6tamZYXH+M48b8aDQxUWX+DaYHS8AgEPhBbHIdWqmzOmoOFv7 0kk7IS9MTinEQ== Message-ID: <562bb602-4a49-46b5-acd2-5755372aa755@eagercon.com> Date: Thu, 20 Oct 2022 09:50:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: gcc-patches@gcc.gnu.org Content-Language: en-US From: Michael Eager Subject: [PATCH] Fix uninitialized variable warnings X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The attached patch corrects a couple uninitialized variable warnings. The variables are initialized to NULL and tests for this, calling gcc_unreachable(). Replace other calls to abort() for with gcc_unreachable(). Thanks to Jan-Benedict Glaw for bringing this to my attention. ** I'm receiving a "service not enabled" error when I push. ** Can someone apply this patch while I resolve this issue? From a0fd2e9baa51e85f61cebd6e78bef8b5c55199b5 Mon Sep 17 00:00:00 2001 From: Michael Eager Date: Thu, 20 Oct 2022 09:33:13 -0700 Subject: [PATCH] Fix uninitialized variable warnings gcc/ChangeLog: * gcc/config/microblaze/microblaze.cc (microblaze_legitimize_address): Initialize 'reg' to NULL, check for NULL. (microblaze_address_insns): Replace abort() with gcc_unreachable(). (print_operand_address): Same. (microblaze_expand_move): Initialize 'p1' to NULL, check for NULL. (get_branch_target): Replace abort() with gcc_unreachable(). --- gcc/ChangeLog | 9 +++++++++ gcc/config/microblaze/microblaze.cc | 19 ++++++++++++++----- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7a50293c780..8271fafe033 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,12 @@ +2022-10-20 Michael Eager + + * gcc/config/microblaze/microblaze.cc + (microblaze_legitimize_address): Initialize 'reg' to NULL, check for NULL. + (microblaze_address_insns): Replace abort() with gcc_unreachable(). + (print_operand_address): Same. + (microblaze_expand_move): Initialize 'p1' to NULL, check for NULL. + (get_branch_target): Replace abort() with gcc_unreachable(). + 2022-10-19 Aldy Hernandez * range-op-float.cc (build_le): Document result. diff --git a/gcc/config/microblaze/microblaze.cc b/gcc/config/microblaze/microblaze.cc index 8fcca1829f6..9290a1f3958 100644 --- a/gcc/config/microblaze/microblaze.cc +++ b/gcc/config/microblaze/microblaze.cc @@ -1103,7 +1103,7 @@ microblaze_legitimize_address (rtx x, rtx oldx ATTRIBUTE_UNUSED, if (GET_CODE (xinsn) == SYMBOL_REF) { - rtx reg; + rtx reg = NULL; if (microblaze_tls_symbol_p(xinsn)) { reg = microblaze_legitimize_tls_address (xinsn, NULL_RTX); @@ -1133,6 +1133,11 @@ microblaze_legitimize_address (rtx x, rtx oldx ATTRIBUTE_UNUSED, reg = pic_ref; } } + else + { + /* This should never happen. */ + gcc_unreachable (); + } return reg; } @@ -1474,7 +1479,7 @@ microblaze_address_insns (rtx x, machine_mode mode) case TLS_DTPREL: return 1; default : - abort(); + gcc_unreachable (); } default: break; @@ -2624,7 +2629,7 @@ print_operand_address (FILE * file, rtx addr) fputs ("@TLSDTPREL", file); break; default : - abort(); + gcc_unreachable (); break; } } @@ -3413,7 +3418,7 @@ microblaze_expand_move (machine_mode mode, rtx operands[]) } if (GET_CODE (op1) == PLUS && GET_CODE (XEXP (op1,1)) == CONST) { - rtx p0, p1, result, temp; + rtx p0, p1 = NULL, result, temp; p0 = XEXP (XEXP (op1,1), 0); @@ -3423,6 +3428,10 @@ microblaze_expand_move (machine_mode mode, rtx operands[]) p0 = XEXP (p0, 0); } + /* This should never happen. */ + if (p1 == NULL) + gcc_unreachable (); + if (GET_CODE (p0) == UNSPEC && GET_CODE (p1) == CONST_INT && flag_pic && TARGET_PIC_DATA_TEXT_REL) { @@ -3799,7 +3808,7 @@ get_branch_target (rtx branch) if (GET_CODE (call) == SET) call = SET_SRC (call); if (GET_CODE (call) != CALL) - abort (); + gcc_unreachable (); return XEXP (XEXP (call, 0), 0); } -- 2.31.1