| Message ID | 55E5D283.8080105@mentor.com |
|---|---|
| State | New |
| Headers | show |
Hi! On Tue, 1 Sep 2015 18:29:55 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote: > On 27/08/15 03:37, Cesar Philippidis wrote: > > - ctx->ganglocal_size_host = align_and_expand (&gl_host, host_size, align); > > I suspect this caused a bootstrap failure (align_and_expand unused). > Worked-around as attached. > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -1450,7 +1450,7 @@ omp_copy_decl (tree var, copy_body_data *cb) > > /* Modify the old size *POLDSZ to align it up to ALIGN, and then return > a value with SIZE added to it. */ > -static tree > +static tree ATTRIBUTE_UNUSED > align_and_expand (tree *poldsz, tree size, unsigned int align) > { > tree oldsz = *poldsz; If I remember correctly, this has only ever been used in the "ganglocal" implementation -- which is now gone. So, should align_and_expand also be elided (Cesar)? Grüße, Thomas
On 09/18/2015 01:39 AM, Thomas Schwinge wrote: > On Tue, 1 Sep 2015 18:29:55 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote: >> On 27/08/15 03:37, Cesar Philippidis wrote: >>> - ctx->ganglocal_size_host = align_and_expand (&gl_host, host_size, align); >> >> I suspect this caused a bootstrap failure (align_and_expand unused). >> Worked-around as attached. > >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c >> @@ -1450,7 +1450,7 @@ omp_copy_decl (tree var, copy_body_data *cb) >> >> /* Modify the old size *POLDSZ to align it up to ALIGN, and then return >> a value with SIZE added to it. */ >> -static tree >> +static tree ATTRIBUTE_UNUSED >> align_and_expand (tree *poldsz, tree size, unsigned int align) >> { >> tree oldsz = *poldsz; > > If I remember correctly, this has only ever been used in the "ganglocal" > implementation -- which is now gone. So, should align_and_expand also be > elided (Cesar)? Most likely. I probably overlooked it when I was working on that ganglocal removal patch. Can you remove it please? I'm already juggling a couple of patches right now. Thanks, Cesar
Mark align_and_expand as unused 2015-09-01 Tom de Vries <tom@codesourcery.com> * omp-low.c (align_and_expand): Mark as unused. --- gcc/omp-low.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index a62daa2..fdca880 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -1450,7 +1450,7 @@ omp_copy_decl (tree var, copy_body_data *cb) /* Modify the old size *POLDSZ to align it up to ALIGN, and then return a value with SIZE added to it. */ -static tree +static tree ATTRIBUTE_UNUSED align_and_expand (tree *poldsz, tree size, unsigned int align) { tree oldsz = *poldsz; -- 1.9.1
On 27/08/15 03:37, Cesar Philippidis wrote: > - ctx->ganglocal_size_host = align_and_expand (&gl_host, host_size, align); I suspect this caused a bootstrap failure (align_and_expand unused). Worked-around as attached. Thanks, - Tom