| Message ID | 55E5B6BC.6020005@arm.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 1 Sep 2015, Kyrill Tkachov wrote: > This wwwdocs patch adds an entry to the GCC 6 changes page about the > aarch64 target attributes and pragmas support. Thanks for thinking of this, Kyrill. Index: htdocs/gcc-6/changes.html =================================================================== + <li> + The AArch64 port now supports target attributes and pragmas. Please + refer to the documentation for details of available attributes and + pragmas as well as usage instructions. + </li> Here, isn't the second sentence the default assumption anyway, that is, do we need to highlight it specifically or can we omit it? Please consider this feedback (and "let's keep it as is" is a fine response, too) and go ahead. Gerald
Hi Gerald, On 01/09/15 18:29, Gerald Pfeifer wrote: > On Tue, 1 Sep 2015, Kyrill Tkachov wrote: >> This wwwdocs patch adds an entry to the GCC 6 changes page about the >> aarch64 target attributes and pragmas support. > Thanks for thinking of this, Kyrill. Thanks for the feedback. > > Index: htdocs/gcc-6/changes.html > =================================================================== > + <li> > + The AArch64 port now supports target attributes and pragmas. Please > + refer to the documentation for details of available attributes and > + pragmas as well as usage instructions. > + </li> > > Here, isn't the second sentence the default assumption anyway, > that is, do we need to highlight it specifically or can we omit > it? My thinking was that when we introduce some new command-line option we list it here and give a short description of it (new -mcpu values, for example). However, here we introduce about 10 new target attributes and pragmas and listing them all would make this entry too long for my liking so as a shorthand for listing them all I chose to point to the documentation. Unless you feel strongly against this reasoning I'd like to commit the patch as is within 48 hours. > > Please consider this feedback (and "let's keep it as is" is a > fine response, too) and go ahead. > > Gerald >
On Wed, 2 Sep 2015, Kyrill Tkachov wrote: > My thinking was that when we introduce some new command-line option we > list it here and give a short description of it (new -mcpu values, for > example). However, here we introduce about 10 new target attributes and > pragmas and listing them all would make this entry too long for my > liking so as a shorthand for listing them all I chose to point to the > documentation. > > Unless you feel strongly against this reasoning I'd like to commit the > patch as is within 48 hours. I can follow your reasoning, and anyway the 48 hours are way over ;-), just have you considered adding a reference to the documentation (as a hyperlink to the respective section, if there is a good one, such as https://gcc.gnu.org/onlinedocs/gcc/ARM-Pragmas.html#ARM-Pragmas )? Gerald >
Hi Gerald, On 07/09/15 12:31, Gerald Pfeifer wrote: > On Wed, 2 Sep 2015, Kyrill Tkachov wrote: >> My thinking was that when we introduce some new command-line option we >> list it here and give a short description of it (new -mcpu values, for >> example). However, here we introduce about 10 new target attributes and >> pragmas and listing them all would make this entry too long for my >> liking so as a shorthand for listing them all I chose to point to the >> documentation. >> >> Unless you feel strongly against this reasoning I'd like to commit the >> patch as is within 48 hours. > I can follow your reasoning, and anyway the 48 hours are way over ;-), > just have you considered adding a reference to the documentation (as a > hyperlink to the respective section, if there is a good one, such as > https://gcc.gnu.org/onlinedocs/gcc/ARM-Pragmas.html#ARM-Pragmas )? Good idea, I'll send a patch to mention the link. The relevant one is: https://gcc.gnu.org/onlinedocs/gcc/AArch64-Function-Attributes.html#AArch64-Function-Attributes Thanks, Kyrill > > Gerald
Hi Kyril, On 09/02/2015 10:24 AM, Kyrill Tkachov wrote: > Hi Gerald, > > On 01/09/15 18:29, Gerald Pfeifer wrote: >> On Tue, 1 Sep 2015, Kyrill Tkachov wrote: >>> This wwwdocs patch adds an entry to the GCC 6 changes page about the >>> aarch64 target attributes and pragmas support. >> Thanks for thinking of this, Kyrill. > > Thanks for the feedback. > >> >> Index: htdocs/gcc-6/changes.html >> =================================================================== >> + <li> >> + The AArch64 port now supports target attributes and pragmas. Please >> + refer to the documentation for details of available attributes and >> + pragmas as well as usage instructions. >> + </li> >> >> Here, isn't the second sentence the default assumption anyway, >> that is, do we need to highlight it specifically or can we omit >> it? > > My thinking was that when we introduce some new command-line option we list it > here and give a short description of it (new -mcpu values, for example). > However, here we introduce about 10 new target attributes and pragmas and listing > them all would make this entry too long for my liking so as a shorthand for listing > them all I chose to point to the documentation. > > Unless you feel strongly against this reasoning I'd like to commit the > patch as is within 48 hours. > > >> >> Please consider this feedback (and "let's keep it as is" is a >> fine response, too) and go ahead. >> >> Gerald >> > Hi Kyril, While you are at it, can you add it for the ARM entry a well ? many thanks Christian
On 15/09/15 13:18, Christian Bruel wrote: > Hi Kyril, > > On 09/02/2015 10:24 AM, Kyrill Tkachov wrote: >> Hi Gerald, >> >> On 01/09/15 18:29, Gerald Pfeifer wrote: >>> On Tue, 1 Sep 2015, Kyrill Tkachov wrote: >>>> This wwwdocs patch adds an entry to the GCC 6 changes page about the >>>> aarch64 target attributes and pragmas support. >>> Thanks for thinking of this, Kyrill. >> Thanks for the feedback. >> >>> Index: htdocs/gcc-6/changes.html >>> =================================================================== >>> + <li> >>> + The AArch64 port now supports target attributes and pragmas. Please >>> + refer to the documentation for details of available attributes and >>> + pragmas as well as usage instructions. >>> + </li> >>> >>> Here, isn't the second sentence the default assumption anyway, >>> that is, do we need to highlight it specifically or can we omit >>> it? >> My thinking was that when we introduce some new command-line option we list it >> here and give a short description of it (new -mcpu values, for example). >> However, here we introduce about 10 new target attributes and pragmas and listing >> them all would make this entry too long for my liking so as a shorthand for listing >> them all I chose to point to the documentation. >> >> Unless you feel strongly against this reasoning I'd like to commit the >> patch as is within 48 hours. >> >> >>> Please consider this feedback (and "let's keep it as is" is a >>> fine response, too) and go ahead. >>> >>> Gerald >>> > Hi Kyril, > > While you are at it, can you add it for the ARM entry a well ? Sure, I'll send a patch Kyrill > > many thanks > > Christian > >
Index: htdocs/gcc-6/changes.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.21 diff -U 3 -r1.21 changes.html --- htdocs/gcc-6/changes.html 13 Aug 2015 12:32:16 -0000 1.21 +++ htdocs/gcc-6/changes.html 19 Aug 2015 16:08:57 -0000 @@ -138,6 +138,15 @@ the global offset table (GOT) is limited to 28KiB under the LP64 SysV ABI , and 15KiB under the ILP32 SysV ABI. </li> + <li> + The AArch64 port now supports target attributes and pragmas. Please + refer to the documentation for details of available attributes and + pragmas as well as usage instructions. + </li> + <li> + Link-time optimization across translation units with different + target-specific options is now supported. + </li> </ul> <!-- <h3 id="arm">ARM</h3> -->