From patchwork Sun Jul 26 16:49:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 500080 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 20718140326 for ; Mon, 27 Jul 2015 02:50:09 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=sp//gxJX; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=mNYvmsymdmFW3v6+N 3b6RPj339tvvql+uVpF/7OnpBmQzZidu5bIlXJknPiR8waOeuj/bdaBxuYdDpOQd sachiwUurz4FJHfdqyirJQldzHt/OnLFZ+ZiVd924WYEC5HcTBrcERT10SGE2KD8 TKFAOGmWdec2LNE7iHftJo7Zjo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=NoDUZ/TVKbhSU2SJ2zw6O2a 5g38=; b=sp//gxJXKxf5QumVIodaAAhbJGwi0LuboXOUDnXB4oeuqbJ6hKH9Qi0 9A74GB+AinjRelcQsvoAa0iZ3YtsTQO6HioNJO9VkmRktqN83CG3FLGrIrCKdR1G xDOOXfF6QY3yr801W5WU8FmkRixURRMWcP7s9QdRYRJxr/2zzhWA= Received: (qmail 17597 invoked by alias); 26 Jul 2015 16:50:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17546 invoked by uid 89); 26 Jul 2015 16:50:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 26 Jul 2015 16:50:00 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49169) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZJP7e-0001rL-Cq for gcc-patches@gnu.org; Sun, 26 Jul 2015 12:49:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJP7Y-0002jz-TW for gcc-patches@gnu.org; Sun, 26 Jul 2015 12:49:57 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:43331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJP7Y-0002RA-Mx for gcc-patches@gnu.org; Sun, 26 Jul 2015 12:49:52 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZJP7A-0005YG-C8 from Tom_deVries@mentor.com for gcc-patches@gnu.org; Sun, 26 Jul 2015 09:49:28 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Sun, 26 Jul 2015 17:49:27 +0100 Message-ID: <55B50F85.3070408@mentor.com> Date: Sun, 26 Jul 2015 18:49:09 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "gcc-patches@gnu.org" Subject: Re: [PATCH] Allow non-overflow ops in vect_is_simple_reduction_1 References: <55B24E1F.1070705@mentor.com> In-Reply-To: <55B24E1F.1070705@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 24/07/15 16:39, Tom de Vries wrote: > Hi, > > this patch allows parallelization and vectorization of reduction > operators that are guaranteed to not overflow (such as min and max > operators), independent of the overflow behaviour of the type. > > Bootstrapped and reg-tested on x86_64. > > OK for trunk? > > Thanks, > - Tom Handle non-overflow reductions in graphite 2015-07-21 Tom de Vries * graphite-sese-to-poly.c (is_reduction_operation_p): Allow operations that do not overflow. --- gcc/graphite-sese-to-poly.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c index c583f16..531c848 100644 --- a/gcc/graphite-sese-to-poly.c +++ b/gcc/graphite-sese-to-poly.c @@ -2614,8 +2614,19 @@ is_reduction_operation_p (gimple stmt) if (FLOAT_TYPE_P (type)) return flag_associative_math; - return (INTEGRAL_TYPE_P (type) - && TYPE_OVERFLOW_WRAPS (type)); + if (ANY_INTEGRAL_TYPE_P (type)) + { + if (INTEGRAL_TYPE_P (type) + && TYPE_OVERFLOW_WRAPS (type)) + return true; + + if (no_overflow_tree_code (code, type)) + return true; + + return false; + } + + return false; } /* Returns true when PHI contains an argument ARG. */ -- 1.9.1