From patchwork Mon Jun 22 17:17:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 487308 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D7E34140129 for ; Tue, 23 Jun 2015 03:17:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=Mqzyp2nF; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=nxjCSR6wbu/D5O68V /nKkgixSPWjuNqGAgC5xVbNzZabfWfUAlwvXOvf+D/C8ksUzQhGwH+ZRV74uv359 sk7MnapRk6tKeF/vrqnyIQZRIOoQ0L8PYzP+cHYiBGlz2yGkum8dCVvTMnQyUC8M 2WhG7ClE4TV/zAxfhW2xTPcpAo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=uPJpmHebVhlGr+0dNUnwv11 EH9Q=; b=Mqzyp2nFHn2N4qrcaxBYNMQZlPJThYIWK3Ic3Hr9wwzlFaLN1pVjq8B 4zEdplQwptDWQZ96R9YvcE5y0YRiQdNfAZL90DNyjhpunvM+uFBl4cuvmuZngkki qcVpn85k0gC3DpJ0BoLsWTL/5s3cqiv0FXmxC/pp1DjUKDTuFwh4= Received: (qmail 84360 invoked by alias); 22 Jun 2015 17:17:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 83725 invoked by uid 89); 22 Jun 2015 17:17:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 22 Jun 2015 17:17:46 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52659) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1Z75Ls-0004JG-8w for gcc-patches@gnu.org; Mon, 22 Jun 2015 13:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z75Lj-0002eB-K6 for gcc-patches@gnu.org; Mon, 22 Jun 2015 13:17:43 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:37476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z75Lj-0002e6-DW for gcc-patches@gnu.org; Mon, 22 Jun 2015 13:17:35 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Z75Li-0000jD-ES from Tom_deVries@mentor.com ; Mon, 22 Jun 2015 10:17:34 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Mon, 22 Jun 2015 18:17:33 +0100 Message-ID: <55884326.1050603@mentor.com> Date: Mon, 22 Jun 2015 19:17:26 +0200 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jakub Jelinek CC: Subject: [committed] Test for flag_parallelize_loops > 1 References: <5583E052.2050207@mentor.com> In-Reply-To: <5583E052.2050207@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 19/06/15 11:26, Tom de Vries wrote: > Hi, > > DEF_GOMP_BUILTIN tests for 'flag_parallelize_loops'. But if > flag_parallelize_loops is one (which is also the default), then > pass_parloops doesn't do anything, and won't generate any OMP constructs. > > This patch makes DEF_GOMP_BUILTIN tests 'flag_parallelize_loops > 1', > just like all the other tests of flag_parallelize_loops in the compiler. > > Build on x86_64 and reg-tested libgomp's c.exp. > During bootstrap and reg-test, I found regressions for -fcilkplus. There's a dependency of fcilkplus on the gomp builtins, which is exposed by this patch. This updated patch also enables the gomp builtins for fcilkplus. Bootstrapped and reg-tested on x86_64 on top of trunk. Committed to trunk as obvious. Thanks, - Tom Test for flag_parallelize_loops > 1 2015-06-19 Tom de Vries * builtins.def (DEF_GOMP_BUILTIN): Test 'flag_tree_parallelize_loops > 1' instead of 'flag_tree_parallelize_loops'. Test flag_cilkplus. --- gcc/builtins.def | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/builtins.def b/gcc/builtins.def index 55ce9f6..80e4a9c 100644 --- a/gcc/builtins.def +++ b/gcc/builtins.def @@ -182,7 +182,9 @@ along with GCC; see the file COPYING3. If not see #define DEF_GOMP_BUILTIN(ENUM, NAME, TYPE, ATTRS) \ DEF_BUILTIN (ENUM, "__builtin_" NAME, BUILT_IN_NORMAL, TYPE, TYPE, \ false, true, true, ATTRS, false, \ - (flag_openmp || flag_tree_parallelize_loops \ + (flag_openmp \ + || flag_tree_parallelize_loops > 1 \ + || flag_cilkplus \ || flag_offload_abi != OFFLOAD_ABI_UNSET)) /* Builtin used by implementation of Cilk Plus. Most of these are decomposed -- 1.9.1