From patchwork Wed Jun 3 20:17:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Fran=C3=A7ois_Dumont?= X-Patchwork-Id: 480145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C4B641401F6 for ; Thu, 4 Jun 2015 06:17:30 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=tPpxO6Pu; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=BuafSv6RkUWFnP7vi xYl76NIyywhvDAqekw4rlnlGg4JJtP1VGIW1z/4Df8BPNandBqHhJJATY4nXBi1H RTid1icOLIGn2NB1jA69uBdo2l2gFxuQ8e0DnZ3uGY3zzlGsFg+mAaRI6LDiTM4w 94Zz4TsgA/BKptvw1N1ooMbVps= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=PiyjulbroOkVCNlg1p87Zkm qJDE=; b=tPpxO6Puf9b9cxh+X/MfWQULMryhf4RUTEPuj/4rBW2FtMWgM29a6JS pGsJKk9bJFhHkb28gN4lMZSlR7CdygNouXvDBObUZMTtmr6/yqn4rxQjXFjotOrK hiA5Gnx2qQuwA/NiyozoOWMZNE4Feu8ctvmQ82zEI7N96Xoenk0U= Received: (qmail 77790 invoked by alias); 3 Jun 2015 20:17:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 77770 invoked by uid 89); 3 Jun 2015 20:17:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f174.google.com Received: from mail-wi0-f174.google.com (HELO mail-wi0-f174.google.com) (209.85.212.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 03 Jun 2015 20:17:18 +0000 Received: by wibdq8 with SMTP id dq8so103733620wib.1; Wed, 03 Jun 2015 13:17:15 -0700 (PDT) X-Received: by 10.181.13.241 with SMTP id fb17mr46022015wid.13.1433362635810; Wed, 03 Jun 2015 13:17:15 -0700 (PDT) Received: from [192.168.0.22] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by mx.google.com with ESMTPSA id g15sm3158843wiv.22.2015.06.03.13.17.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 13:17:14 -0700 (PDT) Message-ID: <556F60C9.4080805@gmail.com> Date: Wed, 03 Jun 2015 22:17:13 +0200 From: =?windows-1252?Q?Fran=E7ois_Dumont?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jonathan Wakely CC: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: Fix 61347 testcase in alternative modes References: <556CBAC4.9050707@gmail.com> <20150601200918.GF17401@redhat.com> In-Reply-To: <20150601200918.GF17401@redhat.com> On 01/06/2015 22:09, Jonathan Wakely wrote: > On 01/06/15 22:04 +0200, François Dumont wrote: >> Hi >> >> I can't find how to fix 61347 for alternative modes. I started >> with debug mode by providing a forward declaration for safe iterator >> type which return to the __distance on normal iterator but gcc still >> doesn't consider it as a builtin constant. >> >> I guess the problem might come from compilations options, so is it >> that we should simply add a dg-require-normal-mode to have this test >> unsupported ? Otherwise any advise to fix this test ? > > Making it unsupported is OK. It's only testing that an optimisation > works, but it's OK if it only works in normal mode that's fine. > Attached patch applied then. 2015-06-03 François Dumont fdumont@gcc.gnu.org> * testsuite/23_containers/list/61347.cc: Add dg-require-normal-mode. François Index: testsuite/23_containers/list/61347.cc =================================================================== --- testsuite/23_containers/list/61347.cc (revision 224099) +++ testsuite/23_containers/list/61347.cc (working copy) @@ -1,4 +1,5 @@ // { dg-options "-std=gnu++11 -O2 -D_GLIBCXX_USE_CXX11_ABI" } +// { dg-require-normal-mode "" } // Copyright (C) 2015 Free Software Foundation, Inc. //