From patchwork Tue Apr 14 21:41:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kugan Vivekanandarajah X-Patchwork-Id: 461285 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6FC86140142 for ; Wed, 15 Apr 2015 07:41:36 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=PVGP3/5J; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=dF5Ao5d32pKhBhB9cAZZ4liTqh/+k0rTtYSZVOnVyBt JakMVCL5S1fVASjZ1jduWr09KXzFBrGp+hPeEwRJSU+U7GEvd5cgqfjB96TqRd49 AkpZIELpIPezXfluQzgnkgQJqwYZreGm1vh6SIQjPFVTn/pfqN3s9OAkfjaSyPl0 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=4DbESjdoDIewIsrKYDm3SeQ9coQ=; b=PVGP3/5JXkWq/CK4x XSkPUkIxkQdFlLA/Qei/xfuA7xY6ciqCGjTQFuNT5raeZQNyvPKTlO5653lVcM9q 6mcXd0FreEkcSROkiDhCeLf3uSbxsQmPxfaZAHQ8gPGNJ9B/UdjlWyDk4TKWo+IO x4LIGOi9EcyJtAPeOpKsh/tmic= Received: (qmail 99671 invoked by alias); 14 Apr 2015 21:41:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 99657 invoked by uid 89); 14 Apr 2015 21:41:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 14 Apr 2015 21:41:27 +0000 Received: by pacyx8 with SMTP id yx8so26011101pac.1 for ; Tue, 14 Apr 2015 14:41:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type; bh=4JZH4KaMCxB/U7gQuu26DklH9lnNAfzpoIU/xZngqWU=; b=ai0PJvvnhQcGZBg17EAGuK0/irCUpYjuQHWkxhAK4VynlgDKC5s6ouBk06dD+xmGFY NbgvgOOf/MDslqVEolDl6SaP+EZYOGeCmEheIejC3wdWtTXBjXsAwq3XVqvfNCaC7s4x ldhGw2SVmQkSsnuDPd5PpgL8i6kf3OCWckkpqgKpPgzaLHqQx/zPyaGtjLRIHmadV31A oQQsJlYkaYDr17S8hVz67Coj/UiTwhirq94ODObW8M5dP6oWXvyu0DKFKhsFObBskmCL AtvWHPQ8wAYoEMx0rIjwizycZtFk9OdRPDXi3JPG4gwvDxu6pqmcd3ayoCmcW5apJGdV Nj9w== X-Gm-Message-State: ALoCoQkJcQZefrGAtnL0iy28i1HR7bUg6XbwovYhPaQK5eJgBldYaHyKS3fRa7gYM9RBTQJdFv2Z X-Received: by 10.66.164.98 with SMTP id yp2mr39692970pab.114.1429047684985; Tue, 14 Apr 2015 14:41:24 -0700 (PDT) Received: from [10.1.1.6] (58-6-183-210.dyn.iinet.net.au. [58.6.183.210]) by mx.google.com with ESMTPSA id mt11sm2036503pbc.20.2015.04.14.14.41.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 14:41:24 -0700 (PDT) Message-ID: <552D897C.2040207@linaro.org> Date: Wed, 15 Apr 2015 07:41:16 +1000 From: Kugan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: Marcus Shawcroft , james.greenhalgh@arm.com, Maxim Kuvyrkov , Richard Earnshaw Subject: [AArch64][PR65139] use clobber with match_scratch for aarch64_lshr_sisd_or_int_3 X-IsSubscribed: yes This patch uses clobber with match_scratch instead of earlyclobber for aarch64_lshr_sisd_or_int_3 so that RA can have more freedom in selecting suitable register, as discussed in http://thread.gmane.org/gmane.comp.gcc.patches/336162 and reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65139. This is based on Maxim's patch. I have bootstrapped and regression tested on aarch64-linux-gnu with no new regressions. Is this OK for trunk? Thanks, Kugan gcc/ChangeLog: 2015-04-15 Kugan Vivekanandarajah Maxim Kuvyrkov PR target/65139 * config/aarch64/aarch64.md (3): Expand lshr with gen_aarch64_lshr_sisd_or_int_3. (*aarch64_lshr_sisd_or_int_3): Rename to aarch64_lshr_sisd_or_int_3 and use clobber with match_scratch instead of early clobber. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 534a862..07fa035 100644 --- a/gcc/config/aarch64/aarch64.md +++ b/gcc/config/aarch64/aarch64.md @@ -3277,6 +3277,12 @@ DONE; } } + + if (strcmp ("", "lshr") == 0) + { + emit_insn (gen_aarch64_lshr_sisd_or_int_3 (operands[0], operands[1], operands[2])); + DONE; + } } ) @@ -3361,11 +3367,12 @@ ) ;; Logical right shift using SISD or Integer instruction -(define_insn "*aarch64_lshr_sisd_or_int_3" - [(set (match_operand:GPI 0 "register_operand" "=w,&w,r") +(define_insn "aarch64_lshr_sisd_or_int_3" + [(set (match_operand:GPI 0 "register_operand" "=w,w,r") (lshiftrt:GPI (match_operand:GPI 1 "register_operand" "w,w,r") - (match_operand:QI 2 "aarch64_reg_or_shift_imm_" "Us,w,rUs")))] + (match_operand:QI 2 "aarch64_reg_or_shift_imm_" "Us,w,rUs"))) + (clobber (match_scratch:QI 3 "=X,w,X"))] "" "@ ushr\t%0, %1, %2 @@ -3379,30 +3386,28 @@ [(set (match_operand:DI 0 "aarch64_simd_register") (lshiftrt:DI (match_operand:DI 1 "aarch64_simd_register") - (match_operand:QI 2 "aarch64_simd_register")))] + (match_operand:QI 2 "aarch64_simd_register"))) + (clobber (match_scratch:QI 3))] "TARGET_SIMD && reload_completed" [(set (match_dup 3) (unspec:QI [(match_dup 2)] UNSPEC_SISD_NEG)) (set (match_dup 0) (unspec:DI [(match_dup 1) (match_dup 3)] UNSPEC_SISD_USHL))] - { - operands[3] = gen_lowpart (QImode, operands[0]); - } + "" ) (define_split [(set (match_operand:SI 0 "aarch64_simd_register") (lshiftrt:SI (match_operand:SI 1 "aarch64_simd_register") - (match_operand:QI 2 "aarch64_simd_register")))] + (match_operand:QI 2 "aarch64_simd_register"))) + (clobber (match_scratch:QI 3))] "TARGET_SIMD && reload_completed" [(set (match_dup 3) (unspec:QI [(match_dup 2)] UNSPEC_SISD_NEG)) (set (match_dup 0) (unspec:SI [(match_dup 1) (match_dup 3)] UNSPEC_USHL_2S))] - { - operands[3] = gen_lowpart (QImode, operands[0]); - } + "" ) ;; Arithmetic right shift using SISD or Integer instruction