From patchwork Tue Jul 11 12:23:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 786588 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x6Lqk5h0Sz9s8J for ; Tue, 11 Jul 2017 22:24:32 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="jQOEhEDz"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=nxk0Qk3F8qrQyxX5rjwqsWbUVS9uF+5iKPJvL6jCOO0eHwbW2y osqKHyMjYTWsVG5QeyKfjvg/5wea7pigM28UH+xUszlVMxjspFBs6maA9l5o86FX lwAJIdr35MtY6Ft+lq8yb+I8C8z1sowdEwvDwZjqLx+OuH9b014Xy+NTk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=pQodaiOT5AlNYufHnUdmLG732wA=; b=jQOEhEDzTBg0nWxV0OxY 8exoTr2AzGJXaVx5jhAJG6ztRfAAW/N1J7c6NgwjmgL4Y3Ysr1d49qPvtg8ycN47 4ZVMnlQmrQxsfVzB5Ft3n0k4cznMpYJHlGzfuiH3uVtbNWxKeCPtAIqMTRwDZHGm tPK4BHU1USreVAyY8eVLU+s= Received: (qmail 70666 invoked by alias); 11 Jul 2017 12:24:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 70626 invoked by uid 89); 11 Jul 2017 12:24:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:sk:public-, Hx-spam-relays-external:sk:public-, H*r:sk:public- X-HELO: mail-it0-f47.google.com Received: from mail-it0-f47.google.com (HELO mail-it0-f47.google.com) (209.85.214.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Jul 2017 12:24:01 +0000 Received: by mail-it0-f47.google.com with SMTP id k192so18029888ith.1 for ; Tue, 11 Jul 2017 05:24:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version; bh=hlrKsmG11kgQs2rRH73LEmnNMvNFUOum6e/QxAEpYqQ=; b=bXRaIuV2jVM4MnxBQMJPXoqBlYjHTC3RXFNuTRUV24TAyQ7tmAVVqUl2/j4llqsFHM TGYaJU4M5NhterJ6r5ITR8K2FmbjsC2tpfNFPgPvKr3CQBApM6rpW/V0UZ/lkjE8Dln6 xB9k0XUVYBtHh8e03l6omjrLpS46J0hAFvmikkgL0GhdKn2EaD89Gsskzp7dOS5gUb/p bBsWZo4d62Yf1z1cJjSIkv9uqFWD0IRnxTV6bMveu2DsucTVw19c4BejTGFmDtaeH21R eR82hXZUK1KtkUa2D1gMcSlw3D1+GoadWKTcbiUX/5JYJccrSYXPqxLVU6WrBvy8LZrF OPIA== X-Gm-Message-State: AIVw111IiCLiT8EiwAJgka1pk5JrgqMiz/8LmG4igj7BTLvQjUBPn+c7 tqKXPvGk/ag+/w== X-Received: by 10.107.59.216 with SMTP id i207mr7800569ioa.204.1499775840090; Tue, 11 Jul 2017 05:24:00 -0700 (PDT) Received: from [100.64.209.104] (public-117-90.nat.utoronto.ca. [138.51.117.90]) by smtp.googlemail.com with ESMTPSA id s135sm6828163ita.2.2017.07.11.05.23.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 05:23:59 -0700 (PDT) To: GCC Patches From: Nathan Sidwell Subject: [PATCH] remove useless check Message-ID: <54bea7ed-63d1-02f5-2f15-7e04d9ea34af@acm.org> Date: Tue, 11 Jul 2017 08:23:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In killing TYPE_METHODS I discovered this useless check. We already cull these ctors from the methods just after creating the struct. bootstrap with the continue turned into gcc_unreachable worked just fine. applied to trunk. nathan Index: dwarf2out.c =================================================================== --- dwarf2out.c (revision 250090) +++ dwarf2out.c (working copy) @@ -24207,10 +24207,6 @@ gen_member_die (tree type, dw_die_ref co /* Don't include clones in the member list. */ if (DECL_ABSTRACT_ORIGIN (member)) continue; - /* Nor constructors for anonymous classes. */ - if (DECL_ARTIFICIAL (member) - && dwarf2_name (member, 0) == NULL) - continue; child = lookup_decl_die (member); if (child)