| Message ID | 54F658DB.6030200@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Mar 03, 2015 at 05:59:07PM -0700, Martin Sebor wrote: > The attached patch resolves PR 65286 by adding --disable-multilib > when configuring for a ppc64le target. Why? The PR does not say; it suggests there is an error somewhere that configuring with --disable-multilib papers over. Segher
Martin Sebor <msebor@redhat.com> writes: > The attached patch resolves PR 65286 by adding --disable-multilib > when configuring for a ppc64le target. If powerpc64le doesn't want multilib it should not set any multilib parameters. Andreas.
On 03/04/15 06:43, Andreas Schwab wrote: > Martin Sebor <msebor@redhat.com> writes: > >> The attached patch resolves PR 65286 by adding --disable-multilib >> when configuring for a ppc64le target. > > If powerpc64le doesn't want multilib it should not set any multilib > parameters. Agreed, and it's debatable whether or not ppc64le should have any multilibs at this time. That's a decision I leave to the ppc maintainers to answer. I think the concern is that simply disabling the multilib without looking at the underlying failure may be papering over a real bug. jeff
On 03/04/2015 09:19 AM, Jeff Law wrote: > On 03/04/15 06:43, Andreas Schwab wrote: >> Martin Sebor <msebor@redhat.com> writes: >> >>> The attached patch resolves PR 65286 by adding --disable-multilib >>> when configuring for a ppc64le target. >> >> If powerpc64le doesn't want multilib it should not set any multilib >> parameters. > Agreed, and it's debatable whether or not ppc64le should have any > multilibs at this time. That's a decision I leave to the ppc > maintainers to answer. > > I think the concern is that simply disabling the multilib without > looking at the underlying failure may be papering over a real bug. The configure script explicitly adds --enable-multilib unless --disable-multilib is specified. This then results in libraries being built with the -m32 option, which fails with errors like the one below: /usr/include/gnu/stubs.h:8:27: fatal error: gnu/stubs-32.h: No such file or directory Martin
On 03/04/15 09:40, Martin Sebor wrote: > On 03/04/2015 09:19 AM, Jeff Law wrote: >> On 03/04/15 06:43, Andreas Schwab wrote: >>> Martin Sebor <msebor@redhat.com> writes: >>> >>>> The attached patch resolves PR 65286 by adding --disable-multilib >>>> when configuring for a ppc64le target. >>> >>> If powerpc64le doesn't want multilib it should not set any multilib >>> parameters. >> Agreed, and it's debatable whether or not ppc64le should have any >> multilibs at this time. That's a decision I leave to the ppc >> maintainers to answer. >> >> I think the concern is that simply disabling the multilib without >> looking at the underlying failure may be papering over a real bug. > > The configure script explicitly adds --enable-multilib unless > --disable-multilib is specified. This then results in libraries > being built with the -m32 option, which fails with errors like > the one below: > > /usr/include/gnu/stubs.h:8:27: fatal error: gnu/stubs-32.h: No such file > or directory Ah, yes, lack of 32bit glibc for ppc64le would cause this. Unless the IBM-ers are planning a 32bit glibc for ppc64le, then this patch makes perfect sense. jeff
Martin Sebor <msebor@redhat.com> writes: > The configure script explicitly adds --enable-multilib unless > --disable-multilib is specified. This then results in libraries > being built with the -m32 option, which fails with errors like > the one below: > > /usr/include/gnu/stubs.h:8:27: fatal error: gnu/stubs-32.h: No such file > or directory So fix the multilib configuration. Andreas.
diff --git a/ChangeLog b/ChangeLog index bd43281..46ec13d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2015-03-03 Martin Sebor <msebor@redhat.com> + + PR target/65286 + * configure.ac (powerpc64le-*): Disable multilib. + * configure: Regenerate. + 2015-03-13 Jeff Law <law@redhat.com> * MAINTAINERS: Remove Paul Brook as a Fortran and ARM diff --git a/configure b/configure index 9de7295..168bf4c 100755 --- a/configure +++ b/configure @@ -7378,6 +7378,15 @@ if test x${is_cross_compiler} = xyes ; then target_configargs="--with-cross-host=${host_noncanonical} ${target_configargs}" fi +# There is no multilib support on ppc64le. Disable it unless it's +# explicitly enabled. +case "$target:$have_compiler:$enable_multilib" in + powerpc64le-*:yes:) + target_configargs="--disable-multilib ${target_configargs}" + enable_multilib=no + ;; +esac + # Special user-friendly check for native x86_64-linux build, if # multilib is not explicitly enabled. case "$target:$have_compiler:$host:$target:$enable_multilib" in diff --git a/configure.ac b/configure.ac index 00f7452..5ad3211 100644 --- a/configure.ac +++ b/configure.ac @@ -3021,6 +3021,15 @@ if test x${is_cross_compiler} = xyes ; then target_configargs="--with-cross-host=${host_noncanonical} ${target_configargs}" fi +# There is no multilib support on ppc64le. Disable it unless it's +# explicitly enabled. +case "$target:$have_compiler:$enable_multilib" in + powerpc64le-*:yes:) + target_configargs="--disable-multilib ${target_configargs}" + enable_multilib=no + ;; +esac + # Special user-friendly check for native x86_64-linux build, if # multilib is not explicitly enabled. case "$target:$have_compiler:$host:$target:$enable_multilib" in