From patchwork Fri Feb 6 06:19:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 437058 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BB4F5140082 for ; Fri, 6 Feb 2015 17:19:58 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=BEA72FRGKn/isoAiTR0OwN4/593fNYBCNZyqZgLcdo4+85 rOXtkbiWMvAU17/DKbqBDS9a6pyiIMdxB22SdaoTHiDKNv/pXKNMM9Y5h1jG/w4v Oi+/gO6c2mkY/lbcjBjcjoIxmPflcLN9UgFTnzHjJ+FkTHW/QDnB/Ytusj6uw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=FMRl3dgMfX5YLaD9E1zE49NHf/A=; b=E9xb0Od5jx7mSqKi6xRf 9TI8zvdvvEwLeAyVBxw4tBXKpsjqETyxu8Gbz6Gfe0NRkG9CO1V8hoQsZwxeijo5 JSrm091EjutfCHqJEp7k1LDmMi17YTsKx6045Btz9yclmqGhlR/SRDwBlbXyKZFc ozfcEFSPyXjCSQZAtrchc9g= Received: (qmail 9009 invoked by alias); 6 Feb 2015 06:19:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 8994 invoked by uid 89); 6 Feb 2015 06:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Feb 2015 06:19:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t166JNj2007348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 6 Feb 2015 01:19:23 -0500 Received: from [10.3.113.80] (ovpn-113-80.phx2.redhat.com [10.3.113.80]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t166JMPA017420 for ; Fri, 6 Feb 2015 01:19:23 -0500 Message-ID: <54D45CEA.8090200@redhat.com> Date: Thu, 05 Feb 2015 23:19:22 -0700 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org Subject: [PATCH][target/17306] Fix funcvec and eightbit_data attribute handling on H8/300 port X-IsSubscribed: yes This is actually a long standing regression (though it's not marked that way in the BZ database). Basically there was a change from encoding the funcvec and eighbit_data attributes in the symbol name to instead putting them in the function decl's flags. This was, IMHO, a good thing. Unfortunately the transition wasn't totally completed and with no tests in the suite, the author of the transition wasn't aware of the deficiencies. The PR complains about funcvec not working. But upon inspection I found a place where eightbit_data wasn't working and in building the tests I found a place where we should be accepting eightbit_data operands but weren't. Tested by building gcc, libgcc & newlib and running the testsuite for h8300-elf with no regressions. Installed on the trunk. jeff commit 6e5dc637c92a02eb1c0186125fa84c7c39bd8292 Author: Jeff Law Date: Thu Feb 5 22:29:12 2015 -0700 PR target/43264 * config/h8300/h8300.c (get_shift_alg): Fix ASHIFTRT by 24 to 28 bits for the H8/300. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 90cee31..2bbfeb3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-02-05 Jeff Law + + PR target/43264 + * config/h8300/h8300.c (get_shift_alg): Fix ASHIFTRT by + 24 to 28 bits for the H8/300. + 2015-02-06 Alan Modra PR target/64876 diff --git a/gcc/config/h8300/h8300.c b/gcc/config/h8300/h8300.c index 5968e55..4bd4787 100644 --- a/gcc/config/h8300/h8300.c +++ b/gcc/config/h8300/h8300.c @@ -4384,7 +4384,7 @@ get_shift_alg (enum shift_type shift_type, enum shift_mode shift_mode, info->cc_inline = CC_SET_ZNV; goto end; case SHIFT_ASHIFTRT: - info->special = "mov.b\t%z0,%w0\n\tbld\t#7,%w0\n\tsubx\t%x0,%x0\n\tsubx\t%x0,%x0\n\tsubx\t%x0,%x0"; + info->special = "mov.b\t%z0,%w0\n\tbld\t#7,%w0\n\tsubx\t%x0,%x0\n\tsubx\t%y0,%y0\n\tsubx\t%z0,%z0"; info->shift1 = "shar.b\t%w0"; info->cc_inline = CC_SET_ZNV; goto end;