diff mbox

[AArch64] Remove crypto extension from default for cortex-a53, cortex-a57

Message ID 5474A99A.2040607@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov Nov. 25, 2014, 4:08 p.m. UTC 
On 25/11/14 01:36, Gerald Pfeifer wrote:
> On Tuesday 2014-11-18 09:38, Kyrill Tkachov wrote:
>> Here's what I propose.
> +     <li> The cryptographic extensions to the ARMv8-A architecture are no
> +       longer enabled by default when specifying the
> +       <code>-mcpu=cortex-a53</code>, <code>-mcpu=cortex-a57</code> or
> +       <code>-mcpu=cortex-a57.cortex-a53</code> options.  To enable these
> +       extensions add the <code>+crypto</code> extension to your given
> +       <code>-mcpu</code> or <code>-march</code> options' value.
>
> "option's"?
>
> Or better "to the value of your...option(s)"?

Ok, I've reworded it and added a small example to demonstrate.

>
> The description talks about -mcpu and mentions -march only once.
> Isn't this a bit confusing?

The change is to the behaviour of -mcpu, not -march. -march is only 
mentioned as a way of getting the
previous behaviour if the user so wishes.

How about this amendment?

Thanks for looking at it,
Kyrill

>
> Gerald

Comments

Gerald Pfeifer Nov. 26, 2014, 1:31 p.m. UTC | #1 
On Tuesday 2014-11-25 16:08, Kyrill Tkachov wrote:
> The change is to the behaviour of -mcpu, not -march. -march is only 
> mentioned as a way of getting the previous behaviour if the user so 
> wishes.

Ah, okay.

> How about this amendment?

Where you have "add the <code>+crypto</code> extension to the value"
I suggest to just say "add <code>+crypto</code> to the value".  That
avoids using extension twice in the same sentence, for two different
things.

Go ahead and commit then.  Thanks!

Gerald
diff mbox

Patch

Index: htdocs/gcc-5/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v
retrieving revision 1.41
diff -U 3 -r1.41 changes.html
--- htdocs/gcc-5/changes.html	23 Nov 2014 14:42:28 -0000	1.41
+++ htdocs/gcc-5/changes.html	25 Nov 2014 16:05:01 -0000
@@ -376,8 +376,9 @@ 
        are no longer enabled by default when specifying the
        <code>-mcpu=cortex-a53</code>, <code>-mcpu=cortex-a57</code> or
        <code>-mcpu=cortex-a57.cortex-a53</code> options.  To enable these
-       extensions add the <code>+crypto</code> extension to your given
-       <code>-mcpu</code> or <code>-march</code> options' value.
+       extensions add the <code>+crypto</code> extension to the value of
+       <code>-mcpu</code> or <code>-march</code> e.g.
+       <code>-mcpu=cortex-a53+crypto</code>.
      </li>
      <li>Support for the Cavium ThunderX processor is now available through the
     <code>-mcpu=thunderx</code> and <code>-mtune=thunderx</code> options.